Re: Plugin dependency resolution

2021-02-10 Thread Tamás Cservenák
Hi Robert, I agree with you: is a really small change. Re non-exported packages: will take a look into those a bit more, my POC was just at "artifact level"... (but given Maven toss away downloaded plugin dependency, is plugin today able to use core artifact's non-exported package?) Yes, several m

Re: Plugin dependency resolution

2021-02-10 Thread Robert Scholte
Hi Tamas, based on the number of lines you wrote versus the amount of downloads that are prevented (and storage) I think it is worth adding. My biggest worry about this solution was about the non exported packages of the exported artifacts. Would such changes have a negative and inconsistent eff

Re: [External] : Re: JDK 16 is now in the Release Candidate Phase

2021-02-10 Thread Robert Scholte
For those who are interested: There was indeed a difference in the JDK version per OS: On Windows it was JDK-16+24, while Ubuntu was already on JDK-16+30. In JDK-16+28 the changes for JEP 396[1] were added, meaning "Strongly Encapsulate JDK Internals by Default" This has been a known issue for Gr

Re: [External] : Re: JDK 16 is now in the Release Candidate Phase

2021-02-10 Thread Rory O'Donnell
Thanks for the update Sylwester Rgds,Rory On 10/02/2021 14:12, Sylwester Lachiewicz wrote: Hi, we fixed our integration tests for Maven components with Groovy and few old plugin updates. Other than that we have only known failures - not related to JDK 16. Best regards, Sylwester pon., 8 l

Re: [External] : Re: JDK 16 is now in the Release Candidate Phase

2021-02-10 Thread Sylwester Lachiewicz
Hi, we fixed our integration tests for Maven components with Groovy and few old plugin updates. Other than that we have only known failures - not related to JDK 16. Best regards, Sylwester pon., 8 lut 2021 o 11:50 Rory O'Donnell napisał(a): > > Hi Robert, > > Looks like logging a Groovy bug mak

Re: Maven compiler plugin Unsupported major.minor version

2021-02-10 Thread Benjamin Marwell
Hi Andrea, thank you very much! I can confirm that this should not happen. The error seems to be that the preparePaths method tries to parse the existing module-info.class, but does not use the Toolchain provided JDK for this. The issue for this: https://issues.apache.org/jira/browse/MCOMPILER-45

Re: Plugin dependency resolution

2021-02-10 Thread Tamás Cservenák
Just for fun, tried it on another, a bit bigger project (137 modules), and as 3.6.3 and master was "so close", tried master and patch only: mvn master (4.0.0-alpha-1, ab20190a1a9fecdc8f85b40e8d03d806f3da4fc6) total time 1:49 min total files in local repo: 7679 total bytes in local repo: 652624 cou

Plugin dependency resolution

2021-02-10 Thread Tamás Cservenák
Howdy, Some time ago I stumbled upon Robert S. remark in "[DISCUSS] MNG-7020 Remove Maven 2 WagonExcluder backward compat code" thread: "Why download, if they are being removed from the classpath afterwards due to classworld config". Similarly, there is a thread "maven-site-plugin and sisu-inject-