Re: [CANCELLED] [VOTE] Release Apache Maven JXR version 3.1.0

2021-02-05 Thread Nelson,Matt
The discovered issue has been fixed. Can another vote be started? On 2020/05/25 20:00:58, Hervé BOUTEMY mailto:h...@free.fr>> wrote: > blocking issue found: we'll fix and do a new release soon> > > Le samedi 23 mai 2020, 17:03:24 CEST Hervé BOUTEMY a écrit :> > > Hi,> > > > > > We solved 6 issues:

Re: [External] : Re: JDK 16 is now in the Release Candidate Phase

2021-02-05 Thread Robert Scholte
I've been to reproduce it again: Jenkins: https://ci-builds.apache.org/job/Maven/job/jdk16-ea/2/console Sources: https://github.com/rfscholte/jdk16-ea Most important lines: Failed to execute goal org.codehaus.gmaven:gmaven-plugin:1.4:execute (default) on project mcompiler-182: Execution default

Re: [External] : Re: JDK 16 is now in the Release Candidate Phase

2021-02-05 Thread Robert Scholte
Hi Rory, I hope I can isolate the issue and come with a clear description. thanks, Robert On 5-2-2021 17:18:11, Rory O'Donnell wrote: Hi Robert, Could you log a bug and send the JI number ? Thanks, Rory On 05/02/2021 11:45, Rory O'Donnell wrote: > Hi Robert, > > I've been asked if you can pro

Re: JSR330 in extensions and plugins, Singleton or not Singleton

2021-02-05 Thread Romain Manni-Bucau
Guess we can do something like that or more js like http://tomee.apache.org/developer/classloading/index.html but specific to maven, mojo classloading is almost obvious but core and extension ones are not IMHO. Then we can just mention that for the IoC + it uses Guice with a custom registration imp

Re: [External] : Re: JDK 16 is now in the Release Candidate Phase

2021-02-05 Thread Rory O'Donnell
Hi Robert, Could you log a bug and send the JI number ? Thanks, Rory On 05/02/2021 11:45, Rory O'Donnell wrote: Hi Robert, I've been asked if you can provide a link to the exception, we can't immediately find it on your Jenkins. If we can get to the stack trace then it might reveal a bit mor

Re: JSR330 in extensions and plugins, Singleton or not Singleton

2021-02-05 Thread Paul Hammant
OK, my bad, I thought we were talking about Maven's internals for itself. Classloader trees, hidden implementations, security policies for the JVM are stand out features that they nailed in 1995/6/7. I once drew a pretty pic of Tomcat's classloader setup - https://paulhammant.com/images/tomcat_cl

Re: JSR330 in extensions and plugins, Singleton or not Singleton

2021-02-05 Thread Romain Manni-Bucau
@Paul: not really, none define any behavior (note that the class loader tree implementation is a vendor choice, several certified EE servers do handle singleton per tree or per loader of the tree and it is compliant). Only @inject tests are https://github.com/eclipse-ee4j/injection-tck/blob/2ef97bf

Re: JSR330 in extensions and plugins, Singleton or not Singleton

2021-02-05 Thread Paul Hammant
> > JSR 330 has a TCK that defines a lot. A system that purports to facilitate > injection into contained components (plugins or lesser) doesn’t have to > implement all facets of that TCK but could do so out of the box by just > using (say) guice or dagger in a class loader tree implementation.

Re: JSR330 in extensions and plugins, Singleton or not Singleton

2021-02-05 Thread Romain Manni-Bucau
@Tamas, right but this page https://maven.apache.org/maven-jsr330.html does say the opposite for example, this is why I think we should create a ticket to revise the doc which is misleading as of today Romain Manni-Bucau @rmannibucau | Blog

Re: [External] : Re: JDK 16 is now in the Release Candidate Phase

2021-02-05 Thread Rory O'Donnell
Hi Robert, I've been asked if you can provide a link to the exception, we can't immediately find it on your Jenkins. If we can get to the stack trace then it might reveal a bit more. The temporary workaround is to open java.lang of course. Rgds,Rory On 05/02/2021 11:18, Robert Scholte wrote:

Re: JSR330 in extensions and plugins, Singleton or not Singleton

2021-02-05 Thread Tamás Cservenák
When I read "jsr330" (in maven context), I always "replace it" with SISU in my head, as Maven is SISU powered. So there is nothing undefined for me, as SISU defines all the "blind spots" IMO. Maven, while it may look so, will NOT work with any other JSR330 implementation, just SISU. Maven 3 was ma

Re: JSR330 in extensions and plugins, Singleton or not Singleton

2021-02-05 Thread Romain Manni-Bucau
Issue with JSR330 is that it is a standard "nothing" since it does not define any behavior behind the annotations so it is pointless to have this standard since all the behavior is vendor dependent and therefore we must fix that by a good doc. Wonder if we should define more explicitly and not accr

Re: JDK 16 is now in the Release Candidate Phase

2021-02-05 Thread Robert Scholte
Hi Rory, we're seeing some projects failing due to JDK16 + Linux[1], and I think they all have a similar issue. The error looks like this: Unable to make public java.lang.AbstractStringBuilder java.lang.AbstractStringBuilder.append(char[],int,int) accessible: module java.base does not "opens ja

Re: JSR330 in extensions and plugins, Singleton or not Singleton

2021-02-05 Thread Paul Hammant
CDI came after JSR330 I think. I was on the JSR330 experts group. I could be wrong there. Back history of dependency injection - it was an antidote to classic GoF service-locator being used everywhere in Javaland. When we co-created PicoContainer we were careful to avoid Singleton as a term or idi

JDK 16 is now in the Release Candidate Phase

2021-02-05 Thread Rory O'Donnell
*Hi Robert , * *Per the JDK 16 schedule , we are in the Release Candidate Phase**[1] .* *Please advise if you find any issues while testing the latest Early Access builds.* * Schedule for JDK 16 o *2021/02/04 Initial Release Candidate* o 2021/02/18 Final Release Candidate o 2

Re: JSR330 in extensions and plugins, Singleton or not Singleton

2021-02-05 Thread Romain Manni-Bucau
In CDI there is a definition which sounds like "an instance is a singleton in its context", context being the bean lookup definition. In maven it means calling Guice for current ClassRealm (the classloader of currently executed component - plugin for ex) so it matches. Long story short "singleton"

Re: JSR330 in extensions and plugins, Singleton or not Singleton

2021-02-05 Thread Tamás Cservenák
Just add few cents to Stuart superb answer: the singleton scope depends on the "realm" (no idea how to call it better) where it is singleton, as the "lifespan" of realm may not be same/aligned. Core and Core Extension lifespan vs Mojo/Plugin lifespan is clearly not the same... Also, take a peek at

[GitHub] [maven-site] jnerlich commented on pull request #227: Add vogella as a provider of training

2021-02-05 Thread GitBox
jnerlich commented on pull request #227: URL: https://github.com/apache/maven-site/pull/227#issuecomment-773154203 thanks @McFoggy for the feedback, this was a typo and has been corrected. This is an automated message from th

[GitHub] [maven-site] jnerlich commented on a change in pull request #227: Add vogella as a provider of training

2021-02-05 Thread GitBox
jnerlich commented on a change in pull request #227: URL: https://github.com/apache/maven-site/pull/227#discussion_r570120132 ## File path: content/markdown/support-and-training.md ## @@ -57,6 +57,14 @@ When you walk away from this class, you will know how to: Public virtual

[GitHub] [maven-site] asfgit closed pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-02-05 Thread GitBox
asfgit closed pull request #225: URL: https://github.com/apache/maven-site/pull/225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: JSR330 in extensions and plugins, Singleton or not Singleton

2021-02-05 Thread Matthieu Brouillard
Thank you Stuart for the detailed reply. On Fri, Feb 5, 2021 at 12:02 AM Stuart McCulloch wrote: > Here's a quick patch that does the split: > https://gist.github.com/mcculls/d22f01b0e380fdd9f9e2ac1e1bba7dd0 > > With these changes I get the following output: > > mvn validate > [INFO] extension g