Re: JSR330 in extensions and plugins, Singleton or not Singleton

2021-02-04 Thread Stuart McCulloch
Here's a quick patch that does the split: https://gist.github.com/mcculls/d22f01b0e380fdd9f9e2ac1e1bba7dd0 With these changes I get the following output: mvn validate [INFO] extension generated information: Build started at 1612479700634 [INFO] Scanning for projects... [INFO] [INFO] -

Re: JSR330 in extensions and plugins, Singleton or not Singleton

2021-02-04 Thread Stuart McCulloch
Yes it's down to classloading - the extension and plugin have different classloaders and the InfoHolder class loaded by the extension is different to the one loaded by the plugin. They may share the same name and have the same original bytecode, but they were defined by different classloaders. You

Re: JSR330 in extensions and plugins, Singleton or not Singleton

2021-02-04 Thread Matthieu Brouillard
Hum some words have disappeared from my previous mail. The project URL is https://github.com/McFoggy/maven-jsr330-demo . And the corrected sentence is: You will see that the project is simple... Sorry for the double post. On Thu, Feb 4, 2021 at 9:2

JSR330 in extensions and plugins, Singleton or not Singleton

2021-02-04 Thread Matthieu Brouillard
Hi all, As I was trying to cleanup & simplify my plugins by moving to JSR330, I came across a weird use case in which a `@Singleton` object exists multiple times (several instances) during the build: - it is first used by an extension, to store some value - then used in a mojo to retrieve and prin

[GitHub] [maven-site] asfgit closed pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-02-04 Thread GitBox
asfgit closed pull request #225: URL: https://github.com/apache/maven-site/pull/225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[VOTE] Release Apache Maven Shared Invoker version 3.1.0

2021-02-04 Thread Sylwester Lachiewicz
Hi, We solved 4 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922&version=12344858&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHARED%20AND%20resolution%20%3D%20Unresolved%20AND%20compo

[GitHub] [maven-site] jnerlich commented on a change in pull request #227: Add vogella as a provider of training

2021-02-04 Thread GitBox
jnerlich commented on a change in pull request #227: URL: https://github.com/apache/maven-site/pull/227#discussion_r570120132 ## File path: content/markdown/support-and-training.md ## @@ -57,6 +57,14 @@ When you walk away from this class, you will know how to: Public virtual

[GitHub] [maven-site] jnerlich commented on pull request #227: Add vogella as a provider of training

2021-02-04 Thread GitBox
jnerlich commented on pull request #227: URL: https://github.com/apache/maven-site/pull/227#issuecomment-773154203 thanks @McFoggy for the feedback, this was a typo and has been corrected. This is an automated message from th