[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-18 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762494128 One recurring error is: ```log Error: |[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.10.0-SNAPSHOT:site (default-cli) on pr

[GitHub] [maven-site-plugin] elharo commented on pull request #34: [DOXIA-616]

2021-01-18 Thread GitBox
elharo commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762430570 That one wasn't merged by me. :-) This is an automated message from the Apache Git Service. To respond to t

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-18 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762210778 Also, PR #35 just got merged to *master* 3 days ago, with the same CI failures. This is an automated

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-18 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762209071 This was just a temporary network issue of GitHub Actions. If you re-run the workflow, you won't get these errors. ---

[GitHub] [maven-site-plugin] elharo commented on pull request #34: [DOXIA-616]

2021-01-18 Thread GitBox
elharo commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762208210 Some though not all of the errors seem related to this: : |[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.10.0-SNAPSHOT:site (def

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-18 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762207488 I have full permissions on my fork, and it's running all GitHub Actions as well, and failing at the same place (macOS with JDK11, 14 and 15). But I can't find a way to

[GitHub] [maven-site-plugin] elharo commented on pull request #34: [DOXIA-616]

2021-01-18 Thread GitBox
elharo commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762205983 It might need someone who has more permissions on the project. I'm not sure. This is an automated message f

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-18 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762198733 @elharo We cannot access the integration test logs, how are we going to fix this? This is an automate

[GitHub] [maven-site-plugin] elharo commented on pull request #34: [DOXIA-616]

2021-01-18 Thread GitBox
elharo commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762197773 Before this can move further, someone needs to debug and fix the CI failures. That's likely not caused by this PR, but checking in when the CI is broken is never a good ide

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-18 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762187924 @hboutemy @michael-o @elharo Will you have a chance to review these changes? This ensures the **maven-site-plugin** integration tests don't break when upgrading from D

Re: Logging api in plugins

2021-01-18 Thread Romain Manni-Bucau
Hi +1 to explicit it. About message formatting it is not critical for me and enables to switch the impl at will without being impl locked so maybe rather add lazy evaluation with lambdas like in jul. Le dim. 17 janv. 2021 à 22:42, Slawomir Jaranowski a écrit : > Hi, > > For developers logging

Re: Loging api in JSR-330 component

2021-01-18 Thread Romain Manni-Bucau
Generally you want to propagate the mojo logger to have consistent logs but worse case we should promote mojo logging api as injectable at injection points if needed, avoids all the mess you can get in mojo with loggers to respect that rule of dumb IMHO. Le dim. 17 janv. 2021 à 22:48, Slawomir Jar