Re: MNG-6843 Parallel build fails due to missing JAR artifacts in compilePath

2021-01-16 Thread Dan Tran
we are facing the same issue at work (300+ modules), classpath empty randomly empty Love to see some resolution, will help to test it Thanks -D On Fri, Jan 15, 2021 at 1:51 PM Falko Modler wrote: > Hi everyone, > > I'd like to raise awareness for the MavenProject concurrency problem > that is

Re: releasing maven-artifact-plugin

2021-01-16 Thread Elliotte Rusty Harold
On Sat, Jan 16, 2021 at 8:31 AM Hervé BOUTEMY wrote: > > I see this objection more and more lately. > I don't really understand it, I consider it vaguely theoretical, and don't see > any concrete issue. > This is very much a concrete issue. I/O is unreliable. Sometimes it fails. When it does an I

Re: releasing maven-artifact-plugin

2021-01-16 Thread Slawomir Jaranowski
I don't remember the discussion. What do you think about JSR-330 in plugin code? sob., 16 sty 2021 o 09:37 Hervé BOUTEMY napisał(a): > my strategy in this plugin was to use maven-shared-utils, of course when > no > API exists in JDK > If I did it wrong in some cases, don't hesitate to provide a

[Merge] PR #421: Artifact.getPath() and .setPath()

2021-01-16 Thread Markus KARG
I have 2 +1 for https://github.com/apache/maven/pull/421, so can somebody please merge this PR (I am not a committer)? Thanks! -Markus

Re: releasing maven-artifact-plugin

2021-01-16 Thread Hervé BOUTEMY
my strategy in this plugin was to use maven-shared-utils, of course when no API exists in JDK If I did it wrong in some cases, don't hesitate to provide a PR And if there is a newer version of JDK that provides APIs to replace maven- shared-utils, we should document it in maven-shared-utils, and t

Re: releasing maven-artifact-plugin

2021-01-16 Thread Hervé BOUTEMY
PR welcome: yes, that would be nice Le vendredi 15 janvier 2021, 12:54:36 CET Elliotte Rusty Harold a écrit : > There are some good integration tests. Unit tests would help round this out. > > Most classes and method appear public by default. It's not obvious > they need to be. I think almost all

Re: releasing maven-artifact-plugin

2021-01-16 Thread Hervé BOUTEMY
I see this objection more and more lately. I don't really understand it, I consider it vaguely theoretical, and don't see any concrete issue. but I see a concrete issue on using OutputStreamWriter API instead of PrintWriter: I don't have "println(...)" perhaps something should be reported to th

Re: releasing maven-artifact-plugin

2021-01-16 Thread Hervé BOUTEMY
PR welcome for deprecation removal on JDK 8, I'm -1 because I know that it's a one char update in a pom file, but I don't see any benefit, I only see drawback: it can be used in less cases. And concretely, on Reproducible Central [1], if I upgrade JDK prerequisite to JDK 8, I have 16 releases th

Re: releasing maven-artifact-plugin

2021-01-16 Thread Hervé BOUTEMY
thank you Matthieu on splitting buildinfo generation and check, everybody starts with this logic when thinking, even me. Then during implementation, I discovered that in reality we don't check against a downloaded reference buildinfo file, but we check against a reference buildinfo that we buil