[GitHub] [maven-site-plugin] michael-o commented on pull request #34: [DOXIA-616]

2021-01-04 Thread GitBox
michael-o commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-754273143 In my opinion they need to bemoved because we test the entire site generation, and not Doxia specific modules. @hboutemy WDYT? -

Re: maven 4.0.0 new XML stuff

2021-01-04 Thread Robert Scholte
answers are below. Robert On 4-1-2021 16:52:23, Matthieu Brouillard wrote: @Robert nothing is broken atm, the changes for consumer/build are currently behind your feature flag. Robert Scholte:  It is active by default, so it is actually not hidden. But as I feared previously, and as Romain po

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-04 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-754142358 Okay, I will update the PR once Doxia 1.10 is released. Do you guys have any opinion on the removal of markdown-specific integration tests (especially Doxia-spec

Re: maven 4.0.0 new XML stuff

2021-01-04 Thread Matthieu Brouillard
@Robert nothing is broken atm, the changes for consumer/build are currently behind your feature flag. But as I feared previously, and as Romain pointed it, by working at XML level (and not at POM level) the produced consumer pom does not reflect changes from extensions. I really thought that all t

Re: maven 4.0.0 new XML stuff

2021-01-04 Thread Romain Manni-Bucau
Hmm, I don't get a few things of this IT: 1. the formatting seems not expected even if valid (the comments are finishing with the first tag for example "--> { final Dependency dependency = new Dependency(); dependency.setGroupId("junit"); dependency.setArtifactI

Re: maven 4.0.0 new XML stuff

2021-01-04 Thread Robert Scholte
https://github.com/apache/maven-integration-testing/tree/master/core-it-suite/src/test/resources/mng-6957-buildconsumer is the most complete IT On 4-1-2021 12:59:51, Romain Manni-Bucau wrote: Le lun. 4 janv. 2021 à 12:36, Robert Scholte a écrit : > There's just one thing I want to say: > I'm ha

Re: maven 4.0.0 new XML stuff

2021-01-04 Thread Romain Manni-Bucau
Le lun. 4 janv. 2021 à 12:36, Robert Scholte a écrit : > There's just one thing I want to say: > I'm having trouble with the term "broken". > Well, literally meant broken as decorelated from the user intent and extension model. Anyway, didn't intend to blame but more identify the blockers for a

Re: maven 4.0.0 new XML stuff

2021-01-04 Thread Robert Scholte
There's just one thing I want to say: I'm having trouble with the term "broken". If a Maven project could be built with M3.6.3, it can still be built with M4. If not, it is either regression (MNG-6957, MNG-7063) which must be fixed, or it requires changes to a plugin for understandable reasons (ma