[GitHub] [maven-site] philsttr edited a comment on pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-29 Thread GitBox
philsttr edited a comment on pull request #223: URL: https://github.com/apache/maven-site/pull/223#issuecomment-752319875 @slachiewicz , since [all the other guides](https://github.com/apache/maven-site/tree/master/content/apt/guides) are in apt, I'd rather keep this one in apt for consist

[GitHub] [maven-site] philsttr commented on pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-29 Thread GitBox
philsttr commented on pull request #223: URL: https://github.com/apache/maven-site/pull/223#issuecomment-752319875 @slachiewicz , since all the other guides are in apt, I'd rather keep this one in apt for consistency. I'm focused on the content for now. If it is indeed important to conve

[GitHub] [maven-site] philsttr commented on a change in pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-29 Thread GitBox
philsttr commented on a change in pull request #223: URL: https://github.com/apache/maven-site/pull/223#discussion_r549927249 ## File path: content/apt/guides/mini/guide-large-scale-centralized-deployments.apt ## @@ -0,0 +1,230 @@ + -- + Guide to Large Scale Centralized Dep

[GitHub] [maven-site] philsttr commented on a change in pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-29 Thread GitBox
philsttr commented on a change in pull request #223: URL: https://github.com/apache/maven-site/pull/223#discussion_r549926099 ## File path: content/apt/guides/mini/guide-large-scale-centralized-deployments.apt ## @@ -0,0 +1,230 @@ + -- + Guide to Large Scale Centralized Dep

[GitHub] [maven-site] philsttr commented on a change in pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-29 Thread GitBox
philsttr commented on a change in pull request #223: URL: https://github.com/apache/maven-site/pull/223#discussion_r549926035 ## File path: content/apt/guides/mini/guide-large-scale-centralized-deployments.apt ## @@ -0,0 +1,230 @@ + -- + Guide to Large Scale Centralized Dep

[VOTE] Release Apache Maven maven-shared-resources 3

2020-12-29 Thread Sylwester Lachiewicz
Hi, We solved 3 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12331412&styleName=Text&projectId=12317922 Staging repo: https://repository.apache.org/content/repositories/maven-1619/ https://repository.apache.org/content/repositories/maven-1619/org/apache/maven/shared/mav

[GitHub] [maven-artifact-transfer] slachiewicz commented on a change in pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1

2020-12-29 Thread GitBox
slachiewicz commented on a change in pull request #20: URL: https://github.com/apache/maven-artifact-transfer/pull/20#discussion_r549838430 ## File path: pom.xml ## @@ -165,12 +165,12 @@ org.apache.maven maven-core - 3.0 + 3.1.1 Review comment:

[GitHub] [maven-artifact-transfer] michael-o commented on a change in pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1

2020-12-29 Thread GitBox
michael-o commented on a change in pull request #20: URL: https://github.com/apache/maven-artifact-transfer/pull/20#discussion_r549743091 ## File path: pom.xml ## @@ -165,12 +165,12 @@ org.apache.maven maven-core - 3.0 + 3.1.1 Review comment:

Re: maven-shared-resources 3

2020-12-29 Thread Robert Scholte
Great, in that case I'll leave it up to you. Robert On 29-12-2020 14:29:43, Sylwester Lachiewicz wrote: Yes Robert - I've prepared this project for release I was planning to call for a vote today. Sywlester wt., 29 gru 2020 o 14:18 Robert Scholte napisał(a): > > I'd like to release maven-shared

Re: maven-shared-resources 3

2020-12-29 Thread Sylwester Lachiewicz
Yes Robert - I've prepared this project for release I was planning to call for a vote today. Sywlester wt., 29 gru 2020 o 14:18 Robert Scholte napisał(a): > > I'd like to release maven-shared-resources 3 soon. > Most important reason is that the most recent maven-checkstyle-plugin can't > handl

[GitHub] [maven-artifact-transfer] slachiewicz commented on pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1

2020-12-29 Thread GitBox
slachiewicz commented on pull request #20: URL: https://github.com/apache/maven-artifact-transfer/pull/20#issuecomment-752074009 With these changes, it should be easier to move forward with maven-dependency-tree and other plugins - to not fight with old dependencies.

[GitHub] [maven-artifact-transfer] slachiewicz commented on pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1

2020-12-29 Thread GitBox
slachiewicz commented on pull request #20: URL: https://github.com/apache/maven-artifact-transfer/pull/20#issuecomment-752072730 there is nothing special - lots of removal of old maven 3.0 stuff + replacement of reflections to just us normal direct call to exposed API. No need to spent to

maven-shared-resources 3

2020-12-29 Thread Robert Scholte
I'd like to release maven-shared-resources 3 soon. Most important reason is that the most recent maven-checkstyle-plugin can't handle the old maven_checks.xml from maven-shared-resources 2 (2015). Jira[1] looks clean, but if there are things to add, now is the time[2]. [1] https://issues.apache.

[GitHub] [maven-site] michael-o commented on a change in pull request #223: [MNGSITE-438] Add guide for Large Scale Centralized Deployments

2020-12-29 Thread GitBox
michael-o commented on a change in pull request #223: URL: https://github.com/apache/maven-site/pull/223#discussion_r549636990 ## File path: content/apt/guides/mini/guide-large-scale-centralized-deployments.apt ## @@ -0,0 +1,230 @@ + -- + Guide to Large Scale Centralized De