[GitHub] [maven-archiver] elharo merged pull request #14: Use try with resources

2020-11-16 Thread GitBox
elharo merged pull request #14: URL: https://github.com/apache/maven-archiver/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [maven-archiver] elharo opened a new pull request #14: Ue try with resources

2020-11-16 Thread GitBox
elharo opened a new pull request #14: URL: https://github.com/apache/maven-archiver/pull/14 @michael-o This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: Javac server?

2020-11-16 Thread Enrico Olivelli
Robert, Il Lun 16 Nov 2020, 20:13 Robert Scholte ha scritto: > It is still on my wishlist to make use of javac via the ToolProvider, just > like now is done with jlink.[1] > This approach would also probably fix the issue with JDK16 and -Xdoclink that I pointed out recently Enrico But this on

Re: Javac server?

2020-11-16 Thread Robert Scholte
It is still on my wishlist to make use of javac via the ToolProvider, just like now is done with jlink.[1] But this one might be interesting too. Robert [1] https://github.com/apache/maven-jlink-plugin/pull/16 On 15-11-2020 22:24:21, Enrico Olivelli wrote: Hey folks, I had never heard about th

[GitHub] [maven-archiver] rfscholte commented on pull request #13: test was asserting more than Java promises

2020-11-16 Thread GitBox
rfscholte commented on pull request #13: URL: https://github.com/apache/maven-archiver/pull/13#issuecomment-728265093 ok, just wanted to make sure change is done for the right reason. This is an automated message from the Apa

[GitHub] [maven-archiver] elharo commented on pull request #13: test was asserting more than Java promises

2020-11-16 Thread GitBox
elharo commented on pull request #13: URL: https://github.com/apache/maven-archiver/pull/13#issuecomment-728255605 I don't think it is. That was an incorrect diagnosis of the test failure. The modification data equality failures were not simply the result of truncating milliseconds; and if

[GitHub] [maven-archiver] rfscholte commented on pull request #13: test was asserting more than Java promises

2020-11-16 Thread GitBox
rfscholte commented on pull request #13: URL: https://github.com/apache/maven-archiver/pull/13#issuecomment-728251174 Wait a minute, isn't this fixed with https://github.com/codehaus-plexus/plexus-archiver/commit/e55f320f190bc5fe2b1029c4fd8bb3e294a299bc ?

[GitHub] [maven-site] elharo merged pull request #214: document all allowed elements inside profiles

2020-11-16 Thread GitBox
elharo merged pull request #214: URL: https://github.com/apache/maven-site/pull/214 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-site] ninj commented on a change in pull request #214: document all allowed elements inside profiles

2020-11-16 Thread GitBox
ninj commented on a change in pull request #214: URL: https://github.com/apache/maven-site/pull/214#discussion_r524477128 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -346,7 +346,8 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2 it

[GitHub] [maven-site] ninj commented on a change in pull request #214: document all allowed elements inside profiles

2020-11-16 Thread GitBox
ninj commented on a change in pull request #214: URL: https://github.com/apache/maven-site/pull/214#discussion_r524476089 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -346,7 +346,8 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2 it

[GitHub] [maven-archiver] elharo merged pull request #13: test was asserting more than Java promises

2020-11-16 Thread GitBox
elharo merged pull request #13: URL: https://github.com/apache/maven-archiver/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [DISCUSS] Next release should a pre Maven 4.0.0

2020-11-16 Thread Michael Osipov
Am 2020-11-13 um 18:31 schrieb Karl Heinz Marbaise: Hi, On 12.11.20 20:00, Robert Scholte wrote: Hi, It is already several years ago where we started discussing about Maven Next Generations. Clearly we needed to work on the pom, because over time we're facing more and more limitations. For (

[GitHub] [maven-archiver] elharo opened a new pull request #13: test was asserting more than Java promises

2020-11-16 Thread GitBox
elharo opened a new pull request #13: URL: https://github.com/apache/maven-archiver/pull/13 Consequently failing flakily. Last modified time is platform dependent and not a simpler property of an object @michael-o ---

[GitHub] [maven-archiver] elharo merged pull request #12: unignore and fix test whose failure was incorrectly attributed to a JDK bug

2020-11-16 Thread GitBox
elharo merged pull request #12: URL: https://github.com/apache/maven-archiver/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [maven-archiver] elharo commented on a change in pull request #12: unignore and fix test whose failure was incorrectly attributed to a JDK bug

2020-11-16 Thread GitBox
elharo commented on a change in pull request #12: URL: https://github.com/apache/maven-archiver/pull/12#discussion_r524283416 ## File path: src/test/java/org/apache/maven/archiver/MavenArchiverTest.java ## @@ -276,13 +273,8 @@ public void testRecreation() }

[GitHub] [maven-archiver] elharo opened a new pull request #12: unignore and fix test whose failure was incorrectly attributed to a JDK bug

2020-11-16 Thread GitBox
elharo opened a new pull request #12: URL: https://github.com/apache/maven-archiver/pull/12 @michael-o This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [maven-archiver] elharo merged pull request #11: update JUnit to 4.13.1

2020-11-16 Thread GitBox
elharo merged pull request #11: URL: https://github.com/apache/maven-archiver/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [maven-archiver] elharo opened a new pull request #11: update JUnit to 4.13.1

2020-11-16 Thread GitBox
elharo opened a new pull request #11: URL: https://github.com/apache/maven-archiver/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [maven-archiver] elharo merged pull request #9: ignore .checkstyle

2020-11-16 Thread GitBox
elharo merged pull request #9: URL: https://github.com/apache/maven-archiver/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-site] elharo commented on a change in pull request #214: document all allowed elements inside profiles

2020-11-16 Thread GitBox
elharo commented on a change in pull request #214: URL: https://github.com/apache/maven-site/pull/214#discussion_r524245936 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -346,7 +346,8 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2