Re: Forcing "provided" for some dependencies

2020-09-01 Thread Xeno Amess
Hi. Sounds like what you need is exclusion? org.apache.commons commons-vfs2 ${commons-vfs2.version} org.slf4j slf4j-log4j12 log4j log4j org.slf4j slf4j-jdk14

Re: Forcing "provided" for some dependencies

2020-09-01 Thread Romain Manni-Bucau
Hi, I think it is risky because some dependencies are really provided so you should write an extension which does it for specific artifacts but then question will be: what about parent provided deps? Therefore my proposal would be to ask upstream projects to fix their pom or add a pom in their ow

Forcing "provided" for some dependencies

2020-09-01 Thread jedrzej.dudkiewicz
Hello, I have Maven project using spring-boot that is composed of base project and components. This is mainly runtime dependency: Base (B) provides some services, and components (C1, C2, C3.) are "installed" by dropping them into specific directory. This works fine, but as I expected I have som

[GitHub] [maven-archiver] pzygielo commented on pull request #10: [MSHARED-955] make parseOutputTimestamp static

2020-09-01 Thread GitBox
pzygielo commented on pull request #10: URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-685128506 > That's not something I'm worried about happening in practice. I know. But I do. So I've updated my example for the case, where this dependency is overriden i

[GitHub] [maven-archiver] elharo commented on pull request #10: [MSHARED-955] make parseOutputTimestamp static

2020-09-01 Thread GitBox
elharo commented on pull request #10: URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-685063812 Thanks. That's not something I'm worried about happening in practice. Is there a likely diamond dependency problem where the incompatible version gets selected? ---

[GitHub] [maven-archiver] mabrarov edited a comment on pull request #10: [MSHARED-955] make parseOutputTimestamp static

2020-09-01 Thread GitBox
mabrarov edited a comment on pull request #10: URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-685043977 To be honest implementation of `parseOutputTimestamp` looks wrong because it doesn't parse optional time zone. This causes issues with `project.build.outputTimestamp`

[GitHub] [maven-archiver] mabrarov removed a comment on pull request #10: [MSHARED-955] make parseOutputTimestamp static

2020-09-01 Thread GitBox
mabrarov removed a comment on pull request #10: URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-685043977 To be honest implementation of `parseOutputTimestamp` looks wrong because it doesn't parse optional time zone. This causes issues with `project.build.outputTimestamp

[GitHub] [maven-archiver] mabrarov commented on pull request #10: [MSHARED-955] make parseOutputTimestamp static

2020-09-01 Thread GitBox
mabrarov commented on pull request #10: URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-685043977 To be honest implementation of `parseOutputTimestamp` looks wrong because it doesn't parse optional time zone. This causes issues with `project.build.outputTimestamp` maven

[GitHub] [maven-archiver] pzygielo commented on pull request #10: [MSHARED-955] make parseOutputTimestamp static

2020-09-01 Thread GitBox
pzygielo commented on pull request #10: URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-685044143 > @pzygielo can you provide more details on what code would be required to trigger this? See https://github.com/pzrep/MSHARED-955 ---

[GitHub] [maven-archiver] elharo commented on pull request #10: [MSHARED-955] make parseOutputTimestamp static

2020-09-01 Thread GitBox
elharo commented on pull request #10: URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-685019474 @pzygielo can you provide more details on what code would be required to trigger this? This is an automated

[GitHub] [maven-archiver] pzygielo commented on pull request #10: [MSHARED-955] make parseOutputTimestamp static

2020-09-01 Thread GitBox
pzygielo commented on pull request #10: URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-684998151 > I think the issue only appears if a subclass overrides this method. If so changed class appears in place of old one - without recompiling client - then `Incompatible

[GitHub] [maven-archiver] elharo commented on pull request #10: [MSHARED-955] make parseOutputTimestamp static

2020-09-01 Thread GitBox
elharo commented on pull request #10: URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-684984178 I think the issue only appears if a subclass overrides this method. This is an automated message from the Apac

[GitHub] [maven-archiver] pzygielo commented on pull request #10: [MSHARED-955] make parseOutputTimestamp static

2020-09-01 Thread GitBox
pzygielo commented on pull request #10: URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-684976887 > Isn't it sufficient to notify users of this library about this incompatible class change Maybe it is sufficient, but one has to be aware of that to prepare notific

[GitHub] [maven-archiver] mabrarov commented on pull request #10: [MSHARED-955] make parseOutputTimestamp static

2020-09-01 Thread GitBox
mabrarov commented on pull request #10: URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-684968771 @pzygielo, sorry for a stupid question, but does it make sense if this change will be released with new version of Maven Archiver? Isn't it sufficient to notify users of thi

[GitHub] [maven-archiver] pzygielo commented on pull request #10: [MSHARED-955] make parseOutputTimestamp static

2020-09-01 Thread GitBox
pzygielo commented on pull request #10: URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-684965881 It is `IncompatibleClassChange` (https://github.com/apache/maven-ear-plugin/pull/10#discussion_r481249976).

[GitHub] [maven-archiver] elharo opened a new pull request #10: [MSHARED-955] make parseOutputTimestamp static

2020-09-01 Thread GitBox
elharo opened a new pull request #10: URL: https://github.com/apache/maven-archiver/pull/10 @hboutemy @mabrarov This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [maven-archiver] elharo opened a new pull request #9: ignore .checkstyle

2020-09-01 Thread GitBox
elharo opened a new pull request #9: URL: https://github.com/apache/maven-archiver/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [VOTE] Release Maven Project Info Reports Plugin version 3.1.1

2020-09-01 Thread Michael Osipov
Am 2020-08-30 um 21:12 schrieb Michael Osipov: Hi, We solved 4 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317821&version=12348345 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/projects/MPIR/issues Staging repo: https://reposi

MEAR-283 Maven EAR Plugin generates not reproducible builds when skinnyWars option is turned on (was: MEAR-280 and skinnyWar option)

2020-09-01 Thread abrarov
Hi, Could somebody take a look at https://issues.apache.org/jira/browse/MEAR-283 bug and review possible solution (https://github.com/apache/maven-ear-plugin/pull/10)? I appreciate if we could fix this issue because Maven EAR Plugin is important part of enterprise solutions and they really benefi