[GitHub] [maven-site] olamy merged pull request #194: [MNGSITE-426] update Jenkins URL

2020-08-16 Thread GitBox
olamy merged pull request #194: URL: https://github.com/apache/maven-site/pull/194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [maven-site] olamy commented on pull request #194: [MNGSITE-426] update Jenkins URL

2020-08-16 Thread GitBox
olamy commented on pull request #194: URL: https://github.com/apache/maven-site/pull/194#issuecomment-674602039 @elharo we are adults NO NEED OF PR for such change This is an automated message from the Apache Git Service. To

[GitHub] [maven-site] elharo opened a new pull request #194: [MNGSITE-426] update Jenkins URL

2020-08-16 Thread GitBox
elharo opened a new pull request #194: URL: https://github.com/apache/maven-site/pull/194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: Assumption fail treated as unexcepted exception?!

2020-08-16 Thread Piotr Żygieło
I see TestCopyMojo runs with JUnit38ClassRunner. Is it Assumptions[Assume since 4.4, AssumptionViolatedException since 4.12]-proof? Piotrek - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mai

AW: Assumption fail treated as unexcepted exception?!

2020-08-16 Thread Markus KARG
Please see my answer to Martin Gainty, it proofs there is no NPE but AssumptionViolatedException. It is a wrong assumption that all thrown exceptions lead to test fail. It is JUnit's normal behavior that Assume.assumeTrue(false) will throw AssumptionViolatedException, so that one explicitly nee

AW: Assumption fail treated as unexcepted exception?!

2020-08-16 Thread Markus KARG
The debug output is quite huge, so I won't put it here. What in particular shall I lookup inside of that? The environment is: Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T21:00:29+02:00) Maven home: C:\Program Files\apache-maven-3.6.1 Java version: 1.8.0_212, vendor: Az

Re: Assumption fail treated as unexcepted exception?!

2020-08-16 Thread John Patrick
If the code working out the assumption fails and causes a throwable, either Runtime or Checked, I would expect the test to fail. If you have a line something like below, and that causes a test error, then that feels wrong as it's a valid assumption. Assumptions.assumeFalse("ABC".equals("ABC"), "mes

Re: Assumption fail treated as unexcepted exception?!

2020-08-16 Thread Martin Gainty
MG>below From: Markus KARG Sent: Sunday, August 16, 2020 7:40 AM To: dev@maven.apache.org Subject: Assumption fail treated as unexcepted exception?! Guys, I'm stuck with working on a new feature due to this, so I hope you can help me quickly: JUnit knows a

AW: Assumption fail treated as unexcepted exception?!

2020-08-16 Thread Markus KARG
Happens with surefire 2.22.0 (but also with 3.0.0-M5, just tried it). Just added the assumption, did not otherwise touch any config properties, but maybe maven dependency plugin's existing build does that (haven't read the complete source). Any clue which property to search for which could produ

Assumption fail treated as unexcepted exception?!

2020-08-16 Thread Falko Modler
Which surefire plugin version? Have you set any config properties? Cheers, Falko - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

Assumption fail treated as unexcepted exception?!

2020-08-16 Thread Markus KARG
Guys, I'm stuck with working on a new feature due to this, so I hope you can help me quickly: JUnit knows assumptions, assertions and exceptions. Failing assertions will FAIL tests (hence will fail maven builds). Failing assumptions will SKIP tests (hence will pass maven builds). Exceptions

Re: Why is old IO API used in maven resolver?

2020-08-16 Thread Michael Osipov
Am 2020-08-16 um 06:40 schrieb STEFAN REICH: Hi there! I am working on a very large code base, and build performance issues made me look at the maven-resolver source code. In terms of File usages, there are a lot of InputStreams being copied around using ByteBuffer, instead of using FileChann

Re: Why is old IO API used in maven resolver?

2020-08-16 Thread Xeno Amess
Hi. I wanna know how much it improve. could you please also run a corresponding jmh bencark for the old codes? Olivier Lamy 于 2020年8月16日周日 下午4:36写道: > On Sun, 16 Aug 2020 at 16:07, STEFAN REICH wrote: > > > Hi there! > > > > I am working on a very large code base, and build performance issues m

Re: Why is old IO API used in maven resolver?

2020-08-16 Thread Olivier Lamy
On Sun, 16 Aug 2020 at 16:07, STEFAN REICH wrote: > Hi there! > > I am working on a very large code base, and build performance issues made > me look at the maven-resolver source code. In terms of File usages, there > are a lot of InputStreams being copied around using ByteBuffer, instead of > us

Why is old IO API used in maven resolver?

2020-08-16 Thread STEFAN REICH
Hi there! I am working on a very large code base, and build performance issues made me look at the maven-resolver source code. In terms of File usages, there are a lot of InputStreams being copied around using ByteBuffer, instead of using FileChannel.transferTo. Affected classes are DefaultFile