Re: Short guide "Working with Github pull requests"

On Tue, 14 Jul 2020 at 16:37, Maarten Mulders wrote: > Good part is, even though I followed the docs I couldn't get it to work > for even one repo (maven-site). It still has the "Squash & merge" button. > > The guide I was proposing was for working with pull requests submitted > by contributors,

Re: Short guide "Working with Github pull requests"

Good part is, even though I followed the docs I couldn't get it to work for even one repo (maven-site). It still has the "Squash & merge" button. The guide I was proposing was for working with pull requests submitted by contributors, not for creating them. So I wasn't planning to add any words on

Re: [maven-site] branch master updated: Enable "Merge" button on Github

please no. I'm happy to use it for my own pr On Tue, 14 Jul 2020 at 16:16, wrote: > This is an automated email from the ASF dual-hosted git repository. > > mthmulders pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/maven-site.git > > > The following commit(s)

Re: Short guide "Working with Github pull requests"

Well personally I'm happy to use it for myself... so please don;t remove it. One of the most important point of the guide could be ***DO NOT CREATE PULL REQUEST FOR RIDICULOUS COMMIT WHICH DO NOT NEED REVIEW*** it's very noisy and useless notifications (especially because we get from both gitbox a

Re: Short guide "Working with Github pull requests"

Good point. I'll start by disabling the "Squash & merge" button using asf.yaml for the repositories I have cloned locally. Maarten On 13/07/2020 22:03, Elliotte Rusty Harold wrote: >>> So then the conclusion is, we can use Github for accepting & merging >>> pull requests, but shouldn't use "Squas

[VOTE] Release Apache Maven Archetype version 3.2.0

Hi, We solved 6 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317122&version=12346641&styleName=Text Staging repo: https://repository.apache.org/content/repositories/maven-1594/ https://repository.apache.org/content/repositories/maven-1594/org/apache/maven/archetype/m

Re: Where is the actual compiler for Maven

You can find them here:  https://codehaus-plexus.github.io/plexus-compiler/ thanks, Robert On 13-7-2020 22:25:23, Ian Lavallee wrote: Hi all, I am trying to make changes to the actual compiler for Maven so I can notify the user when they have runtime dependencies scoped as compile from maven-dep

Re: Where is the actual compiler for Maven

https://github.com/codehaus-plexus/plexus-compiler/tree/master/plexus-compilers is the current location I believe On Mon, 13 Jul 2020 at 21:25, Ian Lavallee wrote: > Hi all, > > I am trying to make changes to the actual compiler for Maven so I can > notify the user when they have runtime depende

Re: Automatic batch-mode activation in popular CI environments

Le lun. 13 juil. 2020 à 21:57, Michael Osipov a écrit : > Am 2020-07-13 um 08:10 schrieb Romain Manni-Bucau: > > Le dim. 12 juil. 2020 à 22:13, Michael Osipov a > > écrit : > > > >> Am 2020-07-12 um 21:35 schrieb Maarten Mulders: > >>> Although no formal standards, many cloud-based CI environmen

Where is the actual compiler for Maven

Hi all, I am trying to make changes to the actual compiler for Maven so I can notify the user when they have runtime dependencies scoped as compile from maven-dependency-analyzer. I've looked at the maven-compiler plugin but the only actual compilers I can find are in sonatype-plexus-compiler

Re: Short guide "Working with Github pull requests"

> > So then the conclusion is, we can use Github for accepting & merging > > pull requests, but shouldn't use "Squash & merge"? Buttons that shouldn't be used can be turned off by project owners in the repo settings. There's no need to bother devs with remembering which buttons should and should n

Re: Automatic batch-mode activation in popular CI environments

Am 2020-07-13 um 08:10 schrieb Romain Manni-Bucau: Le dim. 12 juil. 2020 à 22:13, Michael Osipov a écrit : Am 2020-07-12 um 21:35 schrieb Maarten Mulders: Although no formal standards, many cloud-based CI environments agreed upon setting CI=true, and I think also Jenkins does that. It might b

Re: Short guide "Working with Github pull requests"

Il Lun 13 Lug 2020, 21:03 Maarten Mulders ha scritto: > So, just to make sure: the sync is two-way? Yes What happens on Gitbox is > synced to Github and vice versa? I thought it was only from Gitbox to > Github, but never the other way around... > No. We should ask infra to know how this magi

Re: Short guide "Working with Github pull requests"

So, just to make sure: the sync is two-way? What happens on Gitbox is synced to Github and vice versa? I thought it was only from Gitbox to Github, but never the other way around... I do agree that Githubs UI is a bit more sophisticated for dealing with merge requests. I vaguely recall an earlier

Re: Short guide "Working with Github pull requests"

Much work happens directly on Github and syncs the other direction to Gitbox. That workflow is likely more familiar to most developers these days, and the Github UI is significantly advanced beyond Gitbox. On Mon, Jul 13, 2020 at 2:20 PM Maarten Mulders wrote: > > Hi all, > > The other day I was

Short guide "Working with Github pull requests"

Hi all, The other day I was working on a pull request offered through Github. I couldn't find instructions on how to accept and incorporate it. Based on my own experiences with submitting patches to Maven through Github I came up with a short how-to. I have written it down in a short guide "Worki

Re: second MNG-5760

Since this message, I have seen one review (and approval). Thanks for that! If nothing more comes in, I'll assume approval and merge this Wednesday morning (Europe/Amsterdam timezone). Thanks, Maarten On July 1st, 2020 at 09:17, Maarten Mulders wrote: > From our own testing as well as through JI

[ANN] Apache Maven WAR Plugin 3.3.1 Released

The Maven team is pleased to announce the release of the Apache Maven WAR Plugin, version 3.3.1 This plugin builds a Web Application Archive (WAR) file from the project output and its dependencies. https://maven.apache.org/plugins/maven-war-plugin/ You should specify the version in your projec

[RESULT] [VOTE] Release Apache Maven WAR Plugin version 3.3.1

Hi, The vote has passed with the following result: +1 : Enrico Olivelli, Romain Manni-Bucau, Karl Heinz Marbaise, Olivier Lamy, Sylwester Lachiewicz, Hervé Boutemy PMC quorum reached I will promote the artifacts to the central repo. --

[GitHub] [maven-site] elharo merged pull request #179: small grammar improvements; add periods and fix run-on sentences

elharo merged pull request #179: URL: https://github.com/apache/maven-site/pull/179 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-site] elharo opened a new pull request #179: small grammar improvements; add periods and fix run-on sentences

elharo opened a new pull request #179: URL: https://github.com/apache/maven-site/pull/179 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-site] elharo merged pull request #178: [MNGSITE-408] Fix alignment of events logo

elharo merged pull request #178: URL: https://github.com/apache/maven-site/pull/178 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: Welcome the new Maven committers: Maarten Mulders en Martin Kanters

Also from my side, thanks a lot. I'm looking forward to help make Maven even better than it is today :-). Maarten On July 11th, 2020 at 22:46, Martin Kanters wrote: > Thanks for the warm welcome! Happy to be part of the team! > > > Op za 11 jul. 2020 om 10:18 schreef Arnaud Héritier : > >> Wel

[GitHub] [maven-site] dpd73 opened a new pull request #178: [MNGSITE-408] Fix alignment of events logo

dpd73 opened a new pull request #178: URL: https://github.com/apache/maven-site/pull/178 Submitted by: David Pead o change events to float left This is an automated message from the Apache Git Service. To respond to t

Re: [VOTE] Release Apache Maven WAR Plugin version 3.3.1

+1 Sylwester pon., 13 lip 2020, 02:35 użytkownik Olivier Lamy napisał: > +1 > > On Fri, 10 Jul 2020 at 20:39, wrote: > > > Hi, > > > > We solved 4 issues: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318121&version=12348374&styleName=Text > > > > Staging repo: >