Re: Automatic batch-mode activation in popular CI environments

2020-07-12 Thread Romain Manni-Bucau
Le dim. 12 juil. 2020 à 22:13, Michael Osipov a écrit : > Am 2020-07-12 um 21:35 schrieb Maarten Mulders: > > Although no formal standards, many cloud-based CI environments agreed > > upon setting CI=true, and I think also Jenkins does that. It might be a > > relatively simple way to detect most

Re: custom default lifecycle per project

2020-07-12 Thread Romain Manni-Bucau
Le dim. 12 juil. 2020 à 23:04, Hervé BOUTEMY a écrit : > Le dimanche 12 juillet 2020, 18:10:59 CEST Romain Manni-Bucau a écrit : > > Side topic - still thinking out loud - which is also covered by custom > > lifecycles: aliases. A common need is to alias a complex command ("mvn > > docker" execut

Re: custom default lifecycle per project

2020-07-12 Thread Romain Manni-Bucau
Le dim. 12 juil. 2020 à 23:01, Hervé BOUTEMY a écrit : > Le dimanche 12 juillet 2020, 11:58:08 CEST Romain Manni-Bucau a écrit : > > Le dim. 12 juil. 2020 à 11:26, Hervé BOUTEMY a > > > > écrit : > > > Le dimanche 12 juillet 2020, 10:37:36 CEST Romain Manni-Bucau a écrit : > > > > Le sam. 11 jui

Re: [VOTE] Release Apache Maven WAR Plugin version 3.3.1

2020-07-12 Thread Olivier Lamy
+1 On Fri, 10 Jul 2020 at 20:39, wrote: > Hi, > > We solved 4 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318121&version=12348374&styleName=Text > > Staging repo: > https://repository.apache.org/content/repositories/maven-1593/ > > https://repository.apache.org

Re: [VOTE] Release Apache Maven WAR Plugin version 3.3.1

2020-07-12 Thread Karl Heinz Marbaise
Hi, +1 from me, Kind regards Karl Heinz Marbaise On 10.07.20 12:39, herve.bout...@free.fr wrote: Hi, We solved 4 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318121&version=12348374&styleName=Text Staging repo: https://repository.apache.org/content/repositories/m

Re: custom default lifecycle per project

2020-07-12 Thread Hervé BOUTEMY
Le dimanche 12 juillet 2020, 18:10:59 CEST Romain Manni-Bucau a écrit : > Side topic - still thinking out loud - which is also covered by custom > lifecycles: aliases. A common need is to alias a complex command ("mvn > docker" executing "mvn dependency:build-classpath git-commit:generate > docker:

Re: custom default lifecycle per project

2020-07-12 Thread Hervé BOUTEMY
Le dimanche 12 juillet 2020, 11:58:08 CEST Romain Manni-Bucau a écrit : > Le dim. 12 juil. 2020 à 11:26, Hervé BOUTEMY a > > écrit : > > Le dimanche 12 juillet 2020, 10:37:36 CEST Romain Manni-Bucau a écrit : > > > Le sam. 11 juil. 2020 à 23:01, Hervé BOUTEMY a > > > > > > écrit : > > > > Le sa

Re: [VOTE] Release Apache Maven WAR Plugin version 3.3.1

2020-07-12 Thread Hervé BOUTEMY
here is my +1 verified that the build is reproducible: reference build done with JDK 7 on an Unix I need more votes, please Regards, Hervé Le vendredi 10 juillet 2020, 12:39:45 CEST herve.bout...@free.fr a écrit : > Hi, > > We solved 4 issues: > https://issues.apache.org/jira/secure/ReleaseN

Re: Automatic batch-mode activation in popular CI environments

2020-07-12 Thread Michael Osipov
Am 2020-07-12 um 21:35 schrieb Maarten Mulders: Although no formal standards, many cloud-based CI environments agreed upon setting CI=true, and I think also Jenkins does that. It might be a relatively simple way to detect most CI environments. The next question is what Maven should do with that

Re: Automatic batch-mode activation in popular CI environments

2020-07-12 Thread Maarten Mulders
Although no formal standards, many cloud-based CI environments agreed upon setting CI=true, and I think also Jenkins does that. It might be a relatively simple way to detect most CI environments. The next question is what Maven should do with that information. I feel like informing the user is mor

Re: Automatic batch-mode activation in popular CI environments

2020-07-12 Thread Martin Kanters
Thanks for all the replies! I agree that checking on environment variables is not desirable (because of the many different CI environments and also because the envs are not necessarily unique to the CI environment only). Using some kind of mechanism Michael is proposing seems a lot more generic a

[GitHub] [maven-site] mthmulders edited a comment on pull request #177: Bug/mngsite 416 getting started gives build failure

2020-07-12 Thread GitBox
mthmulders edited a comment on pull request #177: URL: https://github.com/apache/maven-site/pull/177#issuecomment-657255635 Your pull request has been merged. Thanks again for your contribution! This is an automated message f

[GitHub] [maven-site] mthmulders commented on pull request #177: Bug/mngsite 416 getting started gives build failure

2020-07-12 Thread GitBox
mthmulders commented on pull request #177: URL: https://github.com/apache/maven-site/pull/177#issuecomment-657255635 Your pull request has been merged into master. Thanks again for your contribution! This is an automated mes

[GitHub] [maven-site] mthmulders closed pull request #177: Bug/mngsite 416 getting started gives build failure

2020-07-12 Thread GitBox
mthmulders closed pull request #177: URL: https://github.com/apache/maven-site/pull/177 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: Automatic batch-mode activation in popular CI environments

2020-07-12 Thread Romain Manni-Bucau
Hi, Did you already do the work to list what it implies? For instance I know interactive mode can be needed on these platforms (for debug purposes mainly), that travis requires more work for logs (size + timeout "ping" log to not have the job killed) etc... So wonder what is the overlap (if it is

Re: Automatic batch-mode activation in popular CI environments

2020-07-12 Thread Michael Osipov
Am 2020-07-12 um 17:42 schrieb Martin Kanters: Hi all, When setting up GitHub Actions for Maven (core) two weeks ago, I initially forgot to enable the -B/--batch-mode flag. While this gave no issues and was easy to fix, it could be avoided by detecting if Maven is executed on popular CI environm

Re: custom default lifecycle per project

2020-07-12 Thread Romain Manni-Bucau
Just to illustrate the proposal - likely to rework on config side to avoid to kind of expose maven IoC (as we were playing with application contexts 10 years ago ;)) here is a small repo: https://github.com/rmannibucau/custom-lifecycle-extension. A sample project ([1]) defines a custom packaging (

Re: custom default lifecycle per project

2020-07-12 Thread Romain Manni-Bucau
Side topic - still thinking out loud - which is also covered by custom lifecycles: aliases. A common need is to alias a complex command ("mvn docker" executing "mvn dependency:build-classpath git-commit:generate docker:bundle docker-java:cds" to give an idea), with default or merged lifecycles it i

Re: Automatic batch-mode activation in popular CI environments

2020-07-12 Thread Gary Gregory
Don't forget Travis-CI. Gary On Sun, Jul 12, 2020, 11:42 Martin Kanters wrote: > Hi all, > > When setting up GitHub Actions for Maven (core) two weeks ago, I initially > forgot to enable the -B/--batch-mode flag. > While this gave no issues and was easy to fix, it could be avoided by > detectin

Re: Automatic batch-mode activation in popular CI environments

2020-07-12 Thread Tibor Digana
It is better if you control the Maven and not when the Maven controls you 😁 Dňa ne 12. 7. 2020, 17:42 Martin Kanters napísal(a): > Hi all, > > When setting up GitHub Actions for Maven (core) two weeks ago, I initially > forgot to enable the -B/--batch-mode flag. > While this gave no issues and

Automatic batch-mode activation in popular CI environments

2020-07-12 Thread Martin Kanters
Hi all, When setting up GitHub Actions for Maven (core) two weeks ago, I initially forgot to enable the -B/--batch-mode flag. While this gave no issues and was easy to fix, it could be avoided by detecting if Maven is executed on popular CI environments and in that case automatically enabling batc

[GitHub] [maven-site] dpd73 commented on a change in pull request #177: Bug/mngsite 416 getting started gives build failure

2020-07-12 Thread GitBox
dpd73 commented on a change in pull request #177: URL: https://github.com/apache/maven-site/pull/177#discussion_r453312612 ## File path: content/apt/guides/getting-started/index.apt ## @@ -370,40 +378,47 @@ mvn install Upon executing this command you should see the following

[GitHub] [maven-site] mthmulders removed a comment on pull request #177: Bug/mngsite 416 getting started gives build failure

2020-07-12 Thread GitBox
mthmulders removed a comment on pull request #177: URL: https://github.com/apache/maven-site/pull/177#issuecomment-657210544 Thanks for updating this guide! Overall it looks good to me, I have left one small remark. This is

[GitHub] [maven-site] mthmulders commented on a change in pull request #177: Bug/mngsite 416 getting started gives build failure

2020-07-12 Thread GitBox
mthmulders commented on a change in pull request #177: URL: https://github.com/apache/maven-site/pull/177#discussion_r453305679 ## File path: content/apt/guides/getting-started/index.apt ## @@ -370,40 +378,47 @@ mvn install Upon executing this command you should see the follo

[GitHub] [maven-site] mthmulders commented on pull request #177: Bug/mngsite 416 getting started gives build failure

2020-07-12 Thread GitBox
mthmulders commented on pull request #177: URL: https://github.com/apache/maven-site/pull/177#issuecomment-657210544 Thanks for updating this guide! Overall it looks good to me, I have left one small remark. This is an autom

[GitHub] [maven-site] dpd73 opened a new pull request #177: Bug/mngsite 416 getting started gives build failure

2020-07-12 Thread GitBox
dpd73 opened a new pull request #177: URL: https://github.com/apache/maven-site/pull/177 https://issues.apache.org/jira/browse/MNGSITE-416 This is an automated message from the Apache Git Service. To respond to the message, p

Re: custom default lifecycle per project

2020-07-12 Thread Romain Manni-Bucau
Le dim. 12 juil. 2020 à 11:26, Hervé BOUTEMY a écrit : > Le dimanche 12 juillet 2020, 10:37:36 CEST Romain Manni-Bucau a écrit : > > Le sam. 11 juil. 2020 à 23:01, Hervé BOUTEMY a > > > > écrit : > > > Le samedi 11 juillet 2020, 12:55:37 CEST Romain Manni-Bucau a écrit : > > > > Le sam. 11 juil.

Re: custom default lifecycle per project

2020-07-12 Thread Hervé BOUTEMY
Le dimanche 12 juillet 2020, 10:37:36 CEST Romain Manni-Bucau a écrit : > Le sam. 11 juil. 2020 à 23:01, Hervé BOUTEMY a > > écrit : > > Le samedi 11 juillet 2020, 12:55:37 CEST Romain Manni-Bucau a écrit : > > > Le sam. 11 juil. 2020 à 12:09, Hervé BOUTEMY a > > > > > > écrit : > > > > are rea

Re: custom default lifecycle per project

2020-07-12 Thread Romain Manni-Bucau
Le sam. 11 juil. 2020 à 23:01, Hervé BOUTEMY a écrit : > Le samedi 11 juillet 2020, 12:55:37 CEST Romain Manni-Bucau a écrit : > > Le sam. 11 juil. 2020 à 12:09, Hervé BOUTEMY a > > > > écrit : > > > are really your plugin bindings so specific to your build that they > could > > > not be reused