[GitHub] [maven-doxia] hboutemy commented on a change in pull request #35: DOXIA-614: support source reference in doxia parser

hboutemy commented on a change in pull request #35: URL: https://github.com/apache/maven-doxia/pull/35#discussion_r447273790 ## File path: doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractXmlParser.java ## @@ -49,18 +32,33 @@ import org.apache.maven.doxia.sink.i

[GitHub] [maven-doxia] hboutemy commented on a change in pull request #35: DOXIA-614: support source reference in doxia parser

hboutemy commented on a change in pull request #35: URL: https://github.com/apache/maven-doxia/pull/35#discussion_r447273709 ## File path: doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractParser.java ## @@ -37,6 +29,13 @@ import org.apache.maven.doxia.sink.Sink;

[GitHub] [maven-doxia] elharo commented on a change in pull request #35: DOXIA-614: support source reference in doxia parser

elharo commented on a change in pull request #35: URL: https://github.com/apache/maven-doxia/pull/35#discussion_r447236450 ## File path: doxia-core/src/main/java/org/apache/maven/doxia/Doxia.java ## @@ -52,6 +52,22 @@ void parse( Reader source, String parserId, Sink sink )

[GitHub] [maven-doxia] abelsromero commented on pull request #5: [DOXIA-534] Migrate logging to Sl4j

abelsromero commented on pull request #5: URL: https://github.com/apache/maven-doxia/pull/5#issuecomment-651344760 > I'm not in favor of removing doxia-logging: deprecating and modifying it to use slf4j would be more compatible > I know there are not so much Doxia extensions in the wild:

[GitHub] [maven-doxia] abelsromero commented on a change in pull request #35: DOXIA-614: support source reference in doxia parser

abelsromero commented on a change in pull request #35: URL: https://github.com/apache/maven-doxia/pull/35#discussion_r447224575 ## File path: doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractParser.java ## @@ -179,15 +178,32 @@ protected File getBasedir() pu

[GitHub] [maven-doxia] abelsromero commented on a change in pull request #35: DOXIA-614: support source reference in doxia parser

abelsromero commented on a change in pull request #35: URL: https://github.com/apache/maven-doxia/pull/35#discussion_r447224915 ## File path: doxia-core/src/main/java/org/apache/maven/doxia/Doxia.java ## @@ -41,24 +41,35 @@ * Parses the given source model using a parser w

[GitHub] [maven-doxia] abelsromero commented on a change in pull request #35: DOXIA-614: support source reference in doxia parser

abelsromero commented on a change in pull request #35: URL: https://github.com/apache/maven-doxia/pull/35#discussion_r447219577 ## File path: doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractXmlParser.java ## @@ -100,7 +98,7 @@ private boolean validate = fal

[GitHub] [maven-doxia] abelsromero commented on a change in pull request #35: DOXIA-614: support source reference in doxia parser

abelsromero commented on a change in pull request #35: URL: https://github.com/apache/maven-doxia/pull/35#discussion_r447219577 ## File path: doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractXmlParser.java ## @@ -100,7 +98,7 @@ private boolean validate = fal

[GitHub] [maven-doxia] elharo commented on a change in pull request #35: DOXIA-614: support source reference in doxia parser

elharo commented on a change in pull request #35: URL: https://github.com/apache/maven-doxia/pull/35#discussion_r447151457 ## File path: doxia-core/src/main/java/org/apache/maven/doxia/Doxia.java ## @@ -41,24 +41,35 @@ * Parses the given source model using a parser with g

[GitHub] [maven-doxia] abelsromero commented on pull request #35: DOXIA-614: support source reference in doxia parser

abelsromero commented on pull request #35: URL: https://github.com/apache/maven-doxia/pull/35#issuecomment-651269972 Applied the suggestions tried to keep commit history clean. - Squashed test change in Test commit - Added new commit for Doxia's JavaDoc review ---

Announcing ApacheCon @Home 2020

Hi, Apache enthusiast! (You’re receiving this because you’re subscribed to one or more dev or user mailing lists for an Apache Software Foundation project.) The ApacheCon Planners and the Apache Software Foundation are pleased to announce that ApacheCon @Home will be held online, September 29