Re: DirectoryScanner, exclusions wins or loose over inclusions?

Ok, Will give a try to a first draft/pr this week. Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn

Re: DirectoryScanner, exclusions wins or loose over inclusions?

The stream wasn't intended as discussion, just to mention this piece of code must be touched anyway, it is far from dead. I think we can do both. Robert On 9-6-2020 20:48:02, Romain Manni-Bucau wrote: Well, have to admit I didn't expect the stream discussion there (not saying it is bad, just h

Re: [VOTE] Release Apache Maven EJB Plugin version 3.1.0

I need more votes, please Regards, Hervé Le dimanche 7 juin 2020, 18:26:43 CEST Hervé BOUTEMY a écrit : > Hi, > > We solved 7 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317421&ve > rsion=12343161&styleName=Text > > Staging repo: > https://repository.apache.org

Re: DirectoryScanner, exclusions wins or loose over inclusions?

Well, have to admit I didn't expect the stream discussion there (not saying it is bad, just highly unexpected). So think we have multiple topics: 1. Do we do a stream based *impl* with a flatmap enabling to bypass children - reusing ScanCondutor maybe? 2. Do we fix maven shared impl providing some

Re: DirectoryScanner, exclusions wins or loose over inclusions?

bq. Today I realized that plexus impl does not respect exclusions in the visit  but only in the result, it means if you exclude **/target/** and include  **/*.java, it will visit target to see if there is any java (cause ** means  java can be in target). I recall noticing that as well. I had the p

Re: DirectoryScanner, exclusions wins or loose over inclusions?

Strictly speaking it is slower but I don't think we would notice it in a build (same as Path is slower than File). Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github

Re: DirectoryScanner, exclusions wins or loose over inclusions?

Don't we configure those patterns mostly directly in the poms? Ditching our own DirectoryScanner would likely require a huge amount of existing projects to rewrite their config when they update some plugins. Don't think this is really worth it. Plus the Java7 directoryScanner is not really faste

Re: DirectoryScanner, exclusions wins or loose over inclusions?

Do you suggest to use java regex? Think it is very rare that mojo use that (even outside org.apache.maven.plugins) and each time it kind of hurts users so I hope we don't go that path. On the other side, never saw anyone complaining of ant regexes. Ant like syntax is way more friendly and natural I

Re: DirectoryScanner, exclusions wins or loose over inclusions?

On Tue, Jun 9, 2020 at 8:30 AM Romain Manni-Bucau wrote: > > Wildcard support which is more user friendly (who would like to use java > regex to configure that ;)). Familiarity is user friendly. Standard Java regex that developers already know and use beats a marginally simpler syntax they don't.

Re: DirectoryScanner, exclusions wins or loose over inclusions?

Wildcard support which is more user friendly (who would like to use java regex to configure that ;)). In other words you can redo the impl but you will less likely redo the associated configuration so the class is still needed since DirectoryStream does not bring any of that AFAIK. Romain Manni-Bu

Re: DirectoryScanner, exclusions wins or loose over inclusions?

Is there a strong reason anymore to have this class? It is heavily used so we're stuck with it for a while, but for new code DirectoryStream is in the JDK 7+ and is likely to be better supported, less buggy, and more familiar to new developers. If there's an actual bug or missing documentation in

[ANN] Apache Maven WAR Plugin 3.3.0 Released

The Maven team is pleased to announce the release of the Apache Maven WAR Plugin, version 3.3.0 This plugin builds a Web Application Archive (WAR) file from the project output and its dependencies. https://maven.apache.org/plugins/maven-war-plugin/ You should specify the version in your projec

DirectoryScanner, exclusions wins or loose over inclusions?

Hi everyone, As you know, DirectoryScanner is used a lot in plugins. Today I realized that plexus impl does not respect exclusions in the visit but only in the result, it means if you exclude **/target/** and include **/*.java, it will visit target to see if there is any java (cause ** means java