Re: Hooking custom plugin into deploy phase

2020-05-19 Thread Maarten Mulders
Hi Petr, If you want to specifically invoke your plugin, you would need mvn cz.fiisch.maven.plugin.deploy.askpass:askpass-deploy-plugin:1.0-SNAPSHOT:askpass (so not mvn deploy:askpass - this looks for the askpass goal in the maven-deploy-plugin which doesn't exist) That said, I would expect t

Re: Hooking custom plugin into deploy phase

2020-05-19 Thread Petr Fišer
Hi, Sure thing. :) I have set of private Maven repos which are readable (writeable) only to logged-in users. We need to use login:password credentials because it is a community version of Nexus and AFAIK it does not allow use of API keys. Accounts are centralized so this is not the only place

Re: Hooking custom plugin into deploy phase

2020-05-19 Thread Petr Fišer
Hi, This sound interesting. I gave it a try but it didn't work for me. It even seems that my plugin does not get picked up during "deploy" at all. I added maven-deploy-plugin to the build config like this: cz.fiisch.maven.plugin.deploy.askpass askpass-deploy-plugin 1.0-SN

Re: JDK 8 Minimum Requirement for Maven Resolver 2.0

2020-05-19 Thread Sylwester Lachiewicz
Yes, we can use Path from NIO now, but if we have methods that return File it will not work. - please check the last comments in MNG-6444. Looks like pressure to keep Resoler at Java 7 level is high - I'll not force that change. I hope after some time it will be more natural. Thx for votes and ar

Re: JDK 8 Minimum Requirement for Maven Resolver 2.0

2020-05-19 Thread Sylwester Lachiewicz
For now, I can think only about movie code to Java 8 syntax (but yes, we still have lots of code that can be upgraded to level 5 and 7...) then maybe small refactoring just to have cleaner code. I would be best if we can have Java 8 Resolver + Wagon released before Maven 3.7 - but also nothing wro

Re: JDK 8 Minimum Requirement for Maven Resolver 2.0

2020-05-19 Thread Elliotte Rusty Harold
On Tue, May 19, 2020 at 6:54 PM Sylwester Lachiewicz wrote: > > Hi, > I would prefer to keep in sync a minimal version of Java version for Maven > Core and Resolver so we can use all goodies from Java 8 like mentioned > streams, default methods. > Real cases - https://jira.apache.org/jira/browse/M

Re: JDK 8 Minimum Requirement for Maven Resolver 2.0

2020-05-19 Thread Sylwester Lachiewicz
Hi, I would prefer to keep in sync a minimal version of Java version for Maven Core and Resolver so we can use all goodies from Java 8 like mentioned streams, default methods. Real cases - https://jira.apache.org/jira/browse/MNG-6444 migrate code to use NIO - also in many places we still have prob

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
olamy commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427603657 ## File path: src/it/projects/new-configuration/pom.xml ## @@ -76,7 +76,7 @@ under the License. org.apache.maven.plugins

[GitHub] [maven-site-plugin] michael-o commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
michael-o commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427603026 ## File path: src/it/projects/new-configuration/pom.xml ## @@ -76,7 +76,7 @@ under the License. org.apache.maven.plug

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
olamy commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427601611 ## File path: src/it/projects/new-configuration/pom.xml ## @@ -76,7 +76,7 @@ under the License. org.apache.maven.plugins

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
olamy commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427595053 ## File path: pom.xml ## @@ -473,28 +474,28 @@ under the License. org.slf4j slf4j-api - 1.5.3 + 1.7.29 test

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
olamy commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427588408 ## File path: src/it/projects/new-configuration/pom.xml ## @@ -76,7 +76,7 @@ under the License. org.apache.maven.plugins

[GitHub] [maven-site-plugin] michael-o commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
michael-o commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427591833 ## File path: src/it/projects/new-configuration/pom.xml ## @@ -76,7 +76,7 @@ under the License. org.apache.maven.plug

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
olamy commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427591510 ## File path: pom.xml ## @@ -473,28 +474,28 @@ under the License. org.slf4j slf4j-api - 1.5.3 + 1.7.29 test

[GitHub] [maven-site-plugin] michael-o commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
michael-o commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427591526 ## File path: pom.xml ## @@ -196,11 +196,11 @@ under the License. 3.0 -7 +8 Review comment: Good, let's re-merge MSITE-

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
olamy commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427588408 ## File path: src/it/projects/new-configuration/pom.xml ## @@ -76,7 +76,7 @@ under the License. org.apache.maven.plugins

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
olamy commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427587877 ## File path: pom.xml ## @@ -196,11 +196,11 @@ under the License. 3.0 -7 +8 Review comment: it's ALREADY there https://issu

[GitHub] [maven-site-plugin] michael-o commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
michael-o commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427584057 ## File path: pom.xml ## @@ -211,6 +211,8 @@ under the License. 2.7 2.22.1 2020-03-06T20:49:49Z +1.8 Review comment: I

[GitHub] [maven-site-plugin] michael-o commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
michael-o commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427583663 ## File path: pom.xml ## @@ -196,11 +196,11 @@ under the License. 3.0 -7 +8 Review comment: @olamy I am the bureaucrati

Re: Hooking custom plugin into deploy phase

2020-05-19 Thread Karl Heinz Marbaise
Hi, On 19.05.20 14:24, Petr Fišer wrote: Hello, I am trying to create custom maven plugin. Problem is I need to hook it up into the "deploy" phase before the default maven-deploy-plugin gets executed. The plugin itself seems to be ok - I hooked it up to "package" phase to verify its working. But

Re: Hooking custom plugin into deploy phase

2020-05-19 Thread Maarten Mulders
Hi Petr, As far as I know, when two plugins are bound to the same phase, the order of execution is the same as the order in which you define them in pom.xml. So if you want your plugin to be executed before the maven-deploy-plugin, I guess you'll need to explicitly list the maven-deploy-plugi

Hooking custom plugin into deploy phase

2020-05-19 Thread Petr Fišer
Hello, I am trying to create custom maven plugin. Problem is I need to hook it up into the "deploy" phase before the default maven-deploy-plugin gets executed. The plugin itself seems to be ok - I hooked it up to "package" phase to verify its working. But when trying to get it into "deploy" pha

Re: Maven Invoker Plugin - streamLogsOnFailures

2020-05-19 Thread Slawomir Jaranowski
Hi, Thanks for last review, I hope that all remarks are resolved in PR. Now is one new - how new parameters should be named. I'm waiting for final decision. https://github.com/apache/maven-invoker-plugin/pull/20#pullrequestreview-403456129 sob., 25 kwi 2020 o 15:40 Slawomir Jaranowski napisał(

Release maven-jxr-plugin please?

2020-05-19 Thread Andreas Sewe
Hi, would it be possible to release the maven-jxr-plugin? The last release is from September 2018 and since then (15 months ago, in fact) it finally got "jxr-no-fork" goals, bringing it on par with maven-javadoc-plugin and maven-source-plugin. Best wishes, Andreas --

Re: maven-site-plugin java8

2020-05-19 Thread Karl Heinz Marbaise
Hi, On 19.05.20 07:45, Olivier Lamy wrote: Hi Any objections for this PR https://github.com/apache/maven-site-plugin/pull/21 ? I prefer to ask rather than seeing my commit reverted +1 from me. Kind regards Karl Heinz Marbaise --