Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

2020-05-04 Thread Enrico Olivelli
I would go with option 'release surefire 3.0.0' Enrico Il Mar 5 Mag 2020, 07:59 Romain Manni-Bucau ha scritto: > Hmm, this particular one is quite hard cause (from my window which is not > 100% of users indeed) I see more users willing 1.6 (actually I should > phrase it "upgrade to last junit5

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

2020-05-04 Thread Romain Manni-Bucau
Hmm, this particular one is quite hard cause (from my window which is not 100% of users indeed) I see more users willing 1.6 (actually I should phrase it "upgrade to last junit5 when upgrading surefire") than other cases. Concretely, older versions will not upgrade surefire generally. I think we ar

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

2020-05-04 Thread Stephane Nicoll
OK. With that in mind, I think the surefire plugin shouldn't require a newer version of JUnit in a maintenance release that way. I understand it's fixed and can lead to problem anyway but there will be less problems if you rely on an older version and backward compatiblity if a newer version is aro

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

2020-05-04 Thread Romain Manni-Bucau
Yes but with transitive game it is not well positionned in the classpath (once again not saying it is "right", just the way it was done originally) and surefire provider dependencies win so it must be redefined to be used in 2.x. Romain Manni-Bucau @rmannibucau |

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

2020-05-04 Thread Christian Stein
On Mon, May 4, 2020 at 6:45 PM Romain Manni-Bucau wrote: > Le lun. 4 mai 2020 à 18:30, Stephane Nicoll a > écrit : > > ... > OK. Why is our build failing with that error if we're importing the JUnit > > 5.5.2 bom and it does not fail if we're importing the JUnit 5.6.2 bom? > Our > > test depend

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

2020-05-04 Thread Romain Manni-Bucau
Le lun. 4 mai 2020 à 18:30, Stephane Nicoll a écrit : > On Mon, May 4, 2020 at 5:55 PM Romain Manni-Bucau > wrote: > > > Le lun. 4 mai 2020 à 17:23, Stephane Nicoll > a > > écrit : > > > > > On Mon, May 4, 2020 at 5:17 PM Romain Manni-Bucau < > rmannibu...@gmail.com > > > > > > wrote: > > > > >

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

2020-05-04 Thread Stephane Nicoll
On Mon, May 4, 2020 at 5:55 PM Romain Manni-Bucau wrote: > Le lun. 4 mai 2020 à 17:23, Stephane Nicoll a > écrit : > > > On Mon, May 4, 2020 at 5:17 PM Romain Manni-Bucau > > > wrote: > > > > > Le lun. 4 mai 2020 à 17:06, Stephane Nicoll > > > a > > > écrit : > > > > > > > Thanks but that does

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

2020-05-04 Thread Romain Manni-Bucau
Le lun. 4 mai 2020 à 17:23, Stephane Nicoll a écrit : > On Mon, May 4, 2020 at 5:17 PM Romain Manni-Bucau > wrote: > > > Le lun. 4 mai 2020 à 17:06, Stephane Nicoll > a > > écrit : > > > > > Thanks but that doesn't really answer my question. That version is > picked > > > up by dependency manag

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

2020-05-04 Thread Christian Stein
On Mon, May 4, 2020 at 5:17 PM Romain Manni-Bucau wrote: > Le lun. 4 mai 2020 à 17:06, Stephane Nicoll a > écrit : > > > Thanks but that doesn't really answer my question. That version is picked > > up by dependency management of the project as far as I can tell. If a > > project does provide an

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

2020-05-04 Thread Stephane Nicoll
On Mon, May 4, 2020 at 5:17 PM Romain Manni-Bucau wrote: > Le lun. 4 mai 2020 à 17:06, Stephane Nicoll a > écrit : > > > Thanks but that doesn't really answer my question. That version is picked > > up by dependency management of the project as far as I can tell. If a > > project does provide an

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

2020-05-04 Thread Romain Manni-Bucau
Le lun. 4 mai 2020 à 17:06, Stephane Nicoll a écrit : > Thanks but that doesn't really answer my question. That version is picked > up by dependency management of the project as far as I can tell. If a > project does provide an older junit engine version the build will break. > > If you meant to

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

2020-05-04 Thread Stephane Nicoll
Thanks but that doesn't really answer my question. That version is picked up by dependency management of the project as far as I can tell. If a project does provide an older junit engine version the build will break. If you meant to "force" a single version then I'd argue that you shouldn't resolv

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

2020-05-04 Thread Romain Manni-Bucau
Hi Stephane, AFAIK the choice with 2.22 maintenance for now was to keep using a single junit5 version as originally and if only support more flexibility with 3.x. Think it makes sense for now but if you want to PR 2.22 to backport 3.x work I guess it can be discussed too in another thread. Romain

Re: Maven Runtime Metrics System - MNG-6899

2020-05-04 Thread Romain Manni-Bucau
Le lun. 4 mai 2020 à 16:55, Slawomir Jaranowski a écrit : > Hi, > In my humble opinion it is not the best way to implement own api when > similar api is already ready and maintained. > > There is another project used for metrics: micrometer, as we can see it is > a quite popular 2.3K stars, 500 f

Use Java 8 in maven-integration-testing

2020-05-04 Thread Maarten Mulders
Hi all, While working on a new feature in Maven, I was writing some integration tests as well. I wanted to use Paths.get(...) and Files.newBufferedReader(...), but then I noticed that maven-integration-testing is (still) being built with Java 7 [1]. I understand it is important we can test o

Re: Maven Runtime Metrics System - MNG-6899

2020-05-04 Thread Slawomir Jaranowski
Hi, In my humble opinion it is not the best way to implement own api when similar api is already ready and maintained. There is another project used for metrics: micrometer, as we can see it is a quite popular 2.3K stars, 500 forks on github https://github.com/micrometer-metrics/micrometer Pleas

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

2020-05-04 Thread Stephane Nicoll
An update. This may be the other fixed issue in that release actually (SUREFIRE-1764). Is JUnit engine 1.6.1 now mandatory? What happens for projects that are using an older JUnit version? On Mon, May 4, 2020 at 3:59 PM Stephane Nicoll wrote: > I am not sure that SUREFIRE-1679 is fixed. I've ran

Re: APIs for reading Maven repositories

2020-05-04 Thread Manfred Moser
Elliotte Rusty Harold wrote on 2020-05-04 07:02 (GMT -07:00): > 2. Is it possible to boostrap the resolver without using the internal > class MavenRepositorySystemUtils? > > https://issues.apache.org/jira/browse/MNG-6579 > I am using the resolver in my Maven Repository Provisioner and boots

Re: APIs for reading Maven repositories

2020-05-04 Thread Mickael Istria
On Mon, May 4, 2020 at 4:10 PM Elliotte Rusty Harold wrote: > 1. Is there an API somewhere for locating the local maven repository > that is often but not always stored in ~/.m2/repository? > I didn't find a good code for that. It looks like MavenCli and related classes are doing most of the job

APIs for reading Maven repositories

2020-05-04 Thread Elliotte Rusty Harold
I'm working on code that is **not** in a Maven plugin (e.g. Gradle plugin or other tools) but that needs to interact with the Maven repository system. Typically this is what the maven artifact resolver is for: https://maven.apache.org/resolver/index.html Mostly I've figured out how to use this. H

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

2020-05-04 Thread Stephane Nicoll
I am not sure that SUREFIRE-1679 is fixed. I've ran the Spring Boot build with 2.22.2 and reproduced the error there. Upgrading to this candidate release and I got this error. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.3:test (default-test) on project spring

Re: Eclipse LemMinX & Maven extension: a Language Server for pom files

2020-05-04 Thread Mickael Istria
On Mon, May 4, 2020 at 2:40 PM Nick Stolwijk wrote: > Hi Mickael, > Hi, I was wondering if you send this intentionally to the dev mailinglist? I > think this is better suitable for the user mailinglist, also you have a > much broader audience there. > To be honest, we're not much looking for e

Re: Eclipse LemMinX & Maven extension: a Language Server for pom files

2020-05-04 Thread Nick Stolwijk
Hi Mickael, This looks like a cool project! I was wondering if you send this intentionally to the dev mailinglist? I think this is better suitable for the user mailinglist, also you have a much broader audience there. Hth, Nick Stolwijk ~~~ Try to leave this world a little better than you foun

Eclipse LemMinX & Maven extension: a Language Server for pom files

2020-05-04 Thread Mickael Istria
Hi all, I'd like to introduce to the Maven community the Eclipse LemMinX Language Server for XML files ( https://github.com/eclipse/lemminx/blob/master/README.md ) and, more importantly here, its extension for Maven pom files: https://github.com/eclipse/lemminx-maven/blob/master/README.md . While