[VOTE] Release Apache Maven Assembly Plugin version 3.3.0

2020-04-27 Thread Robert Scholte
Hi, We solved 10 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317220&version=12344774&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317220%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20

Re: Prefer Mockito?

2020-04-27 Thread Karl Heinz Marbaise
On 27.04.20 16:54, John Patrick wrote: Just did comment regarding typo. I also advocate Mockito, so also would be recommending that. It appeared Mockito supported junit v5 earlier than others and compared to previous versions remove boiler plate setup. Or I missed those other frameworks support

Re: Prefer Mockito?

2020-04-27 Thread Robert Scholte
People are bad readers. I'd suggest to spend some time to replace those frameworks with mockito (and powermock tests should be rewritten or removed, there should be no reason to use it). Otherwise we'll get more easymock tests or no PRs at all as people don't know how to use easymock. I've just

Re: JIRA issues for dependency upgrades

2020-04-27 Thread Karl Heinz Marbaise
Hi, On 27.04.20 17:10, Michael Osipov wrote: Am 2020-04-27 um 16:20 schrieb Elliotte Rusty Harold: Does the community have an consensus on whether to file JIRA tickets for minor dependency upgrades that don't require large code changes? I've been getting conflicting advice about this in code re

Re: JIRA issues for dependency upgrades

2020-04-27 Thread Michael Osipov
Am 2020-04-27 um 16:20 schrieb Elliotte Rusty Harold: Does the community have an consensus on whether to file JIRA tickets for minor dependency upgrades that don't require large code changes? I've been getting conflicting advice about this in code reviews. Here's what our docs currently say, but

Re: Prefer Mockito?

2020-04-27 Thread John Patrick
Just did comment regarding typo. I also advocate Mockito, so also would be recommending that. It appeared Mockito supported junit v5 earlier than others and compared to previous versions remove boiler plate setup. Or I missed those other frameworks supporting junit v5. PowerMock might be agued th

[GitHub] [maven-site] elharo commented on a change in pull request #158: [ARCHETYPE-594] recommend Mockito

2020-04-27 Thread GitBox
elharo commented on a change in pull request #158: URL: https://github.com/apache/maven-site/pull/158#discussion_r415874640 ## File path: content/apt/guides/development/guide-maven-development.apt ## @@ -56,6 +56,15 @@ Developing Maven You will find many unit tests. If at

[GitHub] [maven-site] nhojpatrick commented on a change in pull request #158: [ARCHETYPE-594] recommend Mockito

2020-04-27 Thread GitBox
nhojpatrick commented on a change in pull request #158: URL: https://github.com/apache/maven-site/pull/158#discussion_r415862987 ## File path: content/apt/guides/development/guide-maven-development.apt ## @@ -56,6 +56,15 @@ Developing Maven You will find many unit tests. I

JIRA issues for dependency upgrades

2020-04-27 Thread Elliotte Rusty Harold
Does the community have an consensus on whether to file JIRA tickets for minor dependency upgrades that don't require large code changes? I've been getting conflicting advice about this in code reviews. Here's what our docs currently say, but you'll notice that dependency upgrades fall somewhere i

Prefer Mockito?

2020-04-27 Thread Elliotte Rusty Harold
Anyone have an opinion on recommending Mockito as our preferred mocking library? https://github.com/apache/maven-site/pull/158/files This doesn't require us to port old unit tests, though we can. Right now we have a mix of Mockito, JMock, PowerMock, and EasyMock spread out across the plugins. --

[ANN] Maven Resolver 1.4.2 released

2020-04-27 Thread Michael Osipov
The Apache Maven team is pleased to announce the release of the Maven Resolver version 1.4.2. https://maven.apache.org/resolver/ Release Notes - Maven Resolver - Version 1.4.2 ** Bug * [MRESOLVER-38] - SOE/OOME in DefaultDependencyNode.accept ** Improvement * [MRESOLVER-93] - PathRec

[RESULT] [VOTE] Release Maven Resolver version 1.4.2

2020-04-27 Thread Michael Osipov
Hi, The vote has passed with the following result: +1: Michael Osipov, Karl Heinz Marbaise, Hervé Boutemy, Sylwester Lachiewicz, Elliotte Rusty Harold PMC quorum: reached I will promote the artifacts to the central repo, the source release ZIP file and add this release the board report.