Re: jenkins triggers

2020-03-14 Thread Karl Heinz Marbaise
Hi, On 13.03.20 10:08, Stephen Connolly wrote: Infra changed the hostname and url to subscribe to so the plugin is being updated... until then you’re relying on polling every 8h or something like that Does that mean the push on a git box repository does not trigger a Jenkins build (which look

Re: Maven Runtime Metrics

2020-03-14 Thread Romain Manni-Bucau
What's wrong with the IoC? In a plugin you can do: @Inject @Named("...") // Or other equivalent annotations Metrics metrics; Then you can pass the reference if you want. Keep in mind static ref in scoped instances, even loggers, are antipatterns only justified by perf in early times. How would

Re: Maven Runtime Metrics

2020-03-14 Thread Enrico Olivelli
Il Sab 14 Mar 2020, 19:27 Romain Manni-Bucau ha scritto: > Hmm, not sure it is a good example, plugins do play IoC game already and is > the cleanest way to move forward otherwise you will leak the counter or > need to play with thread locals which is worse for plugins using this > pattern (will

Re: Maven Runtime Metrics

2020-03-14 Thread Romain Manni-Bucau
Hmm, not sure it is a good example, plugins do play IoC game already and is the cleanest way to move forward otherwise you will leak the counter or need to play with thread locals which is worse for plugins using this pattern (will forbid plugins to use threads). That said you can still replace al

Re: Maven Runtime Metrics

2020-03-14 Thread Enrico Olivelli
Il giorno sab 14 mar 2020 alle ore 17:53 Romain Manni-Bucau ha scritto: > > Assuming maven core/boot is components, a component registry can instrument > plugins and subclassloaders with classfiletransformers so maybe ok to keep > it in the IoC. Romain, can please you elaborate more ? I am think

Re: Maven Runtime Metrics

2020-03-14 Thread Romain Manni-Bucau
Assuming maven core/boot is components, a component registry can instrument plugins and subclassloaders with classfiletransformers so maybe ok to keep it in the IoC. Le sam. 14 mars 2020 à 15:14, Enrico Olivelli a écrit : > I am starting this work. > I have pushed a copy of current maven core ma

Re: Maven Runtime Metrics

2020-03-14 Thread Enrico Olivelli
I am starting this work. I have pushed a copy of current maven core master to maven-studies. Then I have added my "maven-metrics" module. This module contains only the API to be implemented by Metrics Providers and a No-op implementation. You can find the draft API here. https://github.com/apache

Re: finishing build/consumer implementation

2020-03-14 Thread Robert Scholte
I should have handled all review comments by now. The infinitive loop of the maven-shade-plugin was unrelated and has already been fixed on master. Give it another try and let me know if it is ready to be merged to master. thanks, Robert On 2-3-2020 20:05:44, Michael Osipov wrote: Am 2020-03-01

Re: (anonymous) github user commits

2020-03-14 Thread Elliotte Rusty Harold
On Sat, Mar 14, 2020 at 6:22 AM Robert Scholte wrote: > > Yes, once confirmed that the branch builds fine on our Jenkins, we should do > the "squash and merge". (we should already be happy with a proper PR) > My experience so far was like you describe, but it doesn't explain why > Elliotte cause

Re: (anonymous) github user commits

2020-03-14 Thread Enrico Olivelli
Several Apache project have a script to perform this stuff I really love this kind of scripts You can find an example here (1) Such scripts: - squash all commits into one - keep original author - ask for a meaningful commit message - interact with JIRA - set Resolved status and fixVersion - all i

Re: [VOTE] Apache Maven Javadoc Plugin 3.2.0

2020-03-14 Thread Karl Heinz Marbaise
Hi, +1 from me. Kind regards Karl Heinz Marbaise PS.: I couldn't check the sha512 cause not send with the VOTE mail... On 12.03.20 08:19, Olivier Lamy wrote: Hi, We fixed 14 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&version=12345698 Staging repository:

Re: (anonymous) github user commits

2020-03-14 Thread Robert Scholte
Yes, once confirmed that the branch builds fine on our Jenkins, we should do the "squash and merge". (we should already be happy with a proper PR) My experience so far was like you describe, but it doesn't explain why Elliotte causes "github" to become the committer. One possible difference I see

Re: [VOTE] Apache Maven Javadoc Plugin 3.2.0

2020-03-14 Thread Robert Scholte
+1 On 12-3-2020 08:19:32, Olivier Lamy wrote: Hi, We fixed 14 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&version=12345698 Staging repository: https://repository.apache.org/content/repositories/maven-1557/ direct link to artifacts: https://repository.apache.o