Re: Second MNG-6765 ([Regression] tycho pom-less builds fails with 3.6.2)

Inline: On Oct 18, 2019, at 5:15 PM, Stuart McCulloch wrote: > > Any string apart from "default" or the empty string will work here - I > happened to chose "core" because I viewed it as a core implementation. > > Also a quick reminder that this is only needed when a component uses @Typed > and

Re: Second MNG-6765 ([Regression] tycho pom-less builds fails with 3.6.2)

Any string apart from "default" or the empty string will work here - I happened to chose "core" because I viewed it as a core implementation. Also a quick reminder that this is only needed when a component uses @Typed and wants to allow overriding, it's not necessary in any other situation - so in

Re: Second MNG-6765 ([Regression] tycho pom-less builds fails with 3.6.2)

Hi, the adjusted @Named annotation is on DefaultModelProcessor, not DefaultModelBuilder. They both implement the ModelBuilder interface, but the one that extensions like to overwrite is the implementation of DefaultModelBuilder. So I'd prefer to stick to "core" as proposed my Stuart. thanks

Re: Second MNG-6765 ([Regression] tycho pom-less builds fails with 3.6.2)

Hi, As noted in Slack I think it would be more clear if we used something like @Named( “allowDefaultOverride” ) vs @Named( “core” ) As that expresses the intent and can be used anywhere it's allowed for a client to override the default component. The tests in polyglot all pass with this chan

Re: JSR250 in the lib

Petar, can you create a JIRA issue[1] for it plus a PR based on the advice of Stuart. You should be able to verify the change for yourself, if upgrading the dependency works. thanks, Robert [1] https://issues.apache.org/jira/browse/MNG On Mon, 14 Oct 2019 13:42:40 +0200, Olivier Lamy wro

Second MNG-6765 ([Regression] tycho pom-less builds fails with 3.6.2)

Hi, with the help from Stuart McCulloch we've been able to provide a patch for MNG-6765[1] Please review and test. thanks, Robert [1] https://issues.apache.org/jira/browse/MNG-6765 [2] https://github.com/apache/maven/commit/24e6c0ec0a87b6682513287a23c36db6996b874c [3] https://github.com/

Did you see dependabot?

Hey guys, Did you see dependabot on our repos? Like this automatic PR https://github.com/apache/maven-plugins/pull/147#pullrequestreview-303889692 I feel this is very useful, but... does anyone enabled it? Do we have to set a policy, this suggestions are security related fixes, we could give the