Re: Found Issues - Release Apache Maven Version 3.6.2

2019-08-29 Thread Tibor Digana
Hi Alexander, Would it solve your problem if we uncover the method [1] and develop a builder for the chain of methods [2]? To uncover [2] means to make the Plexus Container API accessible within the builder. Perhaps more has to be done but that's up to the future collaborative work on GitHub. [1]

Re: [VOTE] Release Apache Maven Version 3.6.2

2019-08-29 Thread Hervé BOUTEMY
+1 Regards, Hervé Le mercredi 28 août 2019, 21:17:49 CEST Enrico Olivelli a écrit : > Hi, > > We have solved 52 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&ve > rsion=12345234 > > There are issues left in JIRA for Maven core: > https://issues.apache.org/

Re: [VOTE] Release Apache Maven Version 3.6.2

2019-08-29 Thread Mickael Istria
+0.99 from Eclipse Tycho (test build https://ci.eclipse.org/tycho/job/tycho-build-with-maven-snapshots/31/ ) The only (minor) test failure is a regression in Maven 3.6.2 compared to 3.6.0 (Tycho couldn't work with 3.6.1 so cannot test it) and can be reproduced locally. The cause is most likely a di

Re: Found Issues - Release Apache Maven Version 3.6.2

2019-08-29 Thread Tibor Digana
We are draming of Maven 4 and Maven 5 and features in it, and we have legacy code + patch over a patch. We are using Guice with a nice Guice API and we are using components.xml like it was in the old Spring. Would it be a good time to change some code in favor of modern style? Nevertheless this par

Re: Found Issues - Release Apache Maven Version 3.6.2

2019-08-29 Thread Alexander Bubenchikov
Hi Stuart E.g. https://github.com/JetBrains/intellij-community/blob/master/plugins/maven/maven3-server-impl/src/org/jetbrains/idea/maven/server/Maven3XServerEmbedder.java customizeComponents method Originally idea use own components defined in META-INF/plexus/components.xml with hints "ide", then

Re: Found Issues - Release Apache Maven Version 3.6.2

2019-08-29 Thread Stuart McCulloch
How are you replacing them currently? The typical way is to use the extensions mechanism: https://maven.apache.org/docs/3.3.1/release-notes.html#Core_Extensions Components contributed via an extension have a higher priority over the original component in core (assuming that they have the same JSR

Re: [VOTE] Release Apache Maven Version 3.6.2

2019-08-29 Thread Francois Papon
+1 (non-binding) Thanks! regards, François fpa...@apache.org Le 28/08/2019 à 21:17, Enrico Olivelli a écrit : > Hi, > > We have solved 52 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12345234 > > There are issues left in JIRA for Maven core: > http

Re: Found Issues - Release Apache Maven Version 3.6.2

2019-08-29 Thread Enrico Olivelli
Il gio 29 ago 2019, 12:46 Alexander Bubenchikov < alexander.bubenchi...@jetbrains.com> ha scritto: > Hi Enrico, my name is Alex, I've joined to Jetbrains this year and > responsible for maven integration and Intellij idea. > Nice to meet you Alex I am sorry I am not an expert of this part of Mave

Re: [VOTE] Release Apache Maven Version 3.6.2

2019-08-29 Thread Romain Manni-Bucau
+1 (non binding) Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book

Re: Found Issues - Release Apache Maven Version 3.6.2

2019-08-29 Thread Tibor Digana
Having interface in a singleton is a kind of silly design because these are two abstractions which go one against the other. The CDI has an injection Provider and you caniterate over beans of certain bean type and select according @Name then. I think this mechanism can be used. On Thu, Aug 29, 201

Re: Found Issues - Release Apache Maven Version 3.6.2

2019-08-29 Thread Alexander Bubenchikov
Hi Enrico, my name is Alex, I've joined to Jetbrains this year and responsible for maven integration and Intellij idea. he issue happen because we replace some components in maven (ModelInterpolator in this case) to our own implementation which have injected PathTranslator and UrlNormalizer I've w

Re: [VOTE] Release Apache Maven Version 3.6.2

2019-08-29 Thread Mickael Istria
+1 from Eclipse m2e (test change: https://git.eclipse.org/r/#/c/142991/ , test build: https://ci.eclipse.org/m2e/job/m2e-gerrit/479/ )