Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0

2019-05-13 Thread Enrico Olivelli
Il lun 13 mag 2019, 23:48 Tibor Digana ha scritto: > Robert, I did *not* use the source zip. > IMHO we should vote on the staged zip > git clone https://gitbox.apache.org/repos/asf/maven-checkstyle-plugin > Oracle jdk 1.8.0u212, Maven 3.3.9, Windows 10 > This is what CI does and tests are pas

Open pull requests

2019-05-13 Thread Joseph Walton
As an interested contributor, I've opened a couple of pull requests, and it's not always clear what the next step is for a non-project-member to get things merged. To see how other PRs (https://github.com/apache/maven/pulls -- currently, '32 open') are being handled, I thought it might make sense

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0

2019-05-13 Thread Tibor Digana
Robert, I did *not* use the source zip. git clone https://gitbox.apache.org/repos/asf/maven-checkstyle-plugin Oracle jdk 1.8.0u212, Maven 3.3.9, Windows 10 I see there is a new line, but the checkstyle does not care if you put one or two lines. No idea why. Even if you go to the target and run i

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0

2019-05-13 Thread Robert Scholte
This can happen when source-release.zip was created on a different OS compared to the verifying OS. With Git it will switch to the line endings of the operating system, but with a zip that's not possible. I'd say not blocking, but the IT needs to be fixed to handle these situations. Rob

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0

2019-05-13 Thread Tibor Digana
I use the latest commit at Gitbox b1ad0bbbf077d5670cf679043076b9a1691ce4cc I will try to add two newlines in the file. On Mon, May 13, 2019 at 9:55 PM Enrico Olivelli wrote: > Tibor > It is strage all its are passing on CI. > Are you sure you have correcly unpacked the package? > > > Il lun 13 m

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0

2019-05-13 Thread Enrico Olivelli
Tibor It is strage all its are passing on CI. Are you sure you have correcly unpacked the package? Il lun 13 mag 2019, 21:23 Tibor Digana ha scritto: > checked the sha512 of src zip, ok > checked the build, failed (mvn verify -P run-its,quality-checks) > What is 'quality-checks' profile? I hav

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0

2019-05-13 Thread Karl Heinz Marbaise
Hi, I have checked the SHA512 Ok...and unpacked the release and tested via: mvn -Prun-its clean verify Get a complete fine build without any issue on MacOS JDK11... Maven 3.6.1 so +1 from me... Kind regards Karl Heinz Marbaise On 13.05.19 11:52, Enrico Olivelli wrote: Hi, We solved 13 issu

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0

2019-05-13 Thread Tibor Digana
checked the sha512 of src zip, ok checked the build, failed (mvn verify -P run-its,quality-checks) [INFO] Building: MCHECKSTYLE-54\pom.xml [INFO] MCHECKSTYLE-54\pom.xml ... FAILED (5.3 s) *Mcheckstyle54.java:[1] (misc) NewlineAtEndOfFile: File does not end with a

[ANN] Apache Maven JAR Plugin 3.1.2 Released

2019-05-13 Thread Karl Heinz Marbaise
The Apache Maven team is pleased to announce the release of the Apache Maven JAR Plugin Version 3.1.2. https://maven.apache.org/plugins/maven-jar-plugin/ Important Note: * Maven 3.X only * JDK 7 minimum requirement You should specify the version in your project's plugin configuration: or

[RESULT] [VOTE] Retired Maven Artifact Resolution API (Maven2)

2019-05-13 Thread Robert Scholte
Hi, The vote has passed with the following result: +1: Karl Heinz Marbaise, Anders Hammar, Hervé BOUTEMY, Tamás Cservenák, Gabriel Belingueres, Manfred Moser, Bernd Prager, Enrico Olivelli, Guang Chao, Tibor Digana, Sylwester Lachiewicz, Robert Scholte PMC quorum: reached I will continue with

Re: [VOTE] Retired Maven Artifact Resolution API (Maven2)

2019-05-13 Thread Robert Scholte
+1 On 8-5-2019 20:25:14, Robert Scholte wrote: Hi, The Apache Maven project consist of about 100 (sub)projects. Due to the small number of volunteers and the huge amount of code to maintain we're missing enough space to make real progress on all these projects, including our  ambitious ideas fo

[VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0

2019-05-13 Thread Enrico Olivelli
Hi, We solved 13 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12342397&styleName=Text&projectId=12317223 Please note that this version now only supports CheckStyle 8+ and Java 8 (as required by latest Checkstyle) There are still a couple of issues left in JIRA: https://