Re: Help with maven-jmod-plugin issues

2019-01-17 Thread Robert Scholte
I've added review comments for both PRs. I would expect a better solution for MJMOD-8, I can help with that. The rest is mostly a matter of cleaning up: removing things from the pom that don't add anything to the IT and write Groovy as Groovy ;) Robert On Thu, 17 Jan 2019 16:02:38 +0100, And

Re: Releasing Maven enforcer plugin

2019-01-17 Thread Robert Scholte
Hi Gabriel, I think you missed the message that this code doesn't belong to m-dependency-tree, but to m-artifact-transfer. Would be great if you could move the code. thanks, Robert On Thu, 17 Jan 2019 16:13:15 +0100, Gabriel Belingueres wrote: I've made progress with the m-dependency-t

Re: Releasing Maven enforcer plugin

2019-01-17 Thread Gabriel Belingueres
I've made progress with the m-dependency-tree [1] shared library which should help unblock some issues in enforcer. It needs review though (and a release) [1] https://issues.apache.org/jira/browse/MSHARED-788 El jue., 17 de ene. de 2019 06:25, Tibor Digana escribió: > To lookup easy or fast fix

Help with maven-jmod-plugin issues

2019-01-17 Thread Andre Tadeu de Carvalho
Hello people! Thank you all for being supportive. Could someone help me reviewing the following PRs? MJMOD-8: https://github.com/apache/maven-jmod-plugin/pull/2 MJMOD-20: https://github.com/apache/maven-jmod-plugin/pull/1 I could use these fixes successfully to build the following demos: - h

RE: PR for archetype plugin: Groovy + Ivy Support

2019-01-17 Thread Stefan Seifert
hello! can anyone have a look on this? stefan >-Original Message- >From: Stefan Seifert [mailto:sseif...@pro-vision.de] >Sent: Thursday, January 3, 2019 10:19 AM >To: Maven Developers List >Subject: PR for archetype plugin: Groovy + Ivy Support > >i've provided a PR [1] for ARCHETYPE-536

Re: Releasing Maven enforcer plugin

2019-01-17 Thread Tibor Digana
To lookup easy or fast fixes, and +1 to perform a release then. T On Wed, Jan 16, 2019 at 1:56 PM Enrico Olivelli wrote: > An user is asking for a release of the enforcer plugin > > https://github.com/apache/maven-enforcer/pull/36#issuecomment-447238729 > > I can prepare the release > > Thoughts