Re: suggestion regarding MJAVADOC-564 - javadoc:fix enforcing order of tags

2019-01-16 Thread Richard Sand
Comparator will help order the tags but we still want to preserve the order of found tags we aren’t fixing, such as if we aren’t fixing “see” tags and want to honor the original order of the existing see tags. I’ll give it a shot Sent from my iPhone > On Jan 16, 2019, at 3:40 PM, Robert Schol

Re: suggestion regarding MJAVADOC-564 - javadoc:fix enforcing order of tags

2019-01-16 Thread Robert Scholte
It would be great if the fix-goal code could be simplified. In fact I thought about moving code to a different package+classes, which should make it easier read, maintain and to unittest. But that's a huge task. It is still a bit too abstract for me to see the complete picture. The first thi

suggestion regarding MJAVADOC-564 - javadoc:fix enforcing order of tags

2019-01-16 Thread Richard Sand
Hi all - I'd like to provide a fix for MJAVADOC-564, where the javadoc:fix goal will sometimes output the javadoc tags in incorrect order. The problem occurs because of the way the fix goal initially reads in the tags and then iterates over them to make the prescribed corrections. There is an i

Re: Releasing Maven enforcer plugin

2019-01-16 Thread Hervé BOUTEMY
need to see what to do with still opened issues: https://issues.apache.org/jira/projects/MENFORCER/versions/12330768 Regards, Hervé Le mercredi 16 janvier 2019, 13:56:30 CET Enrico Olivelli a écrit : > An user is asking for a release of the enforcer plugin > > https://github.com/apache/maven-en

Re: Releasing Maven enforcer plugin

2019-01-16 Thread Sylwester Lachiewicz
We have a few PRs on Github from community, maybe we can try to review and include also? +1 for release BR Sylwester W dniu śr., 16.01.2019 o 14:32 Stephen Connolly < stephen.alan.conno...@gmail.com> napisał(a): > +1 > > On Wed, 16 Jan 2019 at 12:56, Enrico Olivelli wrote: > > > An user is ask

Re: Releasing Maven enforcer plugin

2019-01-16 Thread Robert Scholte
Just know that as long as MENFORCER-267 is not fixed, it must be a milestone. thanks, Robert [1] https://issues.apache.org/jira/browse/MENFORCER-267 On Wed, 16 Jan 2019 14:32:33 +0100, Stephen Connolly wrote: +1 On Wed, 16 Jan 2019 at 12:56, Enrico Olivelli wrote: An user is ask

Re: Releasing Maven enforcer plugin

2019-01-16 Thread Stephen Connolly
+1 On Wed, 16 Jan 2019 at 12:56, Enrico Olivelli wrote: > An user is asking for a release of the enforcer plugin > > https://github.com/apache/maven-enforcer/pull/36#issuecomment-447238729 > > I can prepare the release > > Thoughts? > Enrico > -- > > > -- Enrico Olivelli >

Releasing Maven enforcer plugin

2019-01-16 Thread Enrico Olivelli
An user is asking for a release of the enforcer plugin https://github.com/apache/maven-enforcer/pull/36#issuecomment-447238729 I can prepare the release Thoughts? Enrico -- -- Enrico Olivelli