Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M2

2018-12-08 Thread Christian Stein
+1 Cheers, Christian

Re: Parsing pom.xml

2018-12-08 Thread Laird Nelson
I forgot to mention: if you want to do this all "by hand", i.e. not rely on JSR 330 containers, you want to look here ( https://maven.apache.org/resolver/apidocs/index.html?org/eclipse/aether/impl/DefaultServiceLocator.html) and work backwards. Best, Laird -- https://about.me/lairdnelson On Sat,

Re: Parsing pom.xml

2018-12-08 Thread Laird Nelson
This is all near and dear to my heart. First, some terminology clearing up: the Maven internals rely on a JSR-330 implementation (javax.inject.*), not CDI (javax.enterprise.inject.*). CDI is a JSR-330 implementation, but so is Guice, HK2, etc. I believe that the internals of Maven rely on Guice,

Re: Parsing pom.xml

2018-12-08 Thread Robert Scholte
On Sat, 08 Dec 2018 21:52:16 +0100, Andres Almiray wrote: So far so good, I can parse POM files and read data. This works fine as long as I don't have to access a parent POM. @Robert: I suspect your first suggestion may be needed in order to resolve parent POM files as artifacts, isn't th

Re: Parsing pom.xml

2018-12-08 Thread Andres Almiray
So far so good, I can parse POM files and read data. This works fine as long as I don't have to access a parent POM. @Robert: I suspect your first suggestion may be needed in order to resolve parent POM files as artifacts, isn't that right? Best, Andres --

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M2

2018-12-08 Thread Tibor Digana
Perhaps it is the issue where JVM passed ASCII 0x04 == EOT to the stream when we called System.exit in the fork. This has corrupted the stream too. Is there any Jira issue refering to your problem? https://en.wikipedia.org/wiki/End-of-Transmission_character https://en.wikipedia.org/wiki/ASCII On S

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M2

2018-12-08 Thread Eric Lilja
Hi, Tibor, yes I saw the milestone roadmap, that's why I am excited for M2 (which I tested both on private projects and at work), since it brings us closer to M3, which introduces changes which will be beneficial for Pax Exam (communicating with child processes through sockets). The problems wi

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M2

2018-12-08 Thread Tibor Digana
@Eric Lilja You use Pax. I guess you are refering to the problem with standard input and standard output stream. The plugin says that the stream is corrupted. Am I right? Did you see the documentation here in this Vote? See the roadmap on the front page http://maven.apache.org/surefire-archives/su

Re: Parsing pom.xml

2018-12-08 Thread Robert Scholte
Ah, you might be lucky with this solution :) On Sat, 08 Dec 2018 19:20:59 +0100, Andres Almiray wrote: Looks like I found the answer to instantiating the ModelBuilder new DefaultModelBuilderFactory().newInstance() From the javadoc: * A factory to create model builder instances when

Re: Parsing pom.xml

2018-12-08 Thread Robert Scholte
Hi Andres, this is what you need to do: @Inject private ModelBuilder builder; (or with @Requiment when using only plexus annotations) This means you need your code to run in a CDI container. If you use Sisu[1] you can mix Plexus and JSR330 annotations. Maven & JSR-330[2] Should explain mos

Re: Parsing pom.xml

2018-12-08 Thread Andres Almiray
Looks like I found the answer to instantiating the ModelBuilder new DefaultModelBuilderFactory().newInstance() >From the javadoc: * A factory to create model builder instances when no dependency injection is available. Note: This class is * only meant as a utility for developers that want

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M2

2018-12-08 Thread Eric Lilja
+1 (non-binding) M2 is looking good on my projects, and I can't wait for the upcoming M3 after M2, which I believe will solve the long-standing problems running Pax Exam tests (in the organization I work in we use 2.18.1 of surefire for Pax-Exam tests particularly, as no version of Surefire hi

Re: Parsing pom.xml

2018-12-08 Thread Andres Almiray
HI Oliver, Nice! However that approach may require mapping all possible elements, including plugins and more. The ModelBuilder should take care of that, isn't it? Cheers, Andres --- Java Champion; Groovy Enthusiast JCP EC Associate Seat http://andresalmira

Re: Parsing pom.xml

2018-12-08 Thread Oliver Drotbohm
If it's about pure XML parsing and tweaking the information and building the model is not required, XmlBeam [0] is a lightweight alternative to map the entire file to a Java object. We use that in the Spring Data release automation. Declare an interface containing accessors backed by XPath expr

Re: Parsing pom.xml

2018-12-08 Thread Andres Almiray
Thank you Robert! It looks like org.apache.maven.model.Model.DefaultModelBuilder provides the behavior I need given this method found in its contract ModelBuildingResult build( ModelBuildingRequest request ) throws ModelBuildingException; ModelBuildingResult gives me access to the raw

Re: Parsing pom.xml

2018-12-08 Thread Robert Scholte
The ModelBuilder[1] is what you are looking for, and yes it does a LOT :) Be aware that it is using CDI, so to make use of it you'll need sisu/guice too. Robert [1] https://maven.apache.org/ref/3.6.0/maven-model-builder/ On Sat, 08 Dec 2018 18:20:51 +0100, Andres Almiray wrote: Of cou

Re: Parsing pom.xml

2018-12-08 Thread Andres Almiray
Of course. This is definitely not a plugin project. My goal is to have an in-memory representation of the POM as defined by a source pom.xml, to later transform/enrich it and write it back. As a side effect this tool can calculate statics on usage patterns and recommend some others. Best, Andres

Re: Parsing pom.xml

2018-12-08 Thread Enrico Olivelli
Il sab 8 dic 2018, 18:09 Andres Almiray ha scritto: > Hello everyone, > > I have the need of building a model based on the data defined in a pom.xml > file. > What would be the best way to read, parse, and obtain such model using > standard Maven APIs? > Could you given some more context? I gue

Parsing pom.xml

2018-12-08 Thread Andres Almiray
Hello everyone, I have the need of building a model based on the data defined in a pom.xml file. What would be the best way to read, parse, and obtain such model using standard Maven APIs? Best, Andres --- Java Champion; Groovy Enthusiast JCP EC Associate

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M2

2018-12-08 Thread Francois Papon
+1 (non-binding) Thanks! regards, François Papon fpa...@apache.org Le 06/12/2018 à 02:26, Tibor Digana a écrit : > Hi, > > We solved 15 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12344396 > > There are still a couple of issues left in JIRA: > htt

Re: How much m2e test suites cover of Maven ?

2018-12-08 Thread Mickael Istria
On Saturday, December 8, 2018, Robert Scholte wrote: > Hi, Hi Robert, > how can we verify that Maven changes are still compatible with IDEs? > [...] Hence we are still looking for a way to verify these changes and > their effects on IDEs. I think https://bugs.eclipse.org/bugs/show_bug.cgi?i

Re: [VOTE] Release Apache Maven Shared Component: Maven Dependency Analyzer 1.11.0

2018-12-08 Thread Mark Raynsford
+1 (non-binding) -- Mark Raynsford | http://www.io7m.com pgp3rVLfVx5Vr.pgp Description: OpenPGP digital signature

[VOTE] Release Apache Maven Shared Component: Maven Dependency Analyzer 1.11.0

2018-12-08 Thread Karl Heinz Marbaise
Hi, We solved 4 issues: https://issues.apache.org/jira/projects/MSHARED/versions/12344434 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20XX%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC Staging rep

[VOTE] Release Apache Maven Help Plugin version 3.1.1

2018-12-08 Thread Karl Heinz Marbaise
Hi, We solved 6 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317522&version=12343422&styleName=text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MPH%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20k

Re: parallelise not overlapping tasks

2018-12-08 Thread Romain Manni-Bucau
Using the scm is not enough or it is for single module projects. You have to have a graph of dependencies (inputs/outputs) and save each task state in target to have incremental support But please note incremental build is != parallel build at mojo level. This last one is easy to do and a quick

[VOTE] Release Apache Maven JAR Plugin version 3.1.1

2018-12-08 Thread Karl Heinz Marbaise
Hi, We solved 7 issues: https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317526%20AND%20fixVersion%20%3D%2012343046%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MJAR%20AND%20r

Re: plugin:descriptor fails with java.util.NoSuchElementException

2018-12-08 Thread Enrico Olivelli
+1 for Tibor's explanation. Enrico Il sab 8 dic 2018, 12:29 Tibor Digana ha scritto: > PluginDescriptorGenerator.writeDescriptor does not use Threads so it must > be the problem that the number of calls "endElement" is greater than calls > "startElement". > > https://github.com/apache/maven-plug

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M2

2018-12-08 Thread Karl Heinz Marbaise
Hi, +1 from me. Kind regards Karl Heinz Marbaise On 05/12/18 23:26, Tibor Digana wrote: Hi, We solved 15 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12344396 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/i#issues/

Re: plugin:descriptor fails with java.util.NoSuchElementException

2018-12-08 Thread Tibor Digana
PluginDescriptorGenerator.writeDescriptor does not use Threads so it must be the problem that the number of calls "endElement" is greater than calls "startElement". https://github.com/apache/maven-plugin-tools/blob/master/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/gen

Re: plugin:descriptor fails with java.util.NoSuchElementException

2018-12-08 Thread Tibor Digana
I do not think it can be such JVM issue with string concatenations, otherwise all the world has the same problem. This type of issue is usually caused by multiple writes from multiple threads. Try to log every method with Thread id and we should see multiple ids. The java.io is supposed to be synch

Re: How much m2e test suites cover of Maven ?

2018-12-08 Thread Robert Scholte
Hi, during the vote for 3.6.0 we were made aware of issues with different IDEs, which did indeed raise the question: how can we verify that Maven changes are still compatible with IDEs? [1] Even though I consider the IDE as a wrapper around a tool like Maven (and IDEs should follow the tool

Re: MNG-6533 and MNG-6529

2018-12-08 Thread Robert Scholte
These PRs look fine, I'll run them on our CI servers. thanks, Robert On Thu, 06 Dec 2018 10:41:58 +0100, Mickael Istria wrote: Hi all, As part of a major performance improvement in m2e, we'd like to use the ProjectBuilder.build(list_of_poms, ...) which drastically reduce CPU and RAM consu