JDK 12 , JDK 8u202 & Project Panama Early-Access builds available

2018-11-09 Thread Rory O'Donnell
Hi Robert , *JDK 12 Early Access build 19 is available at : - jdk.java.net/12/* * These early-access, open-source builds are provided under the GNU General Public License, version 2, with the Classpath Exception . * Release Notes updates sinc

Re: [maven-enforcer] 05/05: Code improvement.

2018-11-09 Thread Eric Lilja
> > > > +private boolean isVersion( String version ) > > +{ > > +return StringUtils.isNotEmpty( version ) && > > !StringUtils.isWhitespace( version ); > > +} > Maybe use StringUtils.isNotBlank() instead? - Eric L

Re: [maven-enforcer] 05/05: Code improvement.

2018-11-09 Thread Karl Heinz Marbaise
Hi Robert, On 09/11/18 10:05, Robert Scholte wrote: Please rename to isValidVersion +    private boolean isVersion( String version ) Really good idea...Thanks for this ... Kind regards Karl Heinz Marbaise +    { +    return StringUtils.isNotEmpty( version ) && !StringUtils.isWhitesp

Re: Remove Branches

2018-11-09 Thread Olivier Lamy
+1 for cleaning! On Fri, 9 Nov 2018 at 6:49 pm, Robert Scholte wrote: > +1 for cleanups. > > Most (all?) fail while master is good, so in their current state they're > kind of useless. > > Robert > > On Thu, 08 Nov 2018 20:40:50 +0100, Karl Heinz Marbaise > wrote: > > > Hi, > > > > I would like

Re: [maven-enforcer] 05/05: Code improvement.

2018-11-09 Thread Robert Scholte
On Fri, 09 Nov 2018 08:58:49 +0100, wrote: This is an automated email from the ASF dual-hosted git repository. khmarbaise pushed a commit to branch MENFORCER-306 in repository https://gitbox.apache.org/repos/asf/maven-enforcer.git commit e81e13178ae3ea153a0d0c5936ca951b71a73bc3 Author: Karl H

Re: Remove Branches

2018-11-09 Thread Robert Scholte
+1 for cleanups. Most (all?) fail while master is good, so in their current state they're kind of useless. Robert On Thu, 08 Nov 2018 20:40:50 +0100, Karl Heinz Marbaise wrote: Hi, I would like to do some house keeping in our Maven Core Branches.. Currently there exists a branch: MNG