Re: Welcome Sylwester Lachiewicz to the Apache Maven Team

2018-09-05 Thread Martin Gainty
wilkommen sylwester i look forward to reading your jira reports martin From: Karl Heinz Marbaise Sent: Wednesday, September 5, 2018 1:27 PM To: Maven Developers List; Sylwester Lachiewicz Subject: Re: Welcome Sylwester Lachiewicz to the Apache Maven Team Hi Sylw

Re: Server Issue

2018-09-05 Thread Karl Heinz Marbaise
Hi, please ask questions about the use / problem etc. on the Maven User list not on the developers list... Kind regards Karl Heinz Marbaise On 05/09/18 13:56, Priya Lakshmi wrote: Hi, I am trying to download maven dependencies from Eclipse IDE. Unfortunately, I am not able to download them

Re: Server Issue

2018-09-05 Thread Basin Ilya
Hi Priya. In Eclipse go to Window > Show View > Other > Genearl > Problems The "Problems" view will appear. Find there the error and copy it. The error should contain the full stack trace explaining the problem. Sometimes the Plugin Downloader reports only the short description. In that case y

Re: Welcome Sylwester Lachiewicz to the Apache Maven Team

2018-09-05 Thread Karl Heinz Marbaise
Hi Sylwester, On 05/09/18 19:20, Sylwester Lachiewicz wrote: Hi Everyone, thank you for so warm welcome - my adventure with helping Maven Project began not so long ago, and the more I am more than willing to join you. Great to hear this... We have some work in Jira and a PRs to review - I'm

Re: issue with junit 5 integration

2018-09-05 Thread Christian Stein
On Wed, Sep 5, 2018 at 6:49 PM Tibor Digana wrote: > >> Yes but the platform and engine are transitive, right? > Yes. We can grab the classpath from the forked jvm via Jconsole and we > should see these artifacts. > > @Christian > what happens when you just add new Engine with another version to

Re: Welcome Sylwester Lachiewicz to the Apache Maven Team

2018-09-05 Thread Sylwester Lachiewicz
Hi Everyone, thank you for so warm welcome - my adventure with helping Maven Project began not so long ago, and the more I am more than willing to join you. We have some work in Jira and a PRs to review - I'm going to verify it. And I hope The Maven Team in the future with commits. Best regards S

Re: issue with junit 5 integration

2018-09-05 Thread Tibor Digana
>> Yes but the platform and engine are transitive, right? Yes. We can grab the classpath from the forked jvm via Jconsole and we should see these artifacts. @Christian what happens when you just add new Engine with another version to the POM's dependencies or plugin's dependencies. The old version

Re: issue with junit 5 integration

2018-09-05 Thread Romain Manni-Bucau
Le mer. 5 sept. 2018 18:20, Tibor Digana a écrit : > Romain, that link in Resolver means that our Provider has transitive > dependencies. This Surefire's Platform Provider + it's dependencies. Not > the JUnit5's provider. > Yes but the platform and engine are transitive, right? Adding engine w

Re: issue with junit 5 integration

2018-09-05 Thread Tibor Digana
(Sorry, I had to re-send my email from apache.org) Romain, that link in Resolver means that our Provider has transitive dependencies. This Surefire's Platform Provider + it's dependencies. Not the JUnit5's provider. Adding engine with another version makes sense to me in current situation. It's sim

Re: issue with junit 5 integration

2018-09-05 Thread Tibor Digana
Romain, that link in Resolver means that our Provider has transitive dependencies. This Surefire's Platform Provider + it's dependencies. Not the JUnit5's provider. Adding engine with another version makes sense to me in current situation. It's similar to what we are doing when we add junit:junit:4

Server Issue

2018-09-05 Thread Priya Lakshmi
Hi, I am trying to download maven dependencies from Eclipse IDE. Unfortunately, I am not able to download them, and below is the error message I am getting Plugin org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M2 or one of its dependencies could not be resolved: Failed to read artifact de

Re: issue with junit 5 integration

2018-09-05 Thread Christian Stein
So. Initial results are in. Setting only: 3.0 ...leads to the exception Romain reported. Version 1.2.0 of the Platform is resolved. Sorting out the test compile- and runtime dependencies fixes the issue: See https://github.com/apache/meecrowave/pull/11 for details. Now, making Surefire better:

Re: issue with junit 5 integration

2018-09-05 Thread Romain Manni-Bucau
+1 Tibor got a good point noticing that we use scope provided for some junit artifacts which can impact the way the classpath is built. Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Git

Re: issue with junit 5 integration

2018-09-05 Thread Christian Stein
On Wed, Sep 5, 2018 at 10:22 AM Romain Manni-Bucau wrote: > From what I saw in the code the surefire provider artifact is resolved to > ... So, specifying that artifact in your setup (explicit or implicit) will lead to the correct version to be loaded. See the integration tests in Surefire, JUn

Re: issue with junit 5 integration

2018-09-05 Thread Romain Manni-Bucau
>From what I saw in the code the surefire provider artifact is resolved to build the classpath ignoring the project configuration (it is just an artifact resolution) and therefore it ignores the project overrides without my patch. Romain Manni-Bucau @rmannibucau |

Re: issue with junit 5 integration

2018-09-05 Thread Stephane Nicoll
I am more interested to understand what is particular in that project that exhibits an issue we don't seem to be facing. That thread is phrased in such a way that it is a general problem and I'd like a confirmation of that as it may impact Spring Boot (amongst other things) Thanks, S. On Wed, Se

Re: issue with junit 5 integration

2018-09-05 Thread Romain Manni-Bucau
@Stephane: you can clone https://github.com/apache/meecrowave/tree/trunk and change the version in the junit pom ( https://github.com/apache/meecrowave/blob/trunk/meecrowave-junit/pom.xml), it will fail then Romain Manni-Bucau @rmannibucau | Blog

Re: issue with junit 5 integration

2018-09-05 Thread Christian Stein
On Wed, Sep 5, 2018 at 10:07 AM Stephane Nicoll wrote: > How do I reproduce this problem concretely? Having to specify a dependency > in surefire is not an option for us as we want the JUnit5 provider to be > detected automatically. > > I've upgraded a Spring Boot project to use 5.3.0 and I don't

Re: issue with junit 5 integration

2018-09-05 Thread Stephane Nicoll
How do I reproduce this problem concretely? Having to specify a dependency in surefire is not an option for us as we want the JUnit5 provider to be detected automatically. I've upgraded a Spring Boot project to use 5.3.0 and I don't see any problem. Thanks, S. On Tue, Sep 4, 2018 at 10:46 PM Ro

Re: issue with junit 5 integration

2018-09-05 Thread Romain Manni-Bucau
Me too but https://github.com/apache/maven-surefire/blob/d88ce541f3ba78a12422bdfa35c98cfb5783f9ea/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireDependencyResolver.java#L142 only handles a single artifact whereas junit5 relies on N > 1 artifacts for its stack. Romain