Re: issue with junit 5 integration

2018-09-04 Thread Dan Tran
" surefire provider forces 1.2.0" this is not good :-) i thought surefire auto detect first one available in classpath On Tue, Sep 4, 2018 at 11:06 PM Romain Manni-Bucau wrote: > jupiter ;) > > junit 5 is not jupiter but platform+ engine*s* so it must detect the full > stack and not just the de

Re: issue with junit 5 integration

2018-09-04 Thread Romain Manni-Bucau
jupiter ;) junit 5 is not jupiter but platform+ engine*s* so it must detect the full stack and not just the default. A first step can be to detect platform+jupiter+engine but I guess we will get spock, cucumber etc engine quickly so being generic can be worth it. In my case I have vintage-engine -

Re: issue with junit 5 integration

2018-09-04 Thread Dan Tran
Odd, I am under impression surefire auto detect junit-jupiter-engine at runtime am I missing something? -D On Tue, Sep 4, 2018 at 10:08 PM Romain Manni-Bucau wrote: > It does _NOT_ work and as mentionned you can test on meecrowave trying to > upgrade the version in junit module. > > The tes

Re: issue with junit 5 integration

2018-09-04 Thread Romain Manni-Bucau
It does _NOT_ work and as mentionned you can test on meecrowave trying to upgrade the version in junit module. The test classpath build ignores project and plugin dependencies. It faked working until 5.3.0-RC1 cause no breakage was visible. When testing, dont forget to use jupiter, vintage engine

Re: issue with junit 5 integration

2018-09-04 Thread Olivier Lamy
Ok perso I don't mind (it just need to be documented) But the issue is: users are used to simply upgrade their junit dependency. On Wed, 5 Sep 2018 at 07:37, Christian Stein wrote: > No, it works with Surefire 2.22.0 and JUnit 5.3. > > Just add (or move) the test-runtime dependencies to the Sur

Re: issue with junit 5 integration

2018-09-04 Thread Christian Stein
No, it works with Surefire 2.22.0 and JUnit 5.3. Just add (or move) the test-runtime dependencies to the Surefire plugin element: maven-surefire-plugin 2.22.0 org.junit.jupiter junit-j

Re: issue with junit 5 integration

2018-09-04 Thread Olivier Lamy
Hi very embarrassing issue which probably worth a quick release! Can you create a jira? As junit 5.3.0 has just been released, I might be happy to cut 2.22.1 very quickly with only this fix. others wdyt? On Wed, 5 Sep 2018 at 06:46, Romain Manni-Bucau wrote: > Hi guys, > > Jira seems down so s

issue with junit 5 integration

2018-09-04 Thread Romain Manni-Bucau
Hi guys, Jira seems down so sending a mail. I wanted to upgrade Meecrowave to JUnit 5.3 since it is out but I realized the way surefire provider was developped for JUnit 5 was forcing the junit-platform-engine even adding it manually in the test dependencies or plugin dependencies. Side note: I