Re: [VOTE] Release Apache Maven PMD Plugin version 3.10.0

2018-06-01 Thread Olivier Lamy
+1 On Wed, 30 May 2018 at 05:47, Andreas Dangel wrote: > Hi, > > We solved 10 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12342689&styleName=Text&projectId=12317621 > > There are still a couple of issues left in JIRA: > > https://issues.apache.org/jira/issues/?jql=

Re: Maven version order spec weirdness

2018-06-01 Thread Ross Goldberg
If you step through the algorithm from the spec, and if you run the main method from ComparableVersion, you’ll see that the canonical form for 1-0-2 is indeed 1-2. There are places where the code deviates from the spec, for which I’ve filed a bug report, but this is not one of them. Does whoever i

Re: Maven version order spec weirdness

2018-06-01 Thread Robert Scholte
IIRC only digits between dots are interpreted as numbers and will be compared as numbers With dashes values are concatenated as a String and hence will be compared as Strings. So dots and dashes have a different effect. Here you can find a huge number of tests that should cover it: https://ma

Re: Maven version order spec weirdness

2018-06-01 Thread Ross Goldberg
Sorry, I didn’t mean that the spec explicitly states an example that: 1-0-2 = 1-2 > 1-1 I meant that the algorithm described in the spec results in that outcome. ComparableVersion correctly outputs that for the comparison between 1-0-2 & 1-1. Both my original & my revised proposed change to the

Re: Maven version order spec weirdness

2018-06-01 Thread Robert Scholte
On Thu, 31 May 2018 16:22:18 +0200, Ross Goldberg wrote: The maven Maven version order spec ( https://maven.apache.org/pom.html#Version_Order_Specification) indicates that : 1-0-2 is equivalent to 1-2, so 1-0-2 = 1-2 > 1-1. I don't recognize this. Can you quote from that page? Robert T