Re: Surefire roadmap

2018-02-26 Thread Tibor Digana
Hi Enrico, I do not like this test because this may easily be against Java Prog. Lang. Spec. I have no idea why Kristian created like this and allowed testing non-ASCII characters in Java test method and Java test class. Here are Japanese or Chinese characters. The point was to fix https://issues.

Re: [VOTE] Release Apache Maven JDeps Plugin version 3.1.1

2018-02-26 Thread Karl Heinz Marbaise
Hi, here is my +1 after feedback from Robert based on JDK 8 related issues.. Kind regards Karl Heinz Marbaise On 24/02/18 14:38, Robert Scholte wrote: Hi, We solved 6 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319223&version=12341552&styleName=Text There a

Re: Question: JDK 8 (was Re: [VOTE] Release Apache Maven JDeps Plugin version 3.1.1)

2018-02-26 Thread Robert Scholte
multirelease is indeed JDK9+. And I guess the output for package has changed between 8 and 9. I don't consider these blockers, but should be solved before the next release. Robert ps weird, I thought the issues should be solved with the new Jenkins plugins still false positives :( On

Re: Question: JDK 8 (was Re: [VOTE] Release Apache Maven JDeps Plugin version 3.1.1)

2018-02-26 Thread Karl Heinz Marbaise
Hi Robert, Ok...based on my release checker which failed for each JDK 8 build with some errors like this (IT's): * unsupported-api_main/pom.xml * unsupported-api_test/pom.xml ./jdk1.8.0_131.jdk/apache-maven-3.2.5/mvn.log:[ERROR] * multirelease/pom.xml ./jdk1.8.0_131.jdk/apache-maven-3.2.5

Re: Question: JDK 8 (was Re: [VOTE] Release Apache Maven JDeps Plugin version 3.1.1)

2018-02-26 Thread Robert Scholte
Hi Karl Heinz, it should, but I think I have been a bit sloppy: some options are only available with the jdeps of JDK9+[1][2]. invoker.properties should reflect that. Robert [1] https://docs.oracle.com/javase/8/docs/technotes/tools/unix/jdeps.html [2] https://docs.oracle.com/javase/9/tools/j

Question: JDK 8 (was Re: [VOTE] Release Apache Maven JDeps Plugin version 3.1.1)

2018-02-26 Thread Karl Heinz Marbaise
Hi Robert, I'm not sure at the moment but should the maven-jdeps-plugin being able to be build with JDK 8 ? And successfully run all IT's with JDK 8 ? Kind regards Karl Heinz Marbaise On 24/02/18 14:38, Robert Scholte wrote: Hi, We solved 6 issues: https://issues.apache.org/jira/secure/Relea

Re: Surefire roadmap

2018-02-26 Thread Enrico Olivelli
Branch SUREFIRE-1489 works almost fine on my jdk10 / Linux Fedora Only 1 unit test failure ( I think this is addressed in another branch) checkFileNamesWithUnicode(org.apache.maven.surefire.its.UnicodeTestNamesIT) Time elapsed: 0.001 sec <<< FAILURE! junit.framework.AssertionFailedError: Did not