Re: [VOTE] Release Apache Maven Resolver version 1.1.1

2018-02-18 Thread Hervé BOUTEMY
+1 on maven-resolver-1.1.1-source-release.zip -1 on maven-resolver-ant-tasks-1.1.1-source-release.zip: it simply does not work, just build with "-Prun-its" to see it seems there is an issue with shading configuration $ unzip -t target/maven-resolver-ant-tasks-1.1.1-uber.jar | grep antlib.xml

Re: Surefire Jobs

2018-02-18 Thread Olivier Lamy
On 19 February 2018 at 09:20, Tibor Digana wrote: > I am using the lock() in my company. The helper-plugin finds a port but two > jobs on one machine are so predicable that this mechanism would not be > reliable. > It happened to me in my company. The helper may help but it does not > guarantee a

Re: Surefire Jobs

2018-02-18 Thread Tibor Digana
I am using the lock() in my company. The helper-plugin finds a port but two jobs on one machine are so predicable that this mechanism would not be reliable. It happened to me in my company. The helper may help but it does not guarantee anything. There are tests which work but they are not much rel

Re: Surefire Jobs

2018-02-18 Thread Olivier Lamy
what is the issue with helper-plugin? It's supposed to work. can you explain? I would prefer having this fix in the maven build itself rather than depends on some Jenkins extra configuration (make it easier for people to test in their own ci instance) perso I find this build too long in a CI persp

Re: [3/3] maven-surefire git commit: Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on jdk10"

2018-02-18 Thread Olivier Lamy
well maybe ignore this test until it's fixed... Anyway there are some flaky tests which machine dependant and this prevent the build to continue on a ci machine I use https://jenkins.webtide.net/job/sandbox/ java.lang.AssertionError: expected:<1.0> but was:<11335.0> at org.junit.Assert.fail(As

Re: Maven Core / Core IT's - JDK 9

2018-02-18 Thread Karl Heinz Marbaise
Hi, here is the reference to our build server: https://builds.apache.org/view/M-R/view/Maven/job/maven-wip/job/maven/job/MNG-6364/lastCompletedBuild/testReport/org.apache.maven.it/MavenITmng6127PluginExecutionConfigurationInterferenceTest/testCustomMojoExecutionConfigurator/ Kind regards Karl H

Maven Core / Core IT's - JDK 9

2018-02-18 Thread Karl Heinz Marbaise
Hi, based on my testing to build Maven Core / Running IT's with JDK 9 I found a thing which looks weird to me... The following integration test: MavenITmng6127PluginExecutionConfigurationInterferenceTest is currently running fine on JDK 7 and JDK 8 but on JDK 9 it fails... So the test proje

Re: [3/3] maven-surefire git commit: Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on jdk10"

2018-02-18 Thread Tibor Digana
Regarding the unstable integration test, Surefire1295AttributeJvmCrashesToTestsIT, I opened a discussion: https://github.com/michaeltandy/crashjvm/issues/1 Not related to Java 9/10. It was unstable test before as well. On Sun, Feb 18, 2018 at 4:39 PM, Tibor Digana wrote: > Can you tell me how an

Re: The function withMaven() fails after the Maven build has finished in Jenkinsfile

2018-02-18 Thread Tibor Digana
gt; [windows] [INFO] > > ---- > > [windows] [INFO] [jenkins-event-spy] Generated > > > > F:\jenkins\jenkins-slave\workspace\n-wip_maven-surefire_master- > VMXNEFVLKSG4Y4Q25OS6RZDPHGE

Re: The function withMaven() fails after the Maven build has finished in Jenkinsfile

2018-02-18 Thread Stephen Connolly
INFO] [jenkins-event-spy] Generated > > F:\jenkins\jenkins-slave\workspace\n-wip_maven-surefire_master-VMXNEFVLKSG4Y4Q25OS6RZDPHGE56CJURNETLF6TR2V5RXK7KNVQ@tmp > \withMavene898fc1f\maven-spy-20180218-035101-1877982869374894449694.log > [windows] Picked up JAVA_TOOL_OPTIONS: > > -Dmaven.ext.class.path=

Re: Maven Core Build

2018-02-18 Thread Stephen Connolly
Because the plan is to bump min jdk with the version bump to 4.0.0 We have a checklist of things to get out of the way first, from memory: - [ ] Release resolver - [ ] Release 3.5.3 - [ ] Get something that can verify api binary compatibility evolution and integrate into build - [ ] Bump core to

The function withMaven() fails after the Maven build has finished in Jenkinsfile

2018-02-18 Thread Tibor Digana
:\jenkins\jenkins-slave\workspace\n-wip_maven-surefire_master-VMXNEFVLKSG4Y4Q25OS6RZDPHGE56CJURNETLF6TR2V5RXK7KNVQ@tmp \withMavene898fc1f\maven-spy-20180218-035101-1877982869374894449694.log [windows] Picked up JAVA_TOOL_OPTIONS: -Dmaven.ext.class.path="f:\jenkins\jenkins-slave\workspace\n-wip_

Maven Core Upgrade (was: Maven Core Build)

2018-02-18 Thread Karl Heinz Marbaise
Hi Sylwester, On 18/02/18 16:45, Sylwester Lachiewicz wrote: I would also ask, why Core is still build with old maven versions ? :) What do you mean? Currently Maven is build with Maven 3.5.2 / 3.5.0 (On Windows nodes)...I don't see the problem ? imho it would be nice from dev perspective

Re: Maven Core Build

2018-02-18 Thread Sylwester Lachiewicz
I would also ask, why Core is still build with old maven versions ? :) imho it would be nice from dev perspective to require Java 8 to build maven core (keep jdk level for source/target at 7 and still enforce this with maven-enforcer) and Maven 3.5.2. From Ops perspective, there will be less build

Re: [3/3] maven-surefire git commit: Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on jdk10"

2018-02-18 Thread Tibor Digana
Can you tell me how and where you reproduced this stacktrace? Regarding the hack in *surefire-booter* I understand what happened and why today the hack is not needed and why it does not cause any problem if I remove it from the POM. This happened because two related issues were fixed in November a

Re: Surefire Jobs

2018-02-18 Thread Tibor Digana
I forgot to say that those 4 ITs in m-failsafe-p take 30 seconds only, so no big resource exh. And using timeout would prevent from long waiting. On Sun, Feb 18, 2018 at 3:22 PM, Tibor Digana wrote: > No reason. > One job always took 1 hour. You do not have to. > We are working on a release. If

Re: Surefire Jobs

2018-02-18 Thread Tibor Digana
No reason. One job always took 1 hour. You do not have to. We are working on a release. If you commit anything to master I can start from the begin. After the release I will use parallel execution but I could not because Gavin from our INFRA team installed latest Pipeline Advanced Utilities few hou

Re: Maven Core Build

2018-02-18 Thread Karl Heinz Marbaise
Hi, On 18/02/18 15:13, Karl Heinz Marbaise wrote: Hi, I've stumbled over a thing .. why is Maven Core not build with JDK 9 as well as JDK 7, 8 ? I have taken a look into Jenkinsfile and there is not implementation for that... I would suggest that it should be added ...(I can do ..) So tr

Re: Surefire Jobs

2018-02-18 Thread Karl Heinz Marbaise
Hi Tibor, On 18/02/18 15:13, Tibor Digana wrote: no, no Please do not do it! I would have at least waited for a feedback before I kill a Job ;-)... We are waiting for them. They are expected to run 12 hours. Wow that long..I wasn't aware of that... You can compute it: 1 hour each run co

Re: Surefire Jobs

2018-02-18 Thread Tibor Digana
no, no Please do not do it! We are waiting for them. They are expected to run 12 hours. You can compute it: 1 hour each run configuration. Number of configuration is 3 Maven config * 4 JDKs. I tried to run them in parallel but they appeared several in one executor. Maybe later as parallel but now

Maven Core Build

2018-02-18 Thread Karl Heinz Marbaise
Hi, I've stumbled over a thing .. why is Maven Core not build with JDK 9 as well as JDK 7, 8 ? I have taken a look into Jenkinsfile and there is not implementation for that... I would suggest that it should be added ...(I can do ..) cause our plugins etc. are tested with the build against J

Re: Surefire Jobs

2018-02-18 Thread Karl Heinz Marbaise
Hi, On 18/02/18 14:51, Karl Heinz Marbaise wrote: Hi, it seemed to me that there are Surefire Jobs stuck ..for 10 hours or more... I would like to abort them ? Seemed to be gone already... Kind regards Karl Heinz Marbaise Kind regards Karl Heinz Marbaise -

Surefire Jobs

2018-02-18 Thread Karl Heinz Marbaise
Hi, it seemed to me that there are Surefire Jobs stuck ..for 10 hours or more... I would like to abort them ? Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands,

Old Style Build Jobs

2018-02-18 Thread Karl Heinz Marbaise
Hi, It seemed I have missed to mention: 1. https://builds.apache.org/view/M-R/view/Maven/job/maven-3.x-j9 cause this is already covered by our https://builds.apache.org/view/M-R/view/Maven/job/maven-wip/job/maven/.. I will delete that job on 21. Feburary if there are no objections... Kind

Re: [VOTE] Release Apache Maven Resolver version 1.1.1

2018-02-18 Thread Karl Heinz Marbaise
+1 from me... Kind regards Karl Heinz Marbaise On 15/02/18 20:25, Robert Scholte wrote: Hi, We solved 3 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12341378&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.or

Re: [VOTE] Release Apache Maven Resolver version 1.1.1

2018-02-18 Thread Robert Scholte
+1 On Thu, 15 Feb 2018 20:25:31 +0100, Robert Scholte wrote: Hi, We solved 3 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12341378&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=projec

Re: [3/3] maven-surefire git commit: Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on jdk10"

2018-02-18 Thread Tibor Digana
Olivier, I check the Major Version of Java in bytecode of the following libraries and all which contain shaded commons-lang3 are from version 3..5 because they have code 0x32 which is Java 1.6. https://en.wikipedia.org/wiki/Java_class_file This means we must have a problem with JDK or the use cas

Re: [3/3] maven-surefire git commit: Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on jdk10"

2018-02-18 Thread Tibor Digana
We must have something different. For instance this is my java -version: openjdk version "10-ea" 2018-03-20 OpenJDK Runtime Environment 18.3 (build 10-ea+39) OpenJDK 64-Bit Server VM 18.3 (build 10-ea+39, mixed mode) The unit test prints Java Home like this: D:\Program Files\Java\jdk10 [INFO] Te

Re: [3/3] maven-surefire git commit: Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on jdk10"

2018-02-18 Thread Tibor Digana
commons-lang3:3.7 is used in internal tests only, because some tests are only related to Java 9+, but it has nothing to do with plugin itself. The plugin shades (re-packages) to another package with lang3:3.5. The PpidChecker is using it but it does not use the field IS_JAVA_9. It uses IS_OS_UNIX e

Re: [3/3] maven-surefire git commit: Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on jdk10"

2018-02-18 Thread Olivier Lamy
There is definitely something I don't understand with this configuration: maven-surefire-plugin org.apache.maven.surefire surefire-shadefire 2.12.4 org.apache.commons commons-lang3 3.7 **/JUnit4SuiteTest.java

Re: [3/3] maven-surefire git commit: Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on jdk10"

2018-02-18 Thread Tibor Digana
Let me just check it out in a project. On Sun, Feb 18, 2018 at 4:58 AM, Olivier Lamy wrote: > locally > > mvn clean install > -Djdk.home=/Library/Java/JavaVirtualMachines/jdk-10.jdk/Contents/Home > -Djacoco.skip=true > > Caused by: java.lang.ClassNotFoundException: > org.apache.commons.lang3.Sy