Re: [3/3] maven-surefire git commit: Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on jdk10"

2018-02-17 Thread Olivier Lamy
locally mvn clean install -Djdk.home=/Library/Java/JavaVirtualMachines/jdk-10.jdk/Contents/Home -Djacoco.skip=true Caused by: java.lang.ClassNotFoundException: org.apache.commons.lang3.SystemUtils at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:466) at java.base/java.lang.Cl

Re: [3/3] maven-surefire git commit: Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on jdk10"

2018-02-17 Thread Tibor Digana
The Jenkins CI was shutdown for several hours. So the HEAD was not taken. I can trigger the build manually. Cheers Tibor On Sun, Feb 18, 2018 at 4:39 AM, Tibor Digana wrote: > I will explain again everything. > Do not worry, please. > > The build won't fail if you use -Djdk.home=/path/to/jdk. W

Re: [3/3] maven-surefire git commit: Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on jdk10"

2018-02-17 Thread Tibor Digana
I will explain again everything. Do not worry, please. The build won't fail if you use -Djdk.home=/path/to/jdk. We don't have to force the users to change JDK if they are fine with 1.6. The library commons-lang3:3.7 was especially needed during our testing but not in the main code, therefore Java

Re: [3/3] maven-surefire git commit: Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on jdk10"

2018-02-17 Thread Olivier Lamy
and now master fail again with jdk10... Why are you reverting my changes? As said in an email I wanted to have something working with jdk10. So please first discuss on the email thread if you are not happy with my changes... On 18 February 2018 at 10:36, wrote: > Revert "[SUREFIRE-1473] upgrade

Re: [2/3] maven-surefire git commit: Revert "[SUREFIRE-1474] 1.7 as minimum"

2018-02-17 Thread Olivier Lamy
why? I started a discussion a discussion on mailing list and all answers were ok. On 18 February 2018 at 10:36, wrote: > Revert "[SUREFIRE-1474] 1.7 as minimum" > > This reverts commit ee1cc441b740f9802d9fe40b10b485e2058c06bc. > > > Project: http://git-wip-us.apache.org/repos/asf/maven-surefire/

Re: [1/3] maven-surefire git commit: Revert "add a jdk10 profile to not run jacoco as it does not work yet for jdk10"

2018-02-17 Thread Olivier Lamy
why? On 18 February 2018 at 10:36, wrote: > Repository: maven-surefire > Updated Branches: > refs/heads/master 4ec99792c -> 5e732c6b2 > > > Revert "add a jdk10 profile to not run jacoco as it does not work yet for > jdk10" > > This reverts commit 4ec99792c93efd3b2a6d3b8dcb2589fe6d37973f. > > >

Re: report plugin with jdk10

2018-02-17 Thread Tibor Digana
The distribution [1] of Surefire 2.21.0 is available in our Staging server. I am currently building the site with test reports... [1]: https://repository.apache.org/content/repositories/maven-1396/ Cheers Tibor On Sun, Feb 18, 2018 at 4:03 AM, Tibor Digana wrote: > Hi Olivier, > > Please make

Re: report plugin with jdk10

2018-02-17 Thread Tibor Digana
Hi Olivier, Please make additional testing on Monday. If you find an urgent bug we can always restart the Vote. I hope it will be just fine and we will finish our release before the Java 10 release. Cheers Tibor On Sun, Feb 18, 2018 at 1:25 AM, Tibor Digana wrote: > Olivier, your javac setti

Re: Maven 3.5.3 - MNG-6352

2018-02-17 Thread Hervé BOUTEMY
+1 Regards, Hervé Le samedi 17 février 2018, 13:20:47 CET Karl Heinz Marbaise a écrit : > Hi, > > I would like to suggest to pick MNG-6352[1] > for Maven 3.5.3 .. > > just printout the versions in the results. > > > Kind regards > Karl Heinz Marbaise > > > [1]: https://issues.apache.org/ji

Re: Question: Re: [VOTE] Release Apache Maven Resolver version 1.1.1

2018-02-17 Thread Hervé BOUTEMY
Le samedi 17 février 2018, 18:15:53 CET Karl Heinz Marbaise a écrit : > Hi, > > On 17/02/18 18:09, Hervé BOUTEMY wrote: > > Le samedi 17 février 2018, 14:34:51 CET Karl Heinz Marbaise a écrit : > >> Hi, > >> > >> do I understand correctly that the Maven Resolver is only valid for > >> Maven 3.5.2

Re: report plugin with jdk10

2018-02-17 Thread Tibor Digana
Olivier, your javac settings is ok but it would be more useful in Surefire 3.0.0. Don't worry, we will not loose your code. I assigned your JIRA issue to 3.0 first release candidate. The reason behind is the fact that it is not good for users for change prerequisite for the plugin too often. Second

Re: [VOTE] Release Apache Maven Resolver version 1.1.1

2018-02-17 Thread Hervé BOUTEMY
I'm not sure releasing Maven Resolver Ant Tasks in the same time as Maven Resolver is ideal: MR Ant Tasks 1.1.1 depends on Maven core artifacts version 3.5.0 (maven- resolver-provider and its dependencies) and Maven Resolver 1.1.1 But Maven core 3.5.0 depends on Maven Resolver 1.0.3 Maven Resolve

Re: Question: Re: [VOTE] Release Apache Maven Resolver version 1.1.1

2018-02-17 Thread Karl Heinz Marbaise
Hi, On 17/02/18 18:09, Hervé BOUTEMY wrote: Le samedi 17 février 2018, 14:34:51 CET Karl Heinz Marbaise a écrit : Hi, do I understand correctly that the Maven Resolver is only valid for Maven 3.5.2+ ? Or is there a reason why the Maven Artifact Resolver Demo Maven Plugin only works or 3.5.2+

Re: Question: Re: [VOTE] Release Apache Maven Resolver version 1.1.1

2018-02-17 Thread Hervé BOUTEMY
Le samedi 17 février 2018, 14:34:51 CET Karl Heinz Marbaise a écrit : > Hi, > > do I understand correctly that the Maven Resolver is only valid for > Maven 3.5.2+ ? > > Or is there a reason why the Maven Artifact Resolver Demo Maven Plugin > only works or 3.5.2+ ? what makes you tell that? Rega

[GitHub] maven pull request #156: Remove Google Guava usage (move to Java7)

2018-02-17 Thread slachiewicz
Github user slachiewicz closed the pull request at: https://github.com/apache/maven/pull/156 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

Question: Re: [VOTE] Release Apache Maven Resolver version 1.1.1

2018-02-17 Thread Karl Heinz Marbaise
Hi, do I understand correctly that the Maven Resolver is only valid for Maven 3.5.2+ ? Or is there a reason why the Maven Artifact Resolver Demo Maven Plugin only works or 3.5.2+ ? Kind regards Karl Heinz Marbaise - To un

Maven 3.5.3 - MNG-6352

2018-02-17 Thread Karl Heinz Marbaise
Hi, I would like to suggest to pick MNG-6352[1] for Maven 3.5.3 .. just printout the versions in the results. Kind regards Karl Heinz Marbaise [1]: https://issues.apache.org/jira/browse/MNG-6352 - To unsubscribe, e-mail: de

Re: report plugin with jdk10

2018-02-17 Thread Tibor Digana
Ok, we can make additional testing by then. I have another question to our shared Groovy library [1]. I am missing configuration with Maven 3.1.x. Is there any problem with this version why we did not add it? Our Surefire build works fine with Maven 3.1.1 but of course I tested this combination on

Re: report plugin with jdk10

2018-02-17 Thread Olivier Lamy
maybe give a bit of time to test master branch I should be able to do some testing by monday On 17 February 2018 at 21:50, Tibor Digana wrote: > I do not see any issues with the Jenkins run at the moment. > Most probably the build would be successful. > The build should finish around 11pm today.

Re: report plugin with jdk10

2018-02-17 Thread Tibor Digana
I do not see any issues with the Jenkins run at the moment. Most probably the build would be successful. The build should finish around 11pm today. Then I would like to merge the branch to master and start the release vote right after. The distribution artifacts would be already deployed in Maven C

Re: report plugin with jdk10

2018-02-17 Thread Olivier Lamy
On 17 February 2018 at 19:44, Tibor Digana wrote: > I am currently running the CI job #129 of Surefire with JDK 7, 8, 9, 10, > Maven 3.2, 3.3, 3.5, Linux and Windows: > This is the link to pipeline > https://builds.apache.org/job/maven-wip/job/maven-surefire/ > job/SUREFIRE-1463/ > > The old job

Re: report plugin with jdk10

2018-02-17 Thread Tibor Digana
I am currently running the CI job #129 of Surefire with JDK 7, 8, 9, 10, Maven 3.2, 3.3, 3.5, Linux and Windows: This is the link to pipeline https://builds.apache.org/job/maven-wip/job/maven-surefire/job/SUREFIRE-1463/ The old job #128 passed the most of the Linux builds. My last push -f crashed