Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

2017-09-11 Thread Dan Tran
Is there a snapshot i can test with my production? only see 2.21-SNAPSHOT Thanks -Dan On Mon, Sep 11, 2017 at 5:05 AM, Enrico Olivelli wrote: > +1 (non binding) > > run unit tests on surefire project itself > > on JDK 9+181 run unit tests of other Java8 projects which required > java.se.ee mo

Re: [VOTE] Release Apache Maven JLink Plugin version 3.0.0-alpha-1 (First Public Release)

2017-09-11 Thread Hervé BOUTEMY
+1 (to the vote and the comments :) ) Regards, Hervé Le lundi 11 septembre 2017, 21:12:35 CEST Robert Scholte a écrit : > +1 for an alpha > > would be nice if there were ITs so see what would be the result. > > thanks, > Robert > > On Sat, 09 Sep 2017 16:19:52 +0200, Karl Heinz Marbaise > >

Re: [VOTE] Release Apache Maven Dependency Plugin version 3.0.2

2017-09-11 Thread Hervé BOUTEMY
+1 Regards, Hervé Le samedi 9 septembre 2017, 14:34:49 CEST Karl Heinz Marbaise a écrit : > Hi, > > We solved 7 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317227&ve > rsion=12341254 > > There are still a couple of issues left in JIRA: > https://issues.apache.o

[GitHub] maven issue #129: [MNG-6282] jansi downgraded from 1.16 to 1.15 in order to ...

2017-09-11 Thread dejan2609
Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/129 Closed as per conversation with @hboutemy on JIRA, see this [comment](https://issues.apache.org/jira/browse/MNG-6282?focusedCommentId=16161977&page=com.atlassian.jira.plugin.system.issuetabpanels:com

[GitHub] maven pull request #129: [MNG-6282] jansi downgraded from 1.16 to 1.15 in or...

2017-09-11 Thread dejan2609
Github user dejan2609 closed the pull request at: https://github.com/apache/maven/pull/129 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven 3.5.1

2017-09-11 Thread Hervé BOUTEMY
just for the records: it is Windows + Git Bash (MINGW64) only and there is a chance that adding -Djansi.force=true can force JAnsi activation (even if JAnsi fails to detect that it should auto-activate) details on issue in https://issues.apache.org/jira/browse/MNG-6282 , and a future JAnsi issu

Re: [VOTE] Release Apache Maven 3.5.1

2017-09-11 Thread Robert Scholte
+1 On Sun, 10 Sep 2017 17:39:12 +0200, Stephen Connolly wrote: Hi, We solved 25 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12338964&styleName=Text&projectId=12316922 There are 350 issues left in JIRA for Maven core: https://issues.apache.org/jira/issues/?jql=pr

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-09-11 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 I'll try to address the minor changes soontm. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For addit

[GitHub] maven-surefire pull request #150: SUREFIRE-1372 Filter tests to be rerun by ...

2017-09-11 Thread mpkorstanje
Github user mpkorstanje commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/150#discussion_r138170535 --- Diff: surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/MatchMethodDescriptions.java --- @@ -0,0 +1,7

Re: [VOTE] Release Apache Maven JLink Plugin version 3.0.0-alpha-1 (First Public Release)

2017-09-11 Thread Robert Scholte
+1 for an alpha would be nice if there were ITs so see what would be the result. thanks, Robert On Sat, 09 Sep 2017 16:19:52 +0200, Karl Heinz Marbaise wrote: Hi, this is the VOTE for the first public release for Maven JLink Plugin... We solved 1 issues: https://issues.apache.org/jira/s

Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release)

2017-09-11 Thread Robert Scholte
Hi, isn't it weird that jmod:create has parameters for classpath and modulepath? why not start using the dependencies as specified in the pom? and the plugin shouldn't use artifactId as default for the modulename. Current best practice is to include the packagename as namespace. And if the mo

[GitHub] maven pull request #129: [MNG-6282] jansi downgraded from 1.16 to 1.15 in or...

2017-09-11 Thread dejan2609
GitHub user dejan2609 opened a pull request: https://github.com/apache/maven/pull/129 [MNG-6282] jansi downgraded from 1.16 to 1.15 in order to solve issues s on Windows/GitBash JIRA ticket: https://issues.apache.org/jira/browse/MNG-6282 You can merge this pull request into a

Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release)

2017-09-11 Thread Karl Heinz Marbaise
Hi, here is my +1, Kind Regards Karl Heinz Marbaise On 09/09/17 15:52, Karl Heinz Marbaise wrote: Hi, this is the VOTE for the first public release for Maven JMod Plugin... We solved 1 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&version=12341363 There

Re: [VOTE] Release Apache Maven JLink Plugin version 3.0.0-alpha-1 (First Public Release)

2017-09-11 Thread Karl Heinz Marbaise
Hi, here is my +1 Kind regards Karl Heinz Marbaise On 09/09/17 16:19, Karl Heinz Marbaise wrote: Hi, this is the VOTE for the first public release for Maven JLink Plugin... We solved 1 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321432&version=12341361 Ther

Apache Maven BOF

2017-09-11 Thread Robert Scholte
Hi, I've started the preparations for the BOF session at JavaOne this year. Time and location have been set: Tuesday, Oct 03, 7:45 p.m. - 8:30 p.m. | Moscone West - Room 2007[1] I'll be there together with Brian and Manfred. I've also received the confirmation the do the same session at Devoxx

Re: [VOTE] Release Apache Maven 3.5.1

2017-09-11 Thread Robert Scholte
Nice fix On Mon, 11 Sep 2017 11:31:34 +0200, Stephen Connolly wrote: http://git-wip-us.apache.org/repos/asf/maven/diff/542a7a89 to defang the test going forward, with that change on Azul's Zulu JDK 7 I get: Linux ddf0318b698b 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64 x86_64 x86

[GitHub] maven-enforcer pull request #28: [MENFORCER-281] added IT to show the issue.

2017-09-11 Thread jtnord
GitHub user jtnord opened a pull request: https://github.com/apache/maven-enforcer/pull/28 [MENFORCER-281] added IT to show the issue. Added an IT to demonstrate [MENFORCER-281](https://issues.apache.org/jira/browse/MENFORCER-281) Fails with the following which is slightly

Re: [VOTE] Release Apache Maven 3.5.1

2017-09-11 Thread Stephane Nicoll
+1 S. On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Hi, > > We solved 25 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > version=12338964&styleName=Text&projectId=12316922 > > There are 350 issues left in JIRA for Maven core: >

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

2017-09-11 Thread Enrico Olivelli
+1 (non binding) run unit tests on surefire project itself on JDK 9+181 run unit tests of other Java8 projects which required java.se.ee module to be present Thank you ! Enrico 2017-09-11 5:33 GMT+02:00 Tibor Digana : > Hi, > > We solved 24 issues: > https://issues.apache.org/jira/secure/Re

Re: [VOTE] Release Apache Maven 3.5.1

2017-09-11 Thread Stephen Connolly
So that is windows only, or were they lost on other OSes for you. I have colours on linux (via docker) and os-x On 11 September 2017 at 12:35, dejan2...@gmail.com wrote: > +1 (conditionally). > > Tested via project that includes dozen of plugins: 1st tier, MojoHaus and > few 3rd party plugins (

Re: [VOTE] Release Apache Maven 3.5.1

2017-09-11 Thread dejan2...@gmail.com
+1 (conditionally). Tested via project that includes dozen of plugins: 1st tier, MojoHaus and few 3rd party plugins (so to say). Everything looks good with one notable regression: https://issues.apache.org/jira/browse/MNG-6282 Console output has no colors (regression in Maven 3.5.1) Regards,

Re: [VOTE] Release Apache Maven 3.5.1

2017-09-11 Thread Mark Derricutt
On 11 Sep 2017, at 18:10, Stephen Connolly wrote: > I wonder if mng-6275 is affecting that plugin Didn't manage to get a chance to look into this tonight :( Tho that ticket mentions nashorn, phantonjs is a C/native headless browser library, so it doesn't feel like it could be related. If there

Re: Tests for MNG-6275 fail on Java 1.7.0_151-b01

2017-09-11 Thread Stephen Connolly
Tibor, yes, but with Java 8 the class loader that has the script engine changed, which is what MNG-6275 is all about... the failing tests are because Zulu JDK 7 doesn't have any script engine in the boot classpath and the test (as originally written) assumes there is at least one On 11 September 2

Re: Tests for MNG-6275 fail on Java 1.7.0_151-b01

2017-09-11 Thread Tibor Digana
ServiceLoader in Java takes System ClassLoader by default. On Mon, Sep 11, 2017 at 11:41 AM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > https://github.com/apache/maven/commit/542a7a89156263b34d1472e9d9c1a2 > 795afccd2d > > If the JRE does not have a ScriptEngineFactory then the

Re: Tests for MNG-6275 fail on Java 1.7.0_151-b01

2017-09-11 Thread Stephen Connolly
https://github.com/apache/maven/commit/542a7a89156263b34d1472e9d9c1a2795afccd2d If the JRE does not have a ScriptEngineFactory then the test cannot pass as it relies on the assumption (invalid for Java 7) that there is always a ScriptEngineFactory available. You can use this small class to check

Re: [VOTE] Release Apache Maven 3.5.1

2017-09-11 Thread Stephen Connolly
http://git-wip-us.apache.org/repos/asf/maven/diff/542a7a89 to defang the test going forward, with that change on Azul's Zulu JDK 7 I get: Linux ddf0318b698b 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3; 2

[GitHub] maven-surefire issue #141: SUREFIRE-1331: Bump version number for 3.0.0 rele...

2017-09-11 Thread KroArtem
Github user KroArtem commented on the issue: https://github.com/apache/maven-surefire/pull/141 Not sure about 3.0 stuff but 2.20.1 with last fixes is highly forthcoming. 😃 --- - To unsubscribe, e-mail: dev-unsub

[GitHub] maven-surefire pull request #143: maven-surefire-parser: add new method isEr...

2017-09-11 Thread surli
Github user surli commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/143#discussion_r138015510 --- Diff: surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/ReportTestCase.java --- @@ -156,6 +158,15 @@ public boolean ha

Re: [VOTE] Release Apache Maven 3.5.1

2017-09-11 Thread Stephen Connolly
So Azul's Zulu 7 does not have com.sun.script.javascript.RhinoScriptEngineFactory or any ScriptEngineFactory in the base classloader... Zulu 8 has jdk.nashorn.api.scripting.NashornScriptEngineFactory So at this point in time, my analysis is that the DefaultClassRealmManagerTest is not a valid te

Re: [VOTE] Release Apache Maven 3.5.1

2017-09-11 Thread Stephen Connolly
With https://github.com/apache/maven-integration-testing/commit/a08d65bfb5fedec9f684c13bf5a0dccb96f5cc56 I was able to get Michael's test failures: Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3; 2017-09-10T12:42:54Z) Maven home: /work/bin Java version: 1.7.0_154, vendor: Azul System

[GitHub] maven-surefire pull request #143: maven-surefire-parser: add new method isEr...

2017-09-11 Thread surli
Github user surli commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/143#discussion_r138012247 --- Diff: surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java --- @@ -196,7 +196,8 @@ else if ( "fai

Re: [VOTE] Release Apache Maven 3.5.1

2017-09-11 Thread Stephen Connolly
Building the source bundles with the binary bundles in the staging repo using the Dockerfile environments in https://github.com/apache/maven-integration-testing/tree/master/environments Debian JDK 7 === Linux 65fb832dfe43 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64 GNU/Linux Apa

[GitHub] maven-surefire issue #143: maven-surefire-parser: add new method isError in ...

2017-09-11 Thread surli
Github user surli commented on the issue: https://github.com/apache/maven-surefire/pull/143 Hi @Tibor17 sorry I missed your previous review, I'll make changes in the coming days and open the issue on JIRA --- - To u

Re: [VOTE] Release Apache Maven 3.5.1

2017-09-11 Thread Dan Tran
False alarm, I missed configure global settings.xml, it is missing the default repository setup -D On Sun, Sep 10, 2017 at 11:47 PM, Tibor Digana wrote: > +1: > 3.5.1 works in my project like a charm ;-) > > On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly < > stephen.alan.conno...@gmail.com>