Re: main-class + module-version

2017-08-22 Thread Plamen Totev
On Tue, Aug 22, 2017 at 11:03 PM, Robert Scholte wrote: > > > The maven-shade-plugin has the ability to re-package a jar and manipulate any > type of file, including class files. The best example is relocation, where > you give a set of classes a different package to prevent potential class > c

Re: main-class + module-version

2017-08-22 Thread Chas Honton
Jar plugin is used more often than shade plugin. (I dis-recommend shade since provenance of classes is difficult or impossible to trace.). If module version is required to make jar useful, then jar plugin appears more appropriate. Chas > On Aug 22, 2017, at 6:10 PM, Olivier Lamy wrote: > > +

Re: main-class + module-version

2017-08-22 Thread Olivier Lamy
+1 for shade plugin looks to be the most appropriate location to do this. On 23 August 2017 at 06:03, Robert Scholte wrote: > On Tue, 22 Aug 2017 21:23:10 +0200, Plamen Totev < > plamen.iv.to...@gmail.com> wrote: > > Hi, >> >> I've experimented with Maven and Java 9 the last weekend and actually

[ANN] Apache Maven Shade Plugin 3.1.0 Released

2017-08-22 Thread Robert Scholte
The Apache Maven team is pleased to announce the release of the Apache Maven Shade Plugin, version 3.1.0 This plugin provides the capability to package the artifact in an uber-jar, including its dependencies and to shade - i.e. rename - the packages of some of the dependencies. https://ma

Re: main-class + module-version

2017-08-22 Thread Robert Scholte
On Tue, 22 Aug 2017 21:23:10 +0200, Plamen Totev wrote: Hi, I've experimented with Maven and Java 9 the last weekend and actually one of the things I noticed is that currently I could not set the module version. I do agree that the packaging should be stupid action and the module-info trans

Re: [VOTE] Release Apache Maven Shade Plugin version 3.1.0

2017-08-22 Thread Robert Scholte
Hi, The vote has passed with the following result: +1 : Karl Heinz Marbaise, Evgeny Mandrikov, Hervé BOUTEMY, Robert Scholte, Stephane Nicoll PMC quorum: reached I will promote the artifacts to the central repo. On Sat, 19 Aug 2017 16:01:23 +0200, Robert Scholte wrote: Hi, We solve

Re: main-class + module-version

2017-08-22 Thread Plamen Totev
Hi, I've experimented with Maven and Java 9 the last weekend and actually one of the things I noticed is that currently I could not set the module version. I do agree that the packaging should be stupid action and the module-info transformation should happen before that. But I'm not sure why the

Re: [VOTE] Release Apache Maven Shade Plugin version 3.1.0

2017-08-22 Thread Stephane Nicoll
+1 On Sat, 19 Aug 2017 at 16:01, Robert Scholte wrote: > Hi, > > We solved 6 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&version=12339197&styleName=Text > > There are still a couple of issues left in JIRA: > > https://issues.apache.org/jira/issues/?jql

main-class + module-version

2017-08-22 Thread Robert Scholte
Hi, The JDK 9 jar packager comes with 2 extra options: main-class and module-version. The first one is used in case of an executable modular jar, the latter is just for display/analysis to show which version of a specific module is used. To support these 2 values, the module-info.class must

Re: [VOTE] Release Apache Maven Shade Plugin version 3.1.0

2017-08-22 Thread Robert Scholte
+1 On Sat, 19 Aug 2017 16:01:23 +0200, Robert Scholte wrote: Hi, We solved 6 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&version=12339197&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=projec