[GitHub] maven-surefire pull request #155: Revert junit-plattform provider code from ...

2017-06-11 Thread britter
GitHub user britter opened a pull request: https://github.com/apache/maven-surefire/pull/155 Revert junit-plattform provider code from 3.0-rc1 branch. This code will be moved to the junit5 branch. This commit reverts: - Commit 70c8843e935882b0a78916894cb9f042964f2717 "

[GitHub] maven-surefire pull request #154: Move junit5 provider code

2017-06-11 Thread britter
GitHub user britter opened a pull request: https://github.com/apache/maven-surefire/pull/154 Move junit5 provider code Move the junit5/junit-plattform provider code to the junit5 branch. I used `git cherry-pick 73e09a8b^..70c8843e` to do this. You can merge this pull request into a

[GitHub] maven-surefire issue #153: SUREFIRE-1384: ProviderInfo for JUnit Plattform (...

2017-06-11 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/153 @Tibor17 thank you for your review. Have you seen my question? I'm having problems running the IT. Is this related to the 3.0-rc1 branch? --- If your project is set up for it, you can reply

[GitHub] maven-surefire pull request #153: SUREFIRE-1384: ProviderInfo for JUnit Plat...

2017-06-11 Thread britter
Github user britter commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/153#discussion_r121315310 --- Diff: surefire-integration-tests/src/test/resources/junit-plattform/pom.xml --- @@ -0,0 +1,58 @@ + + + +http://maven.apache.org/P

[GitHub] maven-surefire pull request #153: SUREFIRE-1384: ProviderInfo for JUnit Plat...

2017-06-11 Thread britter
Github user britter commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/153#discussion_r121315282 --- Diff: surefire-integration-tests/src/test/resources/junit-plattform/src/test/java/junitplattform/BasicTest.java --- @@ -0,0 +1,65 @@ +packag

Re: [SUREFIRE] JUnit 5 support - current state and next steps

2017-06-11 Thread Benedikt Ritter
Hello Tibor, thank you for sharing your thoughts and thank you for the review. > Am 10.06.2017 um 12:48 schrieb Tibor Digana : > > Both branches are messy. > 3.0-rc1 is pretty old and not working properly because one IT fails. > I wanted to continue on 3.0 two years ago but could not because the

[GitHub] maven issue #123: [MNG-6207] display deprecation build warning for dependenc...

2017-06-11 Thread dejan2609
Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/123 Just on more thing that recalled from my memory: I did tried to execute tests (http://maven.apache.org/core-its/core-it-suite) like this: `mvn clean test -Prun-its` but I received warning that prof

[GitHub] maven pull request #123: [MNG-6207] display deprecation build warning for de...

2017-06-11 Thread dejan2609
Github user dejan2609 closed the pull request at: https://github.com/apache/maven/pull/123 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] maven issue #123: [MNG-6207] display deprecation build warning for dependenc...

2017-06-11 Thread dejan2609
Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/123 Just for the record: somehow it slipped of my mind that `package` phase doesn't execute integration tests (http://maven.apache.org/ref/3.5.0/maven-core/lifecycles.html#default_Lifecycle) and hence

Re: maven-compiler-plugin + default-value for illegal-access

2017-06-11 Thread Robert Scholte
Interesting, based on the output of "java -X" and "javac -X" you're right. Kind of a surprise to me, but in that case this is not an issue for the maven-compiler-plugin Robert On Sat, 10 Jun 2017 23:54:32 +0200, Guillaume Boué wrote: Wouldn't illegal-access be a run-time 'java' flag only

[GitHub] maven issue #112: Fix snapshot regular expression

2017-06-11 Thread khmarbaise
Github user khmarbaise commented on the issue: https://github.com/apache/maven/pull/112 If you like to get your pull request being integrated it is required to open an [issue on jira](https://issues.apache.org/jira/browse/MNG) and change your commit message accordingly. Something like

[GitHub] maven issue #123: [MNG-6207] display deprecation build warning for dependenc...

2017-06-11 Thread khmarbaise
Github user khmarbaise commented on the issue: https://github.com/apache/maven/pull/123 Second build after fixing the checkstyle issues has worked. Integration into master done. You can close the pull request. Thank for your help to make Maven better. --- If your project is set up f

[GitHub] maven issue #123: [MNG-6207] display deprecation build warning for dependenc...

2017-06-11 Thread khmarbaise
Github user khmarbaise commented on the issue: https://github.com/apache/maven/pull/123 First build has failed based on [violated checkstyle rules](https://builds.apache.org/view/M-R/view/Maven/job/maven-3.x-jenkinsfile/job/MNG-6207/1/console). So best is before you open a pull reques

Maven Shared Utils

2017-06-11 Thread Karl Heinz Marbaise
Hi, currently there are 11 issues solved in the component... If there isn't something which currently blocks a release of this component I would like to start a release of maven-shared-utils-3.2.0 on Tuesday of no one objects here? Kind regards Karl Heinz Marbaise ---

Re: [MNG-6164] Collections inconsistently immutable

2017-06-11 Thread Michael Osipov
Am 2017-05-28 um 20:55 schrieb Hervé BOUTEMY: Le dimanche 28 mai 2017, 19:50:03 CEST Michael Osipov a écrit : How many cases are changed? In which areas of Maven API? That is the information I need to vote for this change, knowing the effective impact it will have As far as I can see for the c