Re: [ANN] First call to round up issues for 3.5.1

2017-06-10 Thread Karl Heinz Marbaise
Hi Guillaume, +1 from me... for that fix.. Kind regards Karl Heinz Marbaise On 11/06/17 00:05, Guillaume Boué wrote: Hi, I'd like to propose MNG-6240 to be added in 3.5.1. Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/e76e217a IT: http://git-wip-us.apache.org/repos/asf/maven-i

Re: [ANN] First call to round up issues for 3.5.1

2017-06-10 Thread Guillaume Boué
Hi, I'd like to propose MNG-6240 to be added in 3.5.1. Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/e76e217a IT: http://git-wip-us.apache.org/repos/asf/maven-integration-testing/commit/a162291e Successful Jenkins build: https://builds.apache.org/job/maven-3.x-jenkinsfile/job/MNG-6

Re: maven-compiler-plugin + default-value for illegal-access

2017-06-10 Thread Guillaume Boué
Wouldn't illegal-access be a run-time 'java' flag only, and not a compile-time 'javac' one? Le 10/06/2017 à 19:46, Robert Scholte a écrit : Hi all, below is the proposal for the flag "illegal-access" in Java 9. TLDR; it controls if the compiler should break the build when making illegal usage

maven-compiler-plugin + default-value for illegal-access (was: Proposal (revised): Allow illegal access to internal APIs by default in JDK 9)

2017-06-10 Thread Robert Scholte
Hi all, below is the proposal for the flag "illegal-access" in Java 9. TLDR; it controls if the compiler should break the build when making illegal usage of internal APIs. With Java 9 its default value will be 'permit' (not as strict as the original proposal), but its default value WILL cha

[GitHub] maven-surefire pull request #153: SUREFIRE-1384: ProviderInfo for JUnit Plat...

2017-06-10 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/153#discussion_r121260609 --- Diff: surefire-integration-tests/src/test/resources/junit-plattform/pom.xml --- @@ -0,0 +1,58 @@ + + + +http://maven.apache.org/P

[GitHub] maven-surefire pull request #153: SUREFIRE-1384: ProviderInfo for JUnit Plat...

2017-06-10 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/153#discussion_r121260527 --- Diff: surefire-integration-tests/src/test/resources/junit-plattform/pom.xml --- @@ -0,0 +1,58 @@ + + + +http://maven.apache.org/P

[GitHub] maven-surefire pull request #153: SUREFIRE-1384: ProviderInfo for JUnit Plat...

2017-06-10 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/153#discussion_r121260260 --- Diff: surefire-integration-tests/src/test/resources/junit-plattform/src/test/java/junitplattform/BasicTest.java --- @@ -0,0 +1,65 @@ +packag

[GitHub] maven-surefire pull request #153: SUREFIRE-1384: ProviderInfo for JUnit Plat...

2017-06-10 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/153#discussion_r121260270 --- Diff: surefire-integration-tests/src/test/resources/junit-plattform/src/test/java/junitplattform/BasicTest.java --- @@ -0,0 +1,65 @@ +packag

[GitHub] maven-surefire pull request #153: SUREFIRE-1384: ProviderInfo for JUnit Plat...

2017-06-10 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/153#discussion_r121256322 --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java --- @@ -1399,12 +1400,22 @@ private static

[GitHub] maven-surefire pull request #153: SUREFIRE-1384: ProviderInfo for JUnit Plat...

2017-06-10 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/153#discussion_r121256320 --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java --- @@ -1399,12 +1400,22 @@ private static

Re: [SUREFIRE] JUnit 5 support - current state and next steps

2017-06-10 Thread Tibor Digana
Both branches are messy. 3.0-rc1 is pretty old and not working properly because one IT fails. I wanted to continue on 3.0 two years ago but could not because the plugin was unstable and the 3.0 Extensions was undefined. The way to have extensions is clear to me now. Currently now the plugin is able

Re: [SUREFIRE] JUnit 5 support - current state and next steps

2017-06-10 Thread Tibor Digana
Pls give me time to read it. On Sat, Jun 10, 2017 at 11:06 AM, Benedikt Ritter wrote: > Hey guys, > > any thoughts on this? > > Benedikt > > Benedikt Ritter schrieb am Do. 8. Juni 2017 um 15:16: > > > Hello, > > > > first of all, I’d like to apologize for not being very active over the > > past

Re: [SUREFIRE] JUnit 5 support - current state and next steps

2017-06-10 Thread Benedikt Ritter
Hey guys, any thoughts on this? Benedikt Benedikt Ritter schrieb am Do. 8. Juni 2017 um 15:16: > Hello, > > first of all, I’d like to apologize for not being very active over the > past few months. I’ve been busy at work and there was ApacheCON… so you > know how it is :-) > > I’d like to take

Re: Wrong library.jansi.path in master 3.5.1 startup scripts

2017-06-10 Thread Hervé BOUTEMY
thinking at the IT: I have a PR in progress [1] to add an API in HawtJNI that will permit to check how the native library has been loaded this is expected to be used for a Maven IT once it is integrated... Regards, Hervé [1] https://github.com/fusesource/hawtjni/pull/36 Le samedi 10 juin 201