Am 2017-02-04 um 23:31 schrieb Christian Schulte:
I added a comment below
http://git-wip-us.apache.org/repos/asf/maven/blob/87c6346a/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionRequest.java
--
diff
Am 02/04/17 um 23:31 schrieb Michael Osipov:
> Am 2017-02-04 um 23:26 schrieb Christian Schulte:
>> Am 02/04/17 um 13:19 schrieb Michael Osipov:
>>> I will merge as-is without further modifiers.
>>
>> Please watch out for this:
>>
>> class A {
>>
>> @Deprecated
>> void methodWithTypo()
>> {
>
Am 2017-02-04 um 23:26 schrieb Christian Schulte:
Am 02/04/17 um 13:19 schrieb Michael Osipov:
I will merge as-is without further modifiers.
Please watch out for this:
class A {
@Deprecated
void methodWithTypo()
{
this.methodWithoutTypo();
}
void methodWithoutType()
{
//
I added a comment below
> http://git-wip-us.apache.org/repos/asf/maven/blob/87c6346a/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionRequest.java
> --
> diff --git
> a/maven-compat/src/main/java/org/apach
Am 02/04/17 um 13:19 schrieb Michael Osipov:
> I will merge as-is without further modifiers.
Please watch out for this:
class A {
@Deprecated
void methodWithTypo()
{
this.methodWithoutTypo();
}
void methodWithoutType()
{
// do what the old method did
}
}
External usage:
Am 02/04/17 um 11:33 schrieb Stephen Connolly:
> Yep I don't think it is a good idea to make them final
>
> We could add some tooling to the Maven-plugin-plugin to scan for annotated
> method (would need a new annotation) so that plugins using or overriding
> would get a hard error (similar to @Re
Am 02/04/17 um 10:12 schrieb Stuart McCulloch:
> Note making a method final will break binary compatibility if someone has
> previously overridden that method - in such cases they'd get a verify error
> running with the new binary:
>
> https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html#
Github user asfgit closed the pull request at:
https://github.com/apache/maven-plugins/pull/102
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
I will merge as-is without further modifiers.
Am 2017-02-04 um 11:33 schrieb Stephen Connolly:
Yep I don't think it is a good idea to make them final
We could add some tooling to the Maven-plugin-plugin to scan for annotated
method (would need a new annotation) so that plugins using or overridi
Yep I don't think it is a good idea to make them final
We could add some tooling to the Maven-plugin-plugin to scan for annotated
method (would need a new annotation) so that plugins using or overriding
would get a hard error (similar to @Restricted(NoExternalUse) in Jenkins
That would allow to r
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/110
@jonenst I am still recovering the plugin. I would like to invite you to
make code review if you like.
---
If your project is set up for it, you can reply to this email and have your
reply a
Note making a method final will break binary compatibility if someone has
previously overridden that method - in such cases they'd get a verify error
running with the new binary:
https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html#jls-13.4.17
On 4 Feb 2017 01:59, "Christian Schulte" w
Go for it
On Fri 3 Feb 2017 at 23:51, Michael Osipov wrote:
> Who seconds MNG-6166 for FIX-3.5.0? It has been discovered that one test
> relied on a non-existing dep in Central as well as Plexus Containers 1.6
> too. Upgrade to 1.7.1 resolve the missing dependency issue.
>
> Michael
>
>
13 matches
Mail list logo
