Re: [IT MNG-5958 - Take 2]: Please review integration test for MNG-5958

Ok in that case create a throwaway fork of your branch with changes that uses the changed integration tests If that passes we can throw away the throwaway branch and merge both. (Need for throwaway branch will go away soon... I'm just trying to bash bugs in updates to Jenkins plugins to enable th

Re: [IT MNG-5958 - Take 2]: Please review integration test for MNG-5958

Am 01/20/17 um 00:30 schrieb Christian Schulte: > Am 01/20/17 um 00:09 schrieb Anton Tanasenko: >> New ITs should run successfully against 3.3.9 and 3.5.0-SNAPSHOT+changes. >> It doesn't make sense to test a feature which is not in. > > The Maven core master branch of the maven-jenkinsfile job is

Re: [IT MNG-5958 - Take 2]: Please review integration test for MNG-5958

Am 01/20/17 um 00:09 schrieb Anton Tanasenko: > New ITs should run successfully against 3.3.9 and 3.5.0-SNAPSHOT+changes. > It doesn't make sense to test a feature which is not in. The Maven core master branch of the maven-jenkinsfile job is at 3.5.0-SNAPSHOT. If the updated ITs are run (from the

Re: [IT MNG-5958 - Take 2]: Please review integration test for MNG-5958

New ITs should run successfully against 3.3.9 and 3.5.0-SNAPSHOT+changes. It doesn't make sense to test a feature which is not in. 2017-01-19 22:46 GMT+02:00 Christian Schulte : > Am 01/19/17 um 13:06 schrieb Stephen Connolly: > > Ideal would be to create a *new throw-away branch* that is forked

Re: [IT MNG-5958 - Take 2]: Please review integration test for MNG-5958

Am 01/19/17 um 13:06 schrieb Stephen Connolly: > Ideal would be to create a *new throw-away branch* that is forked from > current master and just changes the itBranch in the Jenkinsfile to the > integration test branch you want to merge. To verify the changes to the ITs are working without any cha

Re: Advice + proposals regarding automodule naming

Hi, a small update: The discussion has started. For those interested, please subscribe to jpms-spec-observers[1] or view online the threads[2] However, if you want to respond to these topics, you must subscribe to jpms-spec-comments[3] or inform me (and Brian). We will gather all evidence a

Re: [IT MNG-5958 - Take 2]: Please review integration test for MNG-5958

Ideal would be to create a *new throw-away branch* that is forked from current master and just changes the itBranch in the Jenkinsfile to the integration test branch you want to merge. If those integration tests do not pass on master then that is a different story. On 19 January 2017 at 12:01, Ch

Re: [IT MNG-5958 - Take 2]: Please review integration test for MNG-5958

Am 19.01.2017 um 12:37 schrieb Stephen Connolly: > If you need to run against a different IT branch, then change > https://github.com/apache/maven/blob/master/Jenkinsfile#L22 to point to the > branch on integration tests here are the options: > > 1. (Ideal option) Create a *throwaway* branch on ma

Re: [IT MNG-5958 - Take 2]: Please review integration test for MNG-5958

This will all be easier once JENKINS-40906 is fixed fully and available on builds.apache.org On 19 January 2017 at 11:37, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > If you need to run against a different IT branch, then change > https://github.com/apache/maven/blob/master/Jenkin

Re: [IT MNG-5958 - Take 2]: Please review integration test for MNG-5958

If you need to run against a different IT branch, then change https://github.com/apache/maven/blob/master/Jenkinsfile#L22 to point to the branch on integration tests here are the options: 1. (Ideal option) Create a *throwaway* branch on maven.git specifically for the integration test run where you

Re: [IT MNG-5958 - Take 2]: Please review integration test for MNG-5958

https://builds.apache.org/job/maven-jenkinsfile/job/MNG-5958/ is failing Do not commit without showing a passing build On 19 January 2017 at 11:12, Christian Schulte wrote: > Am 16.01.2017 um 02:48 schrieb Christian Schulte: > > Commit to review is here: > > > >

Re: [IT MNG-5958 - Take 2]: Please review integration test for MNG-5958

Am 16.01.2017 um 02:48 schrieb Christian Schulte: > Commit to review is here: > > > > If no one objects until Thursday, 19th, 2017, I'll merge it to master. If no one obj