Re: MNG-5629 and MNG-6117 look good

2017-01-13 Thread Hervé BOUTEMY
yes, looks ok (not writing "+1" to not transform this to a general vote: we won't vote on every issue to merge :) ) Regards, Hervé Le vendredi 13 janvier 2017, 13:48:20 CET Stephen Connolly a écrit : > I think we are ready to push these two branches to master

Re: Next version for MPLUGIN in JIRA

2017-01-13 Thread Hervé BOUTEMY
> This also brings me to another point: could somebody second MNG-6109[2] > for M3.5.0, so I can lock the Maven version in the maven-plugin-plugin > which may use the plugin.xml or should scan the code for the @since value. oh, yes, seconded, I'm confident in this little bugfix (I don't know if I s

Re: The failing MNG-3599 tests

2017-01-13 Thread Stephen Connolly
Merged On 13 January 2017 at 13:43, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > https://github.com/apache/maven-integration-testing/commit/ > 6c86dc6fe8bad24950fa76d295910e7d7e145a21 is the diff I am proposing > (we'll know in 2 hours if it worked on a full test run) > > On 13 Ja

MNG-5629 and MNG-6117 look good

2017-01-13 Thread Stephen Connolly
I think we are ready to push these two branches to master

Re: The failing MNG-3599 tests

2017-01-13 Thread Stephen Connolly
https://github.com/apache/maven-integration-testing/commit/6c86dc6fe8bad24950fa76d295910e7d7e145a21 is the diff I am proposing (we'll know in 2 hours if it worked on a full test run) On 13 January 2017 at 13:28, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > https://builds.apache.or

Re: The failing MNG-3599 tests

2017-01-13 Thread Stephen Connolly
https://builds.apache.org/job/maven-jenkinsfile/job/mng-6155/6/ is a full build run with my proposed fix to MNG-6155 On 13 January 2017 at 13:25, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Yep... looks like that's the real fix > > On 13 January 2017 at 11:25, Stephen Connolly <

Re: The failing MNG-3599 tests

2017-01-13 Thread Stephen Connolly
Yep... looks like that's the real fix On 13 January 2017 at 11:25, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > I have 5 builds stacked up with https://github.com/ > apache/maven-integration-testing/commit/1013b7d6bf25e831860276ae68e226 > 134481cbb3 if > > > > > -

[VOTE] Release Apache Maven Compiler Plugin version 3.6.1

2017-01-13 Thread Robert Scholte
Hi, We solved 5 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317225&version=12338627&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317225%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20

Re: The failing MNG-3599 tests

2017-01-13 Thread Stephen Connolly
I have 5 builds stacked up with https://github.com/apache/maven-integration-testing/commit/1013b7d6bf25e831860276ae68e226134481cbb3 if - test-mirror + central @protocol@://www.example.com/ * works for all 5 builds then I will rebase to remove the n

Re: The failing MNG-3599 tests

2017-01-13 Thread Stephen Connolly
https://builds.apache.org/job/maven-jenkinsfile/job/mng-6155/ (which is just running the affected test) On 13 January 2017 at 11:03, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > So the problem here AIUI is that we keep metadata about when we last > checked the local repository aga

Re: The failing MNG-3599 tests

2017-01-13 Thread Stephen Connolly
So the problem here AIUI is that we keep metadata about when we last checked the local repository against the remote. When you are using dav as the proxy protocol, we need the webdav extension in order to check that the local repository artifacts match the remote... but we have not checked the web

Re: The failing MNG-3599 tests

2017-01-13 Thread Robert Scholte
Just to be sure: MNG-3599 is about "webdav does not set http-proxy correctly" -llr (or --legacy-local-repository) introduced by MNG-5181 is about skipping some checks done when working with the default local repository. I don't see any relationship, in which case the test adjustment is fine fo