[GitHub] maven pull request #94: MNG-5889 - adding logic that looks for the file argu...

2016-11-14 Thread rpatrick00
Github user rpatrick00 closed the pull request at: https://github.com/apache/maven/pull/94 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[MNG-5761] Dependency management is not transitive.

2016-11-14 Thread Christian Schulte
Hi, starting to write up some documentation for 3.4.0 has lead to (re-) reading various parts of the existing documentation. Regarding the issue in the subject. Would it be ok to include the corresponding fix in 3.4.0? It makes Maven 3.4.0 dependency management behave exactly as it is documented.

[GitHub] maven issue #94: MNG-5889 - adding logic that looks for the file argument an...

2016-11-14 Thread hboutemy
Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/94 FYI I'm running Kubuntu 16.10 not a big issue: thank your for the great job please take time to close the PR --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] maven issue #94: MNG-5889 - adding logic that looks for the file argument an...

2016-11-14 Thread rpatrick00
Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/94 @hboutemy, sorry but both "==" and "=" seem to work fine on Oracle Linux and MacOS (where I tested the sh script). Not sure which version of Linux caused this but thanks for fixing it... --- If y

Re: [VOTE] Release Apache Maven Resources Plugin version 3.0.2

2016-11-14 Thread Olivier Lamy
+1 On 14 November 2016 at 08:26, Christian Schulte wrote: > Hi, > > We solved 3 issues: > * [MRESOURCES-230] - Can't escape the escape string > * [MRESOURCES-233] - Upgrade of plexus-interpolation 1.24 to correct > escaping issue. > * [MRESOURCES-234] - Upgrade of commons-io to 2.5 a

Re: How can I remove dependencies pom.xml from shaded jar in elegant way?

2016-11-14 Thread Robert Scholte
I think fixing it in maven-shade-plugin. In case of relocation you might indeed wonder if it makes sense to add the artifact metadata files. Robert On Mon, 14 Nov 2016 03:17:16 +0100, Tibor Digana wrote: Hi , How can I remove dependencies pom.xml from shaded jar in elegant way? See htt

[GitHub] maven issue #94: MNG-5889 - adding logic that looks for the file argument an...

2016-11-14 Thread hboutemy
Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/94 I just merged the patch I had to change `==` tests to `=` since it did not work on Linux: the result is `if [ "$arg" = "-f" -o "$arg" = "--file" ]; then` And it required a little update to the

[GitHub] maven-enforcer pull request #20: MENFORCER-195 - use DependencyGraphBuilder ...

2016-11-14 Thread ctomc
GitHub user ctomc opened a pull request: https://github.com/apache/maven-enforcer/pull/20 MENFORCER-195 - use DependencyGraphBuilder API instead of DependencyTreeBuilder Using this I get enforcer to work with wildcard exclusion without any issue. as a bonus ban bad dependencies

JDK 9 & JDK 9 with Project Jigsaw b144 are available on java.net

2016-11-14 Thread Rory O'Donnell
Hi Robert & Kristian, Early Access b144 (#5709) for JDK 9 with Project Jigsaw is available on java.net, summary of changes are listed here. Early Access b144

[GitHub] maven issue #94: MNG-5889 - adding logic that looks for the file argument an...

2016-11-14 Thread hboutemy
Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/94 IMHO, the first thing is to check in the current fix, since ITs are currently broken then improving the IT to check more parts could be interesting: priority 2 --- If your project is set up for i

[GitHub] maven issue #94: MNG-5889 - adding logic that looks for the file argument an...

2016-11-14 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/maven/pull/94 @hboutemy I would at least check for `jvm.config` because this is expanded in the script itself. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] maven issue #94: MNG-5889 - adding logic that looks for the file argument an...

2016-11-14 Thread hboutemy
Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/94 yes, that's exactly the part I was looking for. The shell script: 1. finds the basedir 2. uses it to load `jvm.config` 3. then injects the value as `maven.multiModuleProjectDirectory` p

[GitHub] maven issue #94: MNG-5889 - adding logic that looks for the file argument an...

2016-11-14 Thread rpatrick00
Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/94 If you look at the shell script, it used to compute the "basedir" variable starting at the current working directory and then search upwards for the .mvn directory. Then, it set the MAVEN_PROJECTBA

[GitHub] maven issue #94: MNG-5889 - adding logic that looks for the file argument an...

2016-11-14 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/maven/pull/94 @rpatrick00 Can you shed some light here? What do you to properly picked up? `extensions.xml`, `maven.config`, and `jvm.config`, right? --- If your project is set up for it, you can reply to this em

[GitHub] maven issue #94: MNG-5889 - adding logic that looks for the file argument an...

2016-11-14 Thread hboutemy
Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/94 maybe I'm missing something... {{.mvn}} directory has to be found by shell script because of {{jvm.config}} particularly But once he directory is found by shell script, I suppose it is injected

[GitHub] maven issue #94: MNG-5889 - adding logic that looks for the file argument an...

2016-11-14 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/maven/pull/94 @hboutemy I am bit confused by the IT. The issue was about having `.mvn` properly located to expand `maven.config`. I would expect some system property to be added and retrieved. Am I wrong? --- If