[GitHub] maven-surefire pull request #124: Fix formatting, convert tabs to spaces

2016-10-10 Thread britter
Github user britter closed the pull request at: https://github.com/apache/maven-surefire/pull/124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Re: Cannot build current master.

2016-10-10 Thread Karl Heinz Marbaise
Hi, interesting, cause I couldn't reproduce the issue on my system ..only the build server shows an test failure... I need to investigage the reason for that ...cause other tests from the same folder working... Are you running on Linux / Mac / Windows ? Java Version? Kind regards Karl Hein

Cannot build current master.

2016-10-10 Thread Christian Schulte
Just updated current master and am getting test failures. Just my local checkout? $ env LC_ALL=C git branch * master maven-3.x-next $ env LC_ALL=C git status On branch master Your branch is up-to-date with 'origin/master'. nothing to commit, working directory clean testInvalidArtifactIdInPlugi

[GitHub] maven-surefire pull request #127: [SUREFIRE-1293] Simplify org.apache.maven....

2016-10-10 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/127#discussion_r82700832 --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java --- @@ -76,7 +76,7 @@ public TestSetRun

[GitHub] maven-surefire pull request #127: [SUREFIRE-1293] Simplify org.apache.maven....

2016-10-10 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/127#discussion_r82699845 --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java --- @@ -76,7 +76,7 @@ public TestSetRun

[GitHub] maven-surefire pull request #127: [SUREFIRE-1293] Simplify org.apache.maven....

2016-10-10 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/127#discussion_r82699554 --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/NullConsoleReporter.java --- @@ -33,7 +33,10 @@ class Null

[GitHub] maven-surefire pull request #127: [SUREFIRE-1293] Simplify org.apache.maven....

2016-10-10 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/127#discussion_r82699403 --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/NullConsoleOutputReceiver.java --- @@ -31,7 +31,13 @@

Re: Maven 3.4.0-SNAPSHOT 2016-10-09 and setttings.xml?

2016-10-10 Thread Christian Schulte
Am 10/10/16 um 20:49 schrieb Igor Fedorenko: > Are repositories and other configuration defined in user settings.xml > take precedence over global settings.xml? Don't know for sure but would assume so. The current master 4.0.0 super pom has already been reverted to not change in any way in 3.4.0.

Re: Maven 3.4.0-SNAPSHOT 2016-10-09 and setttings.xml?

2016-10-10 Thread Mirko Friedenhagen
But why would the server settings override the values of the user's settings? I thought the latter ones always had precedence. Regards Mirko -- Sent from my mobile Am 10.10.2016 22:57 schrieb "Robert Scholte" : > so this is the first change: > https://git1-us-west.apache.org/repos/asf?p=maven.g

[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized

2016-10-10 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/126 @britter The only problem is with workspace for the `Junit4VersionsIT` which is `/target/Junit4VersionsIT_testJunit` same for all parameters. Therefore we should not take the only single

[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized

2016-10-10 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/126 @britter Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] maven-surefire issue #125: Consistently rename JUnit 4.x integration tests

2016-10-10 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/125 @britter It makes me a problem to merge this PR. Please open a new one with same changes. --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: Maven 3.4.0-SNAPSHOT 2016-10-09 and setttings.xml?

2016-10-10 Thread Robert Scholte
so this is the first change: https://git1-us-west.apache.org/repos/asf?p=maven.git;a=commit;h=1b00a9e1 removing it from the POM (I assumed it was really in the Java code) Maybe this is a candidate to add to a new version of the settings.xml This file is a Maven-only file, which makes is easier to

Re: Maven 3.4.0-SNAPSHOT 2016-10-09 and setttings.xml?

2016-10-10 Thread Mirko Friedenhagen
Hello everyone, this is basically my settings.xml (stripped servers section and a few sonarqube related properties): central * Internal mirror of all needed dependencies https://inhouse.server/artifactory/internal-central/

[GitHub] maven-surefire issue #124: Fix formatting, convert tabs to spaces

2016-10-10 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/124 @britter Done Thx for contributing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

RE: upgrade maven plugin to run with asm 6?

2016-10-10 Thread Romain Manni-Bucau
Oh tested 3.4 but missed 3.5. 3.5 solved the issue! Thanks! Le 10 oct. 2016 20:31, "Martin Gainty" a écrit : > > > > > > From: rmannibu...@gmail.com > > Date: Mon, 10 Oct 2016 17:07:54 +0200 > > Subject: Re: upgrade maven plugin to run with asm 6? > > To: dev@maven.apache.org > > > > 2016-10-10

Re: Maven 3.4.0-SNAPSHOT 2016-10-09 and setttings.xml?

2016-10-10 Thread Igor Fedorenko
Not just the url, but all aspect of "central" repository are configurable in user settings.xml today. Even if we provide a better way to express this configuration, I believe the old way should continue to work for a few releases to allow graceful migration. Many users will use multiple versions of

Re: Maven 3.4.0-SNAPSHOT 2016-10-09 and setttings.xml?

2016-10-10 Thread Igor Fedorenko
Are repositories and other configuration defined in user settings.xml take precedence over global settings.xml? -- Regards, Igor On Mon, Oct 10, 2016, at 10:16 AM, Christian Schulte wrote: > Am 10.10.2016 um 15:35 schrieb Igor Fedorenko: > > It is common to use repository with id=central in set

Re: Maven 3.4.0 Release

2016-10-10 Thread Robert Scholte
On Mon, 10 Oct 2016 11:08:52 +0200, Stephen Connolly wrote: On 10 October 2016 at 09:40, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: https://issues.apache.org/jira/browse/MNG-5971 I would argue that the behaviour change in MNG-5971 should not be introduced at the same time

Re: Maven 3.4.0-SNAPSHOT 2016-10-09 and setttings.xml?

2016-10-10 Thread Robert Scholte
On Mon, 10 Oct 2016 16:22:20 +0200, Christian Schulte wrote: Am 10.10.2016 um 16:16 schrieb Christian Schulte: Am 10.10.2016 um 15:35 schrieb Igor Fedorenko: It is common to use repository with id=central in settings.xml to override central location. This functionality should continue to wo

RE: upgrade maven plugin to run with asm 6?

2016-10-10 Thread Martin Gainty
> From: rmannibu...@gmail.com > Date: Mon, 10 Oct 2016 17:07:54 +0200 > Subject: Re: upgrade maven plugin to run with asm 6? > To: dev@maven.apache.org > > 2016-10-10 16:54 GMT+02:00 Martin Gainty : > > > > > > > > > > From: rmannibu...@gmail.com > > > Date: Mon, 10 Oct 2016 15:10:33 +0200 > >

[VOTE] Release Apache Maven PMD Plugin version 3.7

2016-10-10 Thread Andreas Dangel
Hi, We solved 11 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317621&version=12334373&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MPMD%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%

Re: upgrade maven plugin to run with asm 6?

2016-10-10 Thread Robert Scholte
hi, I've already done some improvements on the maven-plugin-plugin 3.5 (released 2016-08-30) which should work with Java9. If there's still an issue, let me know. Robert On Mon, 10 Oct 2016 17:07:54 +0200, Romain Manni-Bucau wrote: 2016-10-10 16:54 GMT+02:00 Martin Gainty : > From

Re: [SUREFIRE] Parameterized Tests for Junit 4 and Junit 5? (Was: [SUREFIRE] JUnit 5 support - how to move things forward?)

2016-10-10 Thread Benedikt Ritter
Hello again, Tibor Digana schrieb am Mi., 5. Okt. 2016 um 00:05 Uhr: > >>Or do we want to even share the test projects and work with profiles in > the test project pom? > > I mean this. > > It pretty depends on what we are going to test, either: > + features of surefire-junit5 provider, or > + f

[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized

2016-10-10 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/126 We need to rebase the junit5 branch after this has been merged in order to pick up this changes. --- If your project is set up for it, you can reply to this email and have your reply appear

[SUREFIRE] Hangout with Marc Philipp

2016-10-10 Thread Benedikt Ritter
Hi, I've had the chance to talk to Marc Philipp from the JUnit team again, and I'd like to share with you some of our discussions. First we talked about the progress with the surefire provider: Currently I've done not much. We have a junit5 branch with a single PR merged (the JUnit5VersionsIT). F

Re: [SUREFIRE] Jenkins job for junit5 branch

2016-10-10 Thread Benedikt Ritter
Hi Christopher, Christofer Dutz schrieb am Mo., 10. Okt. 2016 um 10:49 Uhr: > Hi Guys ... I just setup such a build with the Pipeline Plugin for the > Flex project ... is working nicely. I could help you with this, if you like? > I leave this to the maven guys :-) > > > Chris > >

[GitHub] maven-surefire pull request #127: [SUREFIRE-1293] Simplify org.apache.maven....

2016-10-10 Thread britter
Github user britter commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/127#discussion_r82631034 --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/NullStatisticsReporter.java --- @@ -35,7 +36,7 @@

[GitHub] maven-surefire pull request #127: [SUREFIRE-1293] Simplify org.apache.maven....

2016-10-10 Thread britter
Github user britter commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/127#discussion_r82631691 --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java --- @@ -76,7 +76,7 @@ public TestSetRun

[GitHub] maven-surefire pull request #123: JUnit5: Add test for setting environment v...

2016-10-10 Thread britter
Github user britter closed the pull request at: https://github.com/apache/maven-surefire/pull/123 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] maven-surefire issue #123: JUnit5: Add test for setting environment variable...

2016-10-10 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/123 We don't need this anymore, since we'll go with the parameterized test approach. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

Re: upgrade maven plugin to run with asm 6?

2016-10-10 Thread Romain Manni-Bucau
2016-10-10 16:54 GMT+02:00 Martin Gainty : > > > > > From: rmannibu...@gmail.com > > Date: Mon, 10 Oct 2016 15:10:33 +0200 > > Subject: upgrade maven plugin to run with asm 6? > > To: dev@maven.apache.org > > > > Hi guys, > > > > is there some plans to upgrade maven plugin to asm6 (thinking > > to

RE: upgrade maven plugin to run with asm 6?

2016-10-10 Thread Martin Gainty
> From: rmannibu...@gmail.com > Date: Mon, 10 Oct 2016 15:10:33 +0200 > Subject: upgrade maven plugin to run with asm 6? > To: dev@maven.apache.org > > Hi guys, > > is there some plans to upgrade maven plugin to asm6 (thinking > to maven-plugin-tools-annotations and maven-plugin-plugin and mor

Re: Maven 3.4.0-SNAPSHOT 2016-10-09 and setttings.xml?

2016-10-10 Thread Christian Schulte
Am 10.10.2016 um 15:35 schrieb Igor Fedorenko: > It is common to use repository with id=central in settings.xml to > override central location. This functionality should continue to work, > regardless how it is implemented in Maven internally. > Do you have a wildcard mirror in the settings as we

Re: Maven 3.4.0-SNAPSHOT 2016-10-09 and setttings.xml?

2016-10-10 Thread Christian Schulte
Am 10.10.2016 um 16:16 schrieb Christian Schulte: > Am 10.10.2016 um 15:35 schrieb Igor Fedorenko: >> It is common to use repository with id=central in settings.xml to >> override central location. This functionality should continue to work, >> regardless how it is implemented in Maven internally.

Re: Maven 3.4.0-SNAPSHOT 2016-10-09 and setttings.xml?

2016-10-10 Thread Christian Schulte
Am 10.10.2016 um 15:35 schrieb Igor Fedorenko: > It is common to use repository with id=central in settings.xml to > override central location. This functionality should continue to work, > regardless how it is implemented in Maven internally. >

Re: Maven 3.4.0-SNAPSHOT 2016-10-09 and setttings.xml?

2016-10-10 Thread Christian Schulte
Am 10.10.2016 um 15:35 schrieb Igor Fedorenko: > It is common to use repository with id=central in settings.xml to > override central location. This functionality should continue to work, > regardless how it is implemented in Maven internally. > That is what has become the default. Did you look a

Re: Maven 3.4.0-SNAPSHOT 2016-10-09 and setttings.xml?

2016-10-10 Thread Igor Fedorenko
It is common to use repository with id=central in settings.xml to override central location. This functionality should continue to work, regardless how it is implemented in Maven internally. -- Regards, Igor On Mon, Oct 10, 2016, at 09:10 AM, Christian Schulte wrote: > Am 10/10/16 um 14:45 schri

upgrade maven plugin to run with asm 6?

2016-10-10 Thread Romain Manni-Bucau
Hi guys, is there some plans to upgrade maven plugin to asm6 (thinking to maven-plugin-tools-annotations and maven-plugin-plugin and more concretely to DefaultMojoAnnotationsScanner used to generate the help mojo)? I know there is only the alpha our ATM but I think it would enable users to start

Re: Maven 3.4.0-SNAPSHOT 2016-10-09 and setttings.xml?

2016-10-10 Thread Christian Schulte
Am 10/10/16 um 14:45 schrieb Mirko Friedenhagen: > Hello, > > I just tried to run "mvn help:effective-pom -Doutput=MVNVERSION.xml" > on one of our inhouse projects once with 3.3.9 and once with > 3.4.0-SNAPSHOT (4ad0fb217c93d36cf3365b83baec48470196f5fa; > 2016-10-09T21:16:52+02:00) > > 3.4.0 seem

Maven 3.4.0-SNAPSHOT 2016-10-09 and setttings.xml?

2016-10-10 Thread Mirko Friedenhagen
Hello, I just tried to run "mvn help:effective-pom -Doutput=MVNVERSION.xml" on one of our inhouse projects once with 3.3.9 and once with 3.4.0-SNAPSHOT (4ad0fb217c93d36cf3365b83baec48470196f5fa; 2016-10-09T21:16:52+02:00) 3.4.0 seems not to incorporate settings correctly (or I misconfigured somet

[GitHub] maven-plugins pull request #38: MJAVADOC-410

2016-10-10 Thread vincent-zurczak
Github user vincent-zurczak closed the pull request at: https://github.com/apache/maven-plugins/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Maven 3.4.0 Release

2016-10-10 Thread Stephen Connolly
On 10 October 2016 at 09:40, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > > https://issues.apache.org/jira/browse/MNG-5971 > > I would argue that the behaviour change in MNG-5971 should not be > introduced at the same time as a refactoring to move to the new "code > formerly known

AW: [SUREFIRE] Jenkins job for junit5 branch

2016-10-10 Thread Christofer Dutz
Hi Guys ... I just setup such a build with the Pipeline Plugin for the Flex project ... is working nicely. I could help you with this, if you like? Chris Von: Tibor Digana Gesendet: Montag, 10. Oktober 2016 08:15:25 An: dev@maven.apache.org Betreff: Re: [SUREFI

Re: Maven 3.4.0 Release

2016-10-10 Thread Stephen Connolly
The following issues IMHO all affect build time behaviour and do not affect dependency consumption. As such they do not require a modelVersion bump https://issues.apache.org/jira/browse/MNG-6054 https://issues.apache.org/jira/browse/MNG-5992 https://issues.apache.org/jira/browse/MNG-5968 https://i

Re: Maven 3.4.0 Release

2016-10-10 Thread Stephen Connolly
On 10 October 2016 at 01:38, Christian Schulte wrote: > Am 10/09/16 um 21:44 schrieb Stephen Connolly: > > Open issues bound to 3.4.0 > > > > * Introduction of model version 4.1.0. > > https://issues.apache.org/jira/browse/MNG-6082 > >