Re: [SUREFIRE] Branch for JUnit 5 integration?

Hello, the branch with the first JUnit 5 IT is ready for reintegration. My proposal is to create a separate branch for working on JUnit 5 so that we can merge it to master only when all work on JUnit 5 support is done. Regards, Benedikt Tibor Digana schrieb am Mo., 12. Sep. 2016 um 01:13 Uhr:

[GitHub] maven-surefire issue #118: Add basic integration test for JUnit 5

Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/118 @Tibor17 I've assed the assume statement using the API introduced in #120. I propose that you create a new branch for JUnit 5, where we can merge this PR and all follow up PRs for JUnit 5 int

[GitHub] maven-surefire pull request #120: Add convinient method to check for the cur...

Github user britter closed the pull request at: https://github.com/apache/maven-surefire/pull/120 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] maven-surefire issue #120: Add convinient method to check for the currently ...

Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/120 @Tibor17 thank you for integrating this. Did you know, that it is possible to mark PRs as merged in GitHub? I've documented the workflow in the [Apache Commons Wiki](http://wiki.apache.org/c

Re: colored console

Thanks to all who has contributed in this thread. Here is the final result, see attached picture. Now there are colors but the entire line of test result is not one color/green which was previously shining to you eyes in every line. If the Users group requires customizing the outcome, we can still

[GitHub] maven-surefire issue #120: Add convinient method to check for the currently ...

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/120 @britter Thank you for contributing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] maven-surefire issue #121: Fix for issue SUREFIRE-1278

Github user khospodarysko commented on the issue: https://github.com/apache/maven-surefire/pull/121 @Tibor17 No, I haven't. This is my first such patch. I'm happy it added more quality to the product! --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] maven-surefire issue #120: Add convinient method to check for the currently ...

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/120 @britter I have created Jira issue for this Task https://issues.apache.org/jira/browse/SUREFIRE-1282 --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven-surefire pull request #120: Add convinient method to check for the cur...

Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/120#discussion_r79314476 --- Diff: surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/HelperAssertions.java --- @@ -172,7 +173,7 @@ public static

[GitHub] maven-surefire issue #121: Fix for issue SUREFIRE-1278

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/121 @khospodarysko CI build was successful. This should be normally closed automatically and sometimes it takes a day but you can close it as well. Thank you for contributing. Have you con

Further questions to "Add modulepath support" SUREFIRE-1262

I have executed examples from http://openjdk.java.net/projects/jigsaw/quick-start Now I have handson exps but still something is not clear. Did Jigsaw broke backwards compatibility? Running Main-Class from Manifest would not work like this? java -jar surefire.jar The problem is that it makes sens

[GitHub] maven-surefire issue #121: Fix for issue SUREFIRE-1278

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/121 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[GitHub] maven-surefire issue #121: Fix for issue SUREFIRE-1278

Github user khospodarysko commented on the issue: https://github.com/apache/maven-surefire/pull/121 Followed the analogy and added org.apache.maven.surefire.its.jiras.Surefire1278GroupNameEndingIT to src/test/java folder. Please let me know if something else is wrong and I'll try

[GitHub] maven-surefire issue #121: Fix for issue SUREFIRE-1278

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/121 @khospodarysko Do you have it in *.bak file or in bytecode in /target/classes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] maven-surefire issue #121: Fix for issue SUREFIRE-1278

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/121 @khospodarysko Something wrong happened. The IT class is missing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] maven-surefire pull request #120: Add convinient method to check for the cur...

Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/120#discussion_r79310840 --- Diff: surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/HelperAssertions.java --- @@ -172,7 +173,7 @@ public static