Re: colored console

Romain, did you mean ${maven.projectBasedir}/.mvn/maven.config [1] ? Some extension or maven.config. [1] https://maven.apache.org/docs/3.3.1/release-notes.html On Fri, Sep 9, 2016 at 12:20 AM, Romain Manni-Bucau wrote: > Color is a user thing not a build thing so belongs to .m2 not > I think. >

Re: colored console

Le 9 sept. 2016 00:29, "Tibor Digana" a écrit : > > This is good question to dev who created simplelogger.properties in > MVN-3.4.0/conf/logging. > Not nice to use structured config in *.properties file. > Can you write simple Java interface what you really want to customize > because everybody ha

Re: colored console

This is good question to dev who created simplelogger.properties in MVN-3.4.0/conf/logging. Not nice to use structured config in *.properties file. Can you write simple Java interface what you really want to customize because everybody has some imagination so I want you to be more concrete. On Fri

Re: colored console

Color is a user thing not a build thing so belongs to .m2 not I think. Le 9 sept. 2016 00:18, "Gary Gregory" a écrit : > On Thu, Sep 8, 2016 at 2:48 PM, Romain Manni-Bucau > wrote: > > > +1 to remove the bold > > > > I agree fwiw. > > Gary > > > > What about having the coloration configurable

Re: colored console

On Thu, Sep 8, 2016 at 2:48 PM, Romain Manni-Bucau wrote: > +1 to remove the bold > I agree fwiw. Gary > What about having the coloration configurable in settings.xml: current or > no color for test result line or single color for level and result or only > start of the line? > > Le 8 sept. 2

Re: colored console

Hi Romain, I don't think it is possible in settings.xml per plugin. You can switch off all colors in entire build via batch mode "mvn -B test". I was initially thinking of SPI, so I implemented and deleted right after. So it can be in Surefire 3.0 via xml element implements or SPI. On Thu, Sep

Re: colored console

+1 to remove the bold What about having the coloration configurable in settings.xml: current or no color for test result line or single color for level and result or only start of the line? Le 8 sept. 2016 23:36, "Tibor Digana" a écrit : > sending the picture in attachment.. > > On Thu, Sep 8, 2

Re: colored console

sending the picture in attachment.. On Thu, Sep 8, 2016 at 11:32 PM, Romain Manni-Bucau [via Maven] < ml-node+s40175n5880220...@n5.nabble.com> wrote: > Hello Tibor, > > not sure that's me but I don't see the picture > > that said I like this kind of coloring for maven: > https://raw.githubusercon

Re: colored console

Hello Tibor, not sure that's me but I don't see the picture that said I like this kind of coloring for maven: https://raw.githubusercontent.com/rmannibucau/maven-color/master/screenshot.png . Makes it easy to identify steps and warn/error (in red) visually Romain Manni-Bucau @rmannibucau

colored console

Currently the colored console looks like in the picture. Please let me know what other highlighting you prefer. I do not prefer using bold text in color, and use colors only in the begin of line: "Tests run: 12, Failure: 0, Errors: 0, Skipped: 0" WDYT? I will not change the text. [image: Inline

Re: [SUREFIRE] How does Junit4VersionsIT work?

Hello Tibor, thank you for solving the mistery :-) I will put together a PR to fix the IT. Regards, Benedikt Tibor Digana schrieb am Do., 8. Sep. 2016 um 22:08: > This is obviously a bug and junit.version should be used. > If you type "unpack().debugLogging()." in the IT you will see that the

Re: [SUREFIRE] How does Junit4VersionsIT work?

This is obviously a bug and junit.version should be used. If you type "unpack().debugLogging()." in the IT you will see that the classpath contains junit-4.4 instead of the providing one. There are several such cases but not all ITs alter the version. On Wed, Sep 7, 2016 at 9:10 PM, Benedikt Ritte

[GitHub] maven-surefire pull request #118: Add basic integration test for JUnit 5

Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/118#discussion_r78076018 --- Diff: surefire-integration-tests/src/test/resources/junit5/src/test/java/junit5/JUnit5Test.java --- @@ -53,13 +53,13 @@ public void tearDown()

[GitHub] maven-surefire issue #118: Add basic integration test for JUnit 5

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/118 One more job to do in *IT.java. Can you please add `assumeThat(java.specification.version, is(greaterThan(1.7)));`. A hint: Just lookup the text "java.specification.version" in ITs.

[GitHub] maven-surefire issue #118: Add basic integration test for JUnit 5

Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/118 @tibor this PR is only about introducing ITs. The M2 release of the provider is pulled in via maven as dependency, see the test pom.xml. I agree that surefire should not ship with a have fini

[GitHub] maven-surefire issue #118: Add basic integration test for JUnit 5

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/118 We cannot really marge the external provider to master if it is alpha or beta version and if we do not have ITs. We in hurry too much however we take full responsibility for the quality