Re: Maven plugin - some licensing questions

2016-07-01 Thread Stian Soiland-Reyes
On 1 July 2016 at 12:54, Grzegorz Słowikowski wrote: > I have some more technical questions. I'll let the actual Maven developers chip in on those :) > My second questions is how and where should I describe my modifications? > Do I need to provide somehow the original source of modified class?

Re: Maven plugin - some licensing questions

2016-07-01 Thread Mark Derricutt
When I was writing my LifecycleExtension recently I hit this same issue, with the two different logger classes depending on where my common code was being called from. I just changed my base code to accept a Consumer and passed in getLog()::info and the relevant other method from the other logger

Re: https://issues.apache.org/jira/browse/MNG-5895

2016-07-01 Thread Robert Scholte
Hi Karl Heinz, I think you should focus on the org.apache.maven.graph.DefaultGraphBuilder when you're talking about the reactor order. Robert On Fri, 01 Jul 2016 19:55:56 +0200, Karl Heinz Marbaise wrote: Hi, I have described two issues within this issue. First the changed reactor or

Re: Plugin resolution for Maven 3.5

2016-07-01 Thread Karl Heinz Marbaise
Hi, On 7/1/16 9:03 PM, Christian Schulte wrote: Am 07/01/16 um 20:11 schrieb Karl Heinz Marbaise: Hi, wouldn't it make sense to create a branch for Maven 3.5.0 ? And summarize all changes there ? Makes it more clear ? Cause there are some issues fixed related to JIRA...for 3.5.0 ? WDYT ?

Re: Plugin resolution for Maven 3.5

2016-07-01 Thread Christian Schulte
Am 07/01/16 um 20:11 schrieb Karl Heinz Marbaise: > Hi, > > wouldn't it make sense to create a branch for Maven 3.5.0 ? And > summarize all changes there ? Makes it more clear ? > > Cause there are some issues fixed related to JIRA...for 3.5.0 ? > > WDYT ? > > Already done. That's the MNG-60

Re: Plugin resolution for Maven 3.5

2016-07-01 Thread Karl Heinz Marbaise
Hi, wouldn't it make sense to create a branch for Maven 3.5.0 ? And summarize all changes there ? Makes it more clear ? Cause there are some issues fixed related to JIRA...for 3.5.0 ? WDYT ? Kind regards Karl Heinz Marbaise On 7/1/16 9:16 AM, Christian Schulte wrote: Hi, I am currently s

Re: https://issues.apache.org/jira/browse/MNG-5895

2016-07-01 Thread Karl Heinz Marbaise
Hi, I also realized that we currently having failing Maven Core IT[1] which is related to this subject[2] Kind regards Karl Heinz [1]: https://builds.apache.org/view/M-R/view/Maven%20Core%20ITs/job/core-integration-testing-maven-3-jdk-1.7/1820/console [2] https://issues.apache.org/jira/brow

https://issues.apache.org/jira/browse/MNG-5895

2016-07-01 Thread Karl Heinz Marbaise
Hi, I have described two issues within this issue. First the changed reactor order based on using a property for the version and second the problem related to the version which is used for artifacts. At the moment I'm trying to identify the first issue...but currently I'm a little bit lost.

[GitHub] maven-shared pull request #13: [MSHARED-562] override default colors with ja...

2016-07-01 Thread seblm
GitHub user seblm opened a pull request: https://github.com/apache/maven-shared/pull/13 [MSHARED-562] override default colors with java properties This pull request allow a user to redefine default maven colors with some java properties. For example one can edit his `~/.mav

Re: Maven plugin - some licensing questions

2016-07-01 Thread Grzegorz Słowikowski
Hi Karl On 2016-07-01 14:09, Karl Heinz Marbaise wrote: > Hi, > > On 7/1/16 1:54 PM, Grzegorz Słowikowski wrote: >> Thank you very much Stian. >> >> I have some more technical questions. >> >> 1. >> >> When I wrote about using modified class from Maven core I thought about >> ExecutionEventLogge

Re: Maven plugin - some licensing questions

2016-07-01 Thread Karl Heinz Marbaise
Hi, On 7/1/16 1:54 PM, Grzegorz Słowikowski wrote: Thank you very much Stian. I have some more technical questions. 1. When I wrote about using modified class from Maven core I thought about ExecutionEventLogger class from maven-embedder (https://github.com/apache/maven/blob/master/maven-embe

Re: Maven plugin - some licensing questions

2016-07-01 Thread Grzegorz Słowikowski
Thank you very much Stian. I have some more technical questions. 1. When I wrote about using modified class from Maven core I thought about ExecutionEventLogger class from maven-embedder (https://github.com/apache/maven/blob/master/maven-embedder/src/main/java/org/apache/maven/cli/event/Executio

Re: [VOTE] Release Apache Maven SCM version 1.9.5

2016-07-01 Thread Anders Hammar
Shouldn't this rather be v1.10.0 as there are new features? /Anders On Fri, Jul 1, 2016 at 1:24 PM, Karl Heinz Marbaise wrote: > Hi, > > We solved 24 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317828&version=12331366 > > There are still a couple of issues lef

Re: [1/2] maven-scm git commit: [SCM-824] Upgrade of 'plexus-utils' to 3.0.23.

2016-07-01 Thread Olivier Lamy
Thanks a lot Karl! On Friday, 1 July 2016, Karl Heinz Marbaise wrote: > Hi Craig, > > I have taken a the liberty to cut a release > > starting the release process. I hope this helps. > > Kind regards > Karl Heinz Marbaise > > On 6/29/16 6:07 AM, Craig Rodrigues wrote: > >> Hi, >> >> Do you think

Re: [1/2] maven-scm git commit: [SCM-824] Upgrade of 'plexus-utils' to 3.0.23.

2016-07-01 Thread Karl Heinz Marbaise
Hi Craig, I have taken a the liberty to cut a release starting the release process. I hope this helps. Kind regards Karl Heinz Marbaise On 6/29/16 6:07 AM, Craig Rodrigues wrote: Hi, Do you think you will be able to do a release of maven-scm this week? I am still receiving queries from Jenki

[VOTE] Release Apache Maven SCM version 1.9.5

2016-07-01 Thread Karl Heinz Marbaise
Hi, We solved 24 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317828&version=12331366 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20SCM%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%

Re: [1/2] maven-scm git commit: [SCM-824] Upgrade of 'plexus-utils' to 3.0.23.

2016-07-01 Thread Karl Heinz Marbaise
Hi, I can do this today if you have no objections... Kind regards Karl Heinz On 7/1/16 11:22 AM, Olivier Lamy wrote: Hi I'm on holidays with very limited network I apologise for delay as I was busy before holidays next week might better. On Wednesday, 29 June 2016, Craig Rodrigues wrote:

Re: [1/2] maven-scm git commit: [SCM-824] Upgrade of 'plexus-utils' to 3.0.23.

2016-07-01 Thread Olivier Lamy
Hi I'm on holidays with very limited network I apologise for delay as I was busy before holidays next week might better. On Wednesday, 29 June 2016, Craig Rodrigues wrote: > Hi, > > Do you think you will be able to do a release of maven-scm this week? > I am still receiving queries from Jenkins

[GitHub] maven-archetype issue #8: ARCHETYPE-491

2016-07-01 Thread ptahchiev
Github user ptahchiev commented on the issue: https://github.com/apache/maven-archetype/pull/8 Hi @michael-o can you have a look at this pull-request. I don't have the rights to have it merged. --- If your project is set up for it, you can reply to this email and have your reply appe

Re: Plugin resolution for Maven 3.5

2016-07-01 Thread Anders Hammar
Not sure I completely understand the question, but we've always said that you shouldn't use another plugin as a dependency. Re-usable logic should be kept in a library instead. /Anders On Fri, Jul 1, 2016 at 9:16 AM, Christian Schulte wrote: > Hi, > > I am currently stumbling upon the following

Plugin resolution for Maven 3.5

2016-07-01 Thread Christian Schulte
Hi, I am currently stumbling upon the following issue. Maven resolves plugins as if they were a direct dependency of Maven core. That means it will not consider any 'test' or 'provided' scope dependencies of plugins when building plugin runtime classpaths. I am not sure if this is the correct way