[GitHub] maven-integration-testing issue #14: MNG-6049: Adds integration tests for ve...

2016-06-21 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 @michael-o Done. ITs passed. Merge conflict solved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] maven issue #70: MNG-6049: Adds version range result filter behaviour

2016-06-21 Thread talios
Github user talios commented on the issue: https://github.com/apache/maven/pull/70 @barthel Maybe, I'm running 3.4.0-SNAPSHOTs anyway, and might pull in your PR to play with and see if it helps with what I'm doing. My currently problem is that IntelliJ IDEA doesn't seem to execute an

[GitHub] maven-integration-testing issue #14: MNG-6049: Adds integration tests for ve...

2016-06-21 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 @michael-o Rename already done. ITs running locally right now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

Re: VOTE] Release Apache Maven Source Plugin version 3.0.1

2016-06-21 Thread Olivier Lamy
+1 On 19 June 2016 at 00:49, Karl Heinz Marbaise wrote: > Hi, > > We solved 8 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317924&version=12335588 > > There are still one issue left in JIRA: > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSOURCES

Re: [VOTE] Release Apache Maven JAR Plugin version 3.0.2

2016-06-21 Thread Olivier Lamy
+1 On 22 June 2016 at 05:54, Karl Heinz Marbaise wrote: > Hi, > > here is my +1... > > one more PMC VOTE needed... > > Kind regards > Karl Heinz > On 6/18/16 4:24 PM, Karl Heinz Marbaise wrote: > >> Hi, >> >> We solved 4 issues: >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projec

[GitHub] maven issue #70: MNG-6049: Adds version range result filter behaviour

2016-06-21 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven/pull/70 @talios Not yet public. I'll create a public example extension if the 3.4.0 release is available. See integration test: https://github.com/apache/maven-integration-testing/pull/14 Not easy to r

[GitHub] maven issue #70: MNG-6049: Adds version range result filter behaviour

2016-06-21 Thread talios
Github user talios commented on the issue: https://github.com/apache/maven/pull/70 @barthel is there an example anywhere of using this? I have a project (custom lifecycle extension) myself where I think utilizing this will actually make what I'm doing much easier, nicer, and probably

[GitHub] maven-integration-testing issue #14: MNG-6049: Adds integration tests for ve...

2016-06-21 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 @barthel Can you also take care of the file names in the PR? `mng3092` to `mng-6049`. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] maven-integration-testing issue #14: MNG-3092: Adds integration tests for ve...

2016-06-21 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 Relabelling commit from MNG-3092 to MNG-6049. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

2016-06-21 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven/pull/70 Relabelling commit from MNG-3092 to MNG-6049. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

2016-06-21 Thread rfscholte
Github user rfscholte commented on the issue: https://github.com/apache/maven-scm/pull/31 https://github.com/apache/maven-scm/blob/master/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/test/java/org/apache/maven/scm/provider/git/gitexe/command/status/GitStatu

[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

2016-06-21 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/maven/pull/70 @barthel Perfect, already assigned. Just waiting for an updated PR and all will be merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-21 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67946906 --- Diff: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3092VersionRangeResultFilterExtensionTest.java --- @@ -0,0 +1,132 @@

[GitHub] maven-integration-testing issue #14: MNG-3092: Adds integration tests for ve...

2016-06-21 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 @michael-o Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-21 Thread barthel
Github user barthel commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67945228 --- Diff: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3092VersionRangeResultFilterExtensionTest.java --- @@ -0,0 +1,132 @@

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

2016-06-21 Thread rfscholte
Github user rfscholte commented on the issue: https://github.com/apache/maven-scm/pull/31 I think we missed something. `GitStatusConsumer` says /** * Entries are relative to working directory, not to the repositoryroot */ private List changedFiles

[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

2016-06-21 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven/pull/70 @michael-o Please take a look at https://issues.apache.org/jira/browse/MNG-6049 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-21 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67942011 --- Diff: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3092VersionRangeResultFilterExtensionTest.java --- @@ -0,0 +1,132 @@

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-21 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67941526 --- Diff: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3092VersionRangeResultFilterExtensionTest.java --- @@ -0,0 +1,132 @@

Re: VOTE] Release Apache Maven Source Plugin version 3.0.1

2016-06-21 Thread Michael Osipov
Am 2016-06-18 um 16:49 schrieb Karl Heinz Marbaise: Hi, We solved 8 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317924&version=12335588 There are still one issue left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSOURCES%20AND%20status%20%3

[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

2016-06-21 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/maven/pull/70 @barthel ITs pass. I am now willing to merge both PRs. Just waiting for your comment on the previous message. --- If your project is set up for it, you can reply to this email and have your reply ap

Re: VOTE] Release Apache Maven Source Plugin version 3.0.1

2016-06-21 Thread Karl Heinz Marbaise
Hi, here is my +1 two PMC Votes missings... Kind regards Karl Heinz On 6/18/16 4:49 PM, Karl Heinz Marbaise wrote: Hi, We solved 8 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317924&version=12335588 There are still one issue left in JIRA: https://issues.apache

Re: [VOTE] Release Apache Maven JAR Plugin version 3.0.2

2016-06-21 Thread Karl Heinz Marbaise
Hi, here is my +1... one more PMC VOTE needed... Kind regards Karl Heinz On 6/18/16 4:24 PM, Karl Heinz Marbaise wrote: Hi, We solved 4 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317526&version=12336062&styleName=Text There are still a couple of issues left i

[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

2016-06-21 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/maven/pull/70 I am already working on your PRs. I think, committing this under MNG-3092 is wrong and will explain why. I we cannot close the issue, people won't see this in the changelog. They won't simply know th

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

2016-06-21 Thread sergei-ivanov
Github user sergei-ivanov commented on the issue: https://github.com/apache/maven-scm/pull/31 I need help with that from the Apache team. In the original version of `GitCheckInCommand`, just before committing, the list of files to be committed was passed to `git add`. This ensured

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

2016-06-21 Thread YogiKhan
Github user YogiKhan commented on the issue: https://github.com/apache/maven-scm/pull/31 @sergei-ivanov I followed the steps and i was able to run the plugin without any error but couple of things noticed: - release-pom.xml is also check-in as part of tag along with pom.xml

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

2016-06-21 Thread sergei-ivanov
Github user sergei-ivanov commented on the issue: https://github.com/apache/maven-scm/pull/31 @YogiKhan you will need to build this PR branch of `maven-scm`, and then build `maven-release` project against it. Then you'll need to update the version of `maven-release-plugin` in your own

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

2016-06-21 Thread YogiKhan
Github user YogiKhan commented on the issue: https://github.com/apache/maven-scm/pull/31 @sergei-ivanov, till it get merge, where i can find the 1.9.5-beta1 version? So that i can test it ? --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

2016-06-21 Thread YogiKhan
Github user YogiKhan commented on the issue: https://github.com/apache/maven-scm/pull/31 Thanks @sergei-ivanov @olamy can we merge that and create a release ? is it gonna take time? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

2016-06-21 Thread sergei-ivanov
Github user sergei-ivanov commented on the issue: https://github.com/apache/maven-scm/pull/31 @olamy I've done a rebase onto the latest master and re-pushed the changes to the PR branch. _However_, there still exists an unresolved regression (as pointed out by @indrgun), when

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

2016-06-21 Thread YogiKhan
Github user YogiKhan commented on the issue: https://github.com/apache/maven-scm/pull/31 @sergei-ivanov can we resolve that. This plugin is quite powerful and we are waiting for so long to get that bug fix. Can you please resolve and merge. --- If your project is set up for