[GitHub] maven pull request: [WIP] Hook up gossip as slf4j backend and impl...

2016-05-20 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-220746502 Yes, leave it to JAnsi to decide. Just noticed that they do not provide a native package for FreeBSD. Will reach out to them next week. --- If your project is set up fo

[GitHub] maven pull request: [WIP] Hook up gossip as slf4j backend and impl...

2016-05-20 Thread jdillon
Github user jdillon commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-220746222 @michael-o yup, that is what is used internally by AnsiConsole.wrapOutputStream() to _help_ detect if it should strip sequences or not, but its not a proper public api to

[GitHub] maven pull request: [WIP] Hook up gossip as slf4j backend and impl...

2016-05-20 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-220746069 It seems there is some magic: https://github.com/fusesource/jansi-native/blob/master/src/main/java/org/fusesource/jansi/internal/CLibrary.java#L59 --- If your project i

[GitHub] maven pull request: [WIP] Hook up gossip as slf4j backend and impl...

2016-05-20 Thread jdillon
Github user jdillon commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-220744680 @michael-o the jansi library has some limited support to detect tty when wrapping and potentially strip sequenced. I've pushed a change which makes the gossip listener aw

[GitHub] maven pull request: [WIP] Hook up gossip as slf4j backend and impl...

2016-05-20 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-220743917 I know, that is why I have asked for. You may check out the link I have provided. This might help. Probably you should mention this limitation in your docs. --- If you

[GitHub] maven pull request: [WIP] Hook up gossip as slf4j backend and impl...

2016-05-20 Thread jdillon
Github user jdillon commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-220743522 @michael-o w/o making more of the embedder aware of potential colorization its not easy to do. I will push an example which should make > and -l work but it does involve

[GitHub] maven pull request: [WIP] Hook up gossip as slf4j backend and impl...

2016-05-20 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-220738504 What happens if the opts are set but `-l` or `>` is used? Do you detect that `System.out` is not a terminal? --- If your project is set up for it, you can reply to this

[GitHub] maven pull request: [WIP] Hook up gossip as slf4j backend and impl...

2016-05-20 Thread jdillon
Github user jdillon commented on a diff in the pull request: https://github.com/apache/maven/pull/81#discussion_r64118607 --- Diff: pom.xml --- @@ -282,6 +282,16 @@ 1.1.7 true + +org.sonatype.gossip +gossip-slf4

[GitHub] maven pull request: [WIP] Hook up gossip as slf4j backend and impl...

2016-05-20 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven/pull/81#discussion_r64118541 --- Diff: pom.xml --- @@ -282,6 +282,16 @@ 1.1.7 true + +org.sonatype.gossip +gossip-sl

[GitHub] maven pull request: Hook up gossip as slf4j backend and implement ...

2016-05-20 Thread jdillon
Github user jdillon commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-220737076 Pending a groupId update to get a release of gossip which has a few minor bug fixes to make the core-it-suite happy. --- If your project is set up for it, you can reply t