[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-11-23 Thread phang98
Github user phang98 commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-159179107 Hi guys, I was away to focus on other critical project for the past few months. I'll get it done by this week. Sorry for the long waiting. --- If your project is set

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-11-23 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-159078734 Thanks, I will test and merge tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-11-23 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-159076106 POM file adapted. Use parent version 3.3.10-SNAPSHOT and remove ```commons-lang``` dependency. --- If your project is set up for it, you can reply to this email and have

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-11-23 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-159062461 @barthel See my inline comments. Then I will take it from there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-11-23 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-159060418 @barthel Sorry, messed you up. @phang98 Can you make the requested changes? --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-11-23 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-159059568 @michael-o see my comment Oct 19: > Please remove version property for commons-lang when merging into the master. That's the rework you suggest with working on

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-11-23 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-159057440 @michael-o Sorry. I'm not the owner of this PR. I only push that change forward. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-11-23 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-159045917 @barthel Please squash! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-11-23 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-159045732 @barthel GitHub tells me that this branch has conflicts. Can you kindly check if rebase on top of master if necessary? --- If your project is set up for it, you can rep

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-11-23 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-159011269 I would like to see this changes in the next Maven (3.3.10) release. @michael-o @jvanzyl Please don't forget to merge :-) --- If your project is set up for it, you can

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-11-23 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-159010718 I would like to see this behaviour in the next Maven (3.3.10) release. @phang98 What's the status of the integration tests? @jvanzyl Do you like to merge this change