[call for review] MNG-3525 Settings.xml allowing mirror definitions inside profiles

2015-10-31 Thread Martin W. Kirst
Hi there, I've added a patch to https://issues.apache.org/jira/browse/MNG-3525 and I would like to ask you, if one might have a look on ... doing a review, please. While extending the class Settings and implementing I stumbled upon to similar classes: DefaultMavenExecutionRequestPopulator and Set

[VOTE] Release Apache Maven Shared Components POM Version 22

2015-10-31 Thread Karl Heinz Marbaise
Hi, JIRA Reference: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311250&version=12328931 Changes since the last release: http://svn.apache.org/viewvc/maven/shared/tags/maven-shared-components-22/pom.xml?r1=HEAD&r2=1632934&diff_format=h Staging repo: https://repository.apac

Re: [VOTE] Maven 3.3.8

2015-10-31 Thread Mirko Friedenhagen
+1 non-binding, tested with some projects. Regards Mirko -- http://illegalstateexception.blogspot.com/ https://github.com/mfriedenhagen/ (http://osrc.dfm.io/mfriedenhagen) https://bitbucket.org/mfriedenhagen/ On Fri, Oct 30, 2015 at 10:26 PM, Arnaud Héritier wrote: > +1 > > On Fri, Oct 30, 2015

Re: Maven Release Version Policy

2015-10-31 Thread Robert Scholte
I'm probably the only one who could answer that, although I can't recall this question. yes,some handling of version specific parts have been improved,but this looks like regression to me. I might have misunderstood the issue. Robert(cruising down highway 1) Verzonden vanaf Samsung Mobile. --

Re: Maven Release Version Policy

2015-10-31 Thread Stephen Connolly
On Saturday 31 October 2015, Hervé BOUTEMY wrote: > if there is a regression, why not just open a Jira issue and fix it? IIRC when I pointed out the bug 6-9 months ago Robert or somebody said that the new behaviour was by design... > > I had a look at code, and it seems there is not any unit

Re: Maven Release Version Policy

2015-10-31 Thread Hervé BOUTEMY
if there is a regression, why not just open a Jira issue and fix it? I had a look at code, and it seems there is not any unit test against default version policy Regards, Hervé Le samedi 31 octobre 2015 17:41:45 Stephen Connolly a écrit : > On Saturday 31 October 2015, Hervé BOUTEMY wrote: >

Re: Maven Release Version Policy

2015-10-31 Thread Stephen Connolly
On Saturday 31 October 2015, Hervé BOUTEMY wrote: > I don't know what "Cloudbees conventions" are, and how they are superior to > everything else = what I understand from the README I jusj had to put a readme quickly. It is basically increment the least significant segment (which is what the r

Re: Suggestions for the Announcement Mail for Maven 3.3.8 with credit to contributor/reports

2015-10-31 Thread Karl Heinz Marbaise
Hi Hervé, On 10/31/15 3:21 PM, Hervé BOUTEMY wrote: I don't understand "reporter": it's about issues? The reporter is the reporter of the issue...yes.. what about "code contributors" and "issue reporters"? to make things more clear yes good idea.i will change this... Regards, He

Re: Suggestions for the Announcement Mail for Maven 3.3.8 with credit to contributor/reports

2015-10-31 Thread Hervé BOUTEMY
I don't understand "reporter": it's about issues? what about "code contributors" and "issue reporters"? Regards, Hervé Le samedi 31 octobre 2015 14:41:26 Karl Heinz Marbaise a écrit : > Hi, > i have updated the JIRA with appropriate issues which have been missing > etc. Added missing reporters/

Re: Maven Release Version Policy

2015-10-31 Thread Hervé BOUTEMY
ok great! IIUC, it calculates version per package, based on automatic API comparison for release plugin, we need to calculate a version of the whole artifact. And since it's java, not OSGi, then there is no strict separation between API and internal details, I fear such approach won't give a g

Re: Maven Release Version Policy

2015-10-31 Thread Robert Scholte
IIRC Simone did an attempt but stopped  when he discovered that the maven-release-plugin wants to know the version up front where as semver requires compilation first causing a chicken / egg problem. Robert Verzonden vanaf Samsung Mobile. Oorspronkelijk bericht Van: Uwe Barthe

Re: Suggestions for the Announcement Mail for Maven 3.3.8 with credit to contributor/reports

2015-10-31 Thread Jason van Zyl
I think that looks great, Thanks Karl, much appreciated. > On Oct 31, 2015, at 6:41 AM, Karl Heinz Marbaise wrote: > > Hi, > i have updated the JIRA with appropriate issues which have been missing etc. > Added missing reporters/contributors to the suggestion of the announcment > main: > > ===

Suggestions for the Announcement Mail for Maven 3.3.8 with credit to contributor/reports

2015-10-31 Thread Karl Heinz Marbaise
Hi, i have updated the JIRA with appropriate issues which have been missing etc. Added missing reporters/contributors to the suggestion of the announcment main: === START == The Apache Maven team is pleased to announce the release of Apache M

Re: Maven Release Version Policy

2015-10-31 Thread Uwe Barthel
> great: what is the bundle-maven-plugin feature you're talking about? The ‘baseline’[1] goal. It based on the BND Tool[2] (by Peter Kriens), gets the previous release (!) and check the difference between the byte code. Following semver, any new method (new feature) requires a new minor change. C

Re: Maven Release Version Policy

2015-10-31 Thread Hervé BOUTEMY
great: what is the bundle-maven-plugin feature you're talking about? Regards, Hervé Le samedi 31 octobre 2015 13:18:35 Uwe Barthel a écrit : > > I'm not sure "strict semver" can be automated: functional change can't be > > easily detected if there is no API change > > The bundle-maven-plugin be

Re: Maven Release Version Policy

2015-10-31 Thread Uwe Barthel
> I'm not sure "strict semver" can be automated: functional change can't be > easily detected if there is no API change The bundle-maven-plugin behaviour is a good base to discuss about I think. mit freundlichen Grüßen Uwe Barthel -- bart...@x-reizend.de > On 31 Oct 2015, at 12:32, Hervé BOUT

Re: Maven Release Version Policy

2015-10-31 Thread Uwe Barthel
> by that you mean you expect a version policy implementation that runs a > bytecode check against previous version (like clirr) then chooses to increase > major minor or patch digit? Why not. But not choose automatically instead of warning or break the release. I’m use the bundle-maven-plugin

Re: maven git commit: Fix for urls being empty in the POM and causing an out of bounds exception

2015-10-31 Thread Hervé BOUTEMY
ok, I updated https://issues.apache.org/jira/browse/MNG-5871 FYI, MNG-5878 implementation is waiting in a branch for a new non-patch release, to be semver compliant, since it's a new feature Regards, Hervé Le vendredi 30 octobre 2015 00:31:44 Jason van Zyl a écrit : > I don’t think it’s necess

Re: Maven Release Version Policy

2015-10-31 Thread Hervé BOUTEMY
I'm not sure "strict semver" can be automated: functional change can't be easily detected if there is no API change semver is a great buzzword, but we should try to explain more precisely what can be automated in the plugin to try to follow the buzzword Regards, Hervé Le samedi 31 octobre 201

Re: Maven Release Version Policy

2015-10-31 Thread Hervé BOUTEMY
by that you mean you expect a version policy implementation that runs a bytecode check against previous version (like clirr) then chooses to increase major minor or patch digit? Regards, Hervé Le vendredi 30 octobre 2015 07:33:45 Jason van Zyl a écrit : > I would prefer to move toward standard

Re: Maven Release Version Policy

2015-10-31 Thread Uwe Barthel
Hi, I’m with Jason to move Maven forward to use (strict) semver as default version strategy. I understand the 'cloudbee' strategy as a more exotic way. But I'm interested in more than one strategy, configurable via plugin or providing by default plugin. mit freundlichen Grüßen Uwe Barthel --

Re: Maven Release Version Policy

2015-10-31 Thread Hervé BOUTEMY
I don't know what "Cloudbees conventions" are, and how they are superior to everything else = what I understand from the README if we were able to better describe this policy, and compare different policies, that would give a meaning to adding more and providing them by default in the plugin to