Re: [VOTE] Maven 3.3.6

2015-08-02 Thread Jason van Zyl
I’m not sure a unit test really matters as it was a conscious change in a public signature which in and of itself is fine. If the signature changed then a unit test would have to change accordingly. But unless we have something akin to Clirr or a semantic version check then we don’t know how thi

Re: [VOTE] Maven 3.3.6

2015-08-02 Thread Anton Tanasenko
Sure thing, I'll update pull request. Thanks for reminding. 2015-08-02 21:00 GMT+03:00 Robert Scholte : > Even though the changes seem too simple, I'd like to see unittests to > prevent this from happening again. > I don't mind writing them. > > Robert > > Op Sat, 01 Aug 2015 17:05:37 +0200 schre

Re: [VOTE] Maven 3.3.6

2015-08-02 Thread Robert Scholte
Even though the changes seem too simple, I'd like to see unittests to prevent this from happening again. I don't mind writing them. Robert Op Sat, 01 Aug 2015 17:05:37 +0200 schreef Anton Tanasenko : I've created yet another PR for MNG-5805: https://github.com/apache/maven/pull/62 Sorry g