Re: maven-changes-plugin: AnnouncementMojo requires dependency resolution ResolutionScope.TEST

2015-07-19 Thread Olivier Lamy
Hi, IMHO this doesn't make sense so get rid of it. Olivier On 16 July 2015 at 05:29, Mirko Friedenhagen wrote: > Hello everybody, > > according to > https://github.com/apache/maven-plugins/blob/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/AnnouncementMojo.java#L

[CANCELLED] Re: [VOTE] Maven 3.3.4

2015-07-19 Thread Jason van Zyl
I will dump 3.3.4 and re-roll it with Anton’s fix for the incompatibility. Thanks Mirko for noticing that. Probably would have caused a lot of aggravation. I re-run the release early this week. > On Jul 18, 2015, at 8:31 AM, Jason van Zyl wrote: > > Hi, > > Time to release Maven 3.3.4! > > H

Re: [VOTE] Maven 3.3.4

2015-07-19 Thread Anton Tanasenko
I've renamed getter methods in question from xPhases to xLifecyclePhases and reimplemented the original ones to preserve full compatibility. Setters were left mostly as is since imo those are not called from outside of maven core. Pull request is submitted for https://issues.apache.org/jira/browse/

[GitHub] maven pull request: MNG-5805: Restore binary compatibility

2015-07-19 Thread atanasenko
GitHub user atanasenko opened a pull request: https://github.com/apache/maven/pull/59 MNG-5805: Restore binary compatibility You can merge this pull request into a Git repository by running: $ git pull https://github.com/atanasenko/maven master Alternatively you can review an

Re: [VOTE] Maven 3.3.4

2015-07-19 Thread Jason van Zyl
Anton changed the type of a public class so I think he’s going to put it back. It will break all enforcer plugin users which is not good. > On Jul 19, 2015, at 5:28 PM, Karl Heinz Marbaise wrote: > > Hi, > > sounds like maven-enforcer needs a fix ? > > Might it better to change maven-enforce

Re: [VOTE] Maven 3.3.4

2015-07-19 Thread Karl Heinz Marbaise
Hi, sounds like maven-enforcer needs a fix ? Might it better to change maven-enforcer as well ? Apart from Maven 3.3.4 breaking compatibility ? Or is this a good step into future direction from Maven perspective? Kind regards Karl Heinz Marbaise On 7/19/15 10:23 PM, Mirko Friedenhagen wrote

Re: [VOTE] Maven 3.3.4

2015-07-19 Thread Anton Tanasenko
I'll try to get binary compatibility back shortly. 2015-07-19 23:31 GMT+03:00 Mirko Friedenhagen : > I just tried to build the HEAD of enforcer and all ITs for > require-plugin-versions and additionally resolve_collect_dependencies > are broken. > Regards Mirko > -- > http://illegalstateexception

Re: [VOTE] Maven 3.3.4

2015-07-19 Thread Jason van Zyl
Good catch. I believe this is part of Anton’s submission so maybe he has a suggestion. > On Jul 19, 2015, at 4:23 PM, Mirko Friedenhagen > wrote: > > The behaviour change was probably introduced with > https://github.com/apache/maven/commit/1d148be82bcf3e16c01477d412f4f9206445a7aa#diff-16983b0

Re: [VOTE] Maven 3.3.4

2015-07-19 Thread Mirko Friedenhagen
I just tried to build the HEAD of enforcer and all ITs for require-plugin-versions and additionally resolve_collect_dependencies are broken. Regards Mirko -- http://illegalstateexception.blogspot.com/ https://github.com/mfriedenhagen/ (http://osrc.dfm.io/mfriedenhagen) https://bitbucket.org/mfriede

Re: [VOTE] Maven 3.3.4

2015-07-19 Thread Mirko Friedenhagen
The behaviour change was probably introduced with https://github.com/apache/maven/commit/1d148be82bcf3e16c01477d412f4f9206445a7aa#diff-16983b0795e70151790709d0d16ab0c9R103 Before we had: * Map phaseToGoalMapping = null; Now it is: Map phaseToGoalMapping = null; The requirePluginVersions plugin ca

Re: [VOTE] Maven 3.3.4

2015-07-19 Thread Anton Tanasenko
This looks to be a consequence of MNG -5805 :( 2015-07-19 23:12 GMT+03:00 Mirko Friedenhagen : > This seems to affect project which use as an > enforcer-rule. After inserting this rule into another project I get a > similar stack trace. > > --

Re: [VOTE] Maven 3.3.4

2015-07-19 Thread Mirko Friedenhagen
This seems to affect project which use as an enforcer-rule. After inserting this rule into another project I get a similar stack trace. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail:

Re: [VOTE] Maven 3.3.4

2015-07-19 Thread Mirko Friedenhagen
Hello, -1 non-binding I tried to do a `mvn clean verify` in project https://github.com/mojohaus/mojo-parent, however I get the following error: Apache Maven 3.3.4 (df509db95a565e09ee25edd63b5574f58ba3b077; 2015-07-17T20:10:18+02:00) Maven home: /Software/nobackup/apache-maven-3.3.4 Java version: