Github user Tibor17 commented on the pull request:
https://github.com/apache/maven/pull/53#issuecomment-113717735
try-with-resources is cool.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
one more binding VOTE needed..
On 6/18/15 3:23 PM, Jason van Zyl wrote:
+1
On Jun 18, 2015, at 2:53 AM, Karl Heinz Marbaise wrote:
Hi,
here is my +1.
Kind regards
Karl Heinz Marbaise
On 6/16/15 10:15 PM, Karl Heinz Marbaise wrote:
Hi,
We solved 2 issues:
https://issues.apache.org/jira/s
Github user sugartxy commented on the pull request:
https://github.com/apache/maven/pull/53#issuecomment-113709155
@jvanzyl Please let me know if you want something else to be done on this
pull request before you could merge it.
---
If your project is set up for it, you can reply to
Perforce checks out fiel with only, maven invoker 1.10 copy file over to
target and keep the permission intact ( not with 1.9), and test file sine
some test modified the readonly file
btw, the fix uses java 6 API
-Dan
On Fri, Jun 19, 2015 at 10:08 AM, Kristian Rosenvold <
kristian.rosenv...@zeni
I am a bit surprised the proposed fix does the trick; I thought perforce
checked out *every file* read only ?
Kristian
2015-06-19 17:22 GMT+02:00 Karl Heinz Marbaise (JIRA) :
>
> [
> https://issues.apache.org/jira/browse/MINVOKER-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comme
And yet no pointer to the new list ;-) (I havent used it enough already
that the borg-mail web client shows it in autocomplete)
On 19 June 2015 at 15:47, Baptiste Mathus wrote:
> I guess you talk about the users list, that one we agreed on hijacking,
> yes, not the dev one :-).
>
> 2015-06-19 15
I guess you talk about the users list, that one we agreed on hijacking,
yes, not the dev one :-).
2015-06-19 15:52 GMT+02:00 Stephen Connolly :
> I though we were hijacking the maven list... but if I had that wrong,
> that's fair enough
>
> On 19 June 2015 at 07:39, Baptiste Mathus wrote:
>
> >
I though we were hijacking the maven list... but if I had that wrong,
that's fair enough
On 19 June 2015 at 07:39, Baptiste Mathus wrote:
> Didn't you send to the wrong list?
>
> 2015-06-18 23:59 GMT+02:00 Dan Tran :
>
> > do we still stage at nexus.codehaus.org?
> >
> > Thanks
> >
> > -D
> >
>
Github user pcollaog commented on the pull request:
https://github.com/apache/maven/pull/44#issuecomment-113517031
Any plans to fix this problem?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user sugartxy commented on the pull request:
https://github.com/apache/maven/pull/53#issuecomment-113508412
@ifedorenko @jvanzyl thx. I will rewrite it using try-with-resources ASAP.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
+1
> On Jun 19, 2015, at 7:35 AM, Tibor Digana wrote:
>
> We need one more PMC to vote please.
>
>
>
> --
> View this message in context:
> http://maven.40175.n5.nabble.com/VOTE-Release-Apache-Maven-Shared-Utils-version-0-8-tp5837727p5837952.html
> Sent from the Maven Developers mailing lis
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/53#issuecomment-113505944
+1 please use try-with-resources
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user ifedorenko commented on the pull request:
https://github.com/apache/maven/pull/53#issuecomment-113485035
Maven is targeting java 7 already, try-with-resource is more appropriate
way to guarantee IO streams are closed.
---
If your project is set up for it, you can reply to
We need one more PMC to vote please.
--
View this message in context:
http://maven.40175.n5.nabble.com/VOTE-Release-Apache-Maven-Shared-Utils-version-0-8-tp5837727p5837952.html
Sent from the Maven Developers mailing list archive at Nabble.com.
-
GitHub user sugartxy opened a pull request:
https://github.com/apache/maven/pull/53
#MNG-5844: Close IO Streams in finally block
Place the close method in the finally clause, so we can ensure it always
runs regardless of how the method exits.
You can merge this pull request into
15 matches
Mail list logo
